Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Send Money - The participant selection page for Send money flow is noticeably slower #33322

Closed
4 of 6 tasks
lanitochka17 opened this issue Dec 19, 2023 · 8 comments
Closed
4 of 6 tasks
Assignees

Comments

@lanitochka17
Copy link

lanitochka17 commented Dec 19, 2023

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!


Version Number: 1.4.14-0
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:

Issue found when executing PR #32962

Action Performed:

  1. Navigate to staging.new.expensify.com
  2. Go to FAB> Send Money> Add amount

Expected Result:

The participant selection page should be immediately open

Actual Result:

The participant selection page for Send money flow is noticeably slower
Also, Search page hangs for seconds when closing it while the list is still loading

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • Windows: Chrome
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6320291_1703019166912.Recording__1592.mp4

View all open jobs on GitHub

@lanitochka17 lanitochka17 added the DeployBlockerCash This issue or pull request should block deployment label Dec 19, 2023
Copy link
Contributor

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

Copy link

melvin-bot bot commented Dec 19, 2023

Triggered auto assignment to @NikkiWines (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

@NikkiWines
Copy link
Contributor

@lanitochka17 we had a regression tied to this flow that was fixed just now, could you re-test this please 🙇

@NikkiWines
Copy link
Contributor

This loads immediately for me on staging, I don't think this is a blocker

Screen.Recording.2023-12-19.at.17.31.07.mov

@francoisl francoisl removed the DeployBlockerCash This issue or pull request should block deployment label Dec 19, 2023
@TMisiukiewicz
Copy link
Contributor

Still happens to me on main when using heavy account. I think it should be reopened as it seems it's not a regression from #32962

Screen.Recording.2023-12-20.at.12.46.42.mov

@mountiny
Copy link
Contributor

@TMisiukiewicz The heavy account is really putting strain in the app, can you confirm that production is noticeably faster than staging for that account?

@TMisiukiewicz
Copy link
Contributor

@mountiny staging and production are both suffering on that account, seems like the result is very similar

@mountiny
Copy link
Contributor

In that case I think we can keep this closed as not a blocker and maybe bring this as a problem to performance channel and something to audit/ deiagnose for heavy accounts

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants