[Awaiting manual request payment] [$125] [Form Provider Refactor] BaseGetPhysicalCard

[luacmartins]

Coming from #25397 (comment), we created a new Form provider that works with functional components and we need to refactor all usages of the old Form component.

This issue is specific to refactoring /src/pages/settings/Wallet/Card/BaseGetPhysicalCard.js

cc @kowczarz @cdOut

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01010134d1b710294c
• Upwork Job ID: 1737478271858073600
• Last Price Increase: 2023-12-20

[melvin-bot]

Triggered auto assignment to @kadiealexander (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[kowczarz]

I would like to work on this issue.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01010134d1b710294c

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @rushatgabhane (External)

[melvin-bot]

Upwork job price has been updated to $125

[ghost]

Can I work on it ?

[luacmartins]

Thanks for the interest @AnshuAgarwal24, but we already assigned @kowczarz to the issue.

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.23-4 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• [Form Provider Refactor] BaseGetPhysicalCard #33360

If no regressions arise, payment will be issued on 2024-01-17. 🎊

For reference, here are some details about the assignees on this issue:

• @rushatgabhane requires payment through NewDot Manual Requests
• @kowczarz does not require payment (Contractor)

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@rushatgabhane] The PR that introduced the bug has been identified. Link to the PR:
• [@rushatgabhane] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@rushatgabhane] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@rushatgabhane] Determine if we should create a regression test for this bug.
• [@rushatgabhane] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@kadiealexander] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[rushatgabhane]

@kadiealexander could you please add payment summary for me

[rushatgabhane]

checklist not applicable because this is a refactor.

[kadiealexander]

Payouts due:

• Contributor+: $125 @rushatgabhane

[rushatgabhane]

thank you!
manual request- https://staging.new.expensify.com/r/4369792081581150

[JmillsExpensify]

$125 approved for @rushatgabhane based on summary above.