Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[$500] System message is formatted differently with the names has apostrophe #33378

Closed
1 of 6 tasks
m-natarajan opened this issue Dec 20, 2023 · 16 comments
Closed
1 of 6 tasks
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 External Added to denote the issue can be worked on by a contributor Help Wanted Apply this label when an issue is open to proposals by contributors

Comments

@m-natarajan
Copy link

m-natarajan commented Dec 20, 2023

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!


Version Number:
Reproducible in staging?: Needs reproduction
Reproducible in production?: Needs reproduction
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @quinthar
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1703015541706559

Action Performed:

  1. Go to a workskpace
  2. Add few members with one of the user has apostrophe in the name
  3. Open the #admin room
  4. Observe the system messages

Expected Result:

All the messages should be formatted in the same way

Actual Result:

The one which has apostrophe in the name is formatted differently

Workaround:

unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

image (6)

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~017b611c4c2a17b8f3
  • Upwork Job ID: 1737982029792141312
  • Last Price Increase: 2024-01-04
@m-natarajan m-natarajan added Daily KSv2 Needs Reproduction Reproducible steps needed Bug Something is broken. Auto assigns a BugZero manager. labels Dec 20, 2023
Copy link

melvin-bot bot commented Dec 20, 2023

Triggered auto assignment to @sakluger (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

Copy link

melvin-bot bot commented Dec 20, 2023

Bug0 Triage Checklist (Main S/O)

  • This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
  • This bug is not a duplicate report (check E/App issues and #expensify-bugs)
    • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
  • This bug is reproducible using the reproduction steps in the OP. S/O
    • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
    • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
  • This issue is filled out as thoroughly and clearly as possible
    • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
  • I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

@sakluger
Copy link
Contributor

I reported this back in August (GH) and didn't realize that it was the apostrophe that was causing issues. I'm not sure why @m-natarajan is unable to reproduce, I can confirm that I saw the same behavior around names with apostrophes.

@sakluger sakluger added External Added to denote the issue can be worked on by a contributor and removed Needs Reproduction Reproducible steps needed labels Dec 21, 2023
@melvin-bot melvin-bot bot changed the title System message is formatted differently with the names has apostrophe [$500] System message is formatted differently with the names has apostrophe Dec 21, 2023
Copy link

melvin-bot bot commented Dec 21, 2023

Job added to Upwork: https://www.upwork.com/jobs/~017b611c4c2a17b8f3

@melvin-bot melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Dec 21, 2023
Copy link

melvin-bot bot commented Dec 21, 2023

Triggered auto assignment to Contributor-plus team member for initial proposal review - @eVoloshchak (External)

@FlorianWueest
Copy link

Unable to replicate the issue, neither on MacOS (Chrome), MacOS (Safari) & Win (Chrome). Also tested adding name normally (first & last name field), or entire name in 'first name' field, and entire name in 'last name' field.

Screenshot of MacOS (Chrome):
MacOS Chrome

Screenshot of MacOS (Safari):
MacOS Safari

@melvin-bot melvin-bot bot added the Overdue label Dec 24, 2023
Copy link

melvin-bot bot commented Dec 25, 2023

@sakluger, @eVoloshchak Whoops! This issue is 2 days overdue. Let's get this updated quick!

Copy link

melvin-bot bot commented Dec 27, 2023

@sakluger, @eVoloshchak Eep! 4 days overdue now. Issues have feelings too...

Copy link

melvin-bot bot commented Dec 28, 2023

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

Copy link

melvin-bot bot commented Dec 29, 2023

@sakluger, @eVoloshchak Still overdue 6 days?! Let's take care of this!

@mvtglobally
Copy link

Issue not reproducible during KI retests. (First week)

Copy link

melvin-bot bot commented Jan 2, 2024

@sakluger, @eVoloshchak 10 days overdue. I'm getting more depressed than Marvin.

@sakluger
Copy link
Contributor

sakluger commented Jan 2, 2024

I asked in the original Slack thread if it's still reproduceable.

@melvin-bot melvin-bot bot removed the Overdue label Jan 2, 2024
Copy link

melvin-bot bot commented Jan 3, 2024

@sakluger @eVoloshchak this issue was created 2 weeks ago. Are we close to approving a proposal? If not, what's blocking us from getting this issue assigned? Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

Copy link

melvin-bot bot commented Jan 4, 2024

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

@sakluger
Copy link
Contributor

sakluger commented Jan 4, 2024

No longer reproduceable. Closing!

@sakluger sakluger closed this as completed Jan 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 External Added to denote the issue can be worked on by a contributor Help Wanted Apply this label when an issue is open to proposals by contributors
Projects
None yet
Development

No branches or pull requests

5 participants