[HOLD #33315][VIP-VSP][$500] Chat - Unpinned deleted tasks assigned by another user are shown above other pinned messages

[Christinadobrzyn]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: 1.3.95-0
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:

Action Performed:

1. Login with Account A on new Expensify and assign a task to Account B (example: Tester login credential: [email protected] [email protected])
2. Click on the checkbox of the Task > deselect > Click the three dots
3. Cancel the task
4. Login with Account B > find the Deleted task in the LHN
5. You shouldn't see the GBR and deleted task

Note: If you don't see it above the pinned messages, click on the [Deleted task] message again and eventually it displays above the pinned chats

Expected Result:
The deleted task report should not appear between GRB reports

Actual Result:
The task report still appears between GRB reports and GRB appear in the deleted task report

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

bug.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01df61cddd3904c57f
• Upwork Job ID: 1738278949092667392
• Last Price Increase: 2023-12-29

[melvin-bot]

Current assignee @Christinadobrzyn is eligible for the Bug assigner, not assigning anyone new.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[Christinadobrzyn]

Related to #30798

[DylanDylann]

Proposal

Please re-state the problem that we are trying to solve in this issue.

After canceling the task the GRB still displays on LHN

What is the root cause of that problem?

After canceling the task the GRB still displays on LHN, The pusher return taskReport.isDeletedParentAction === true . But we don't add this field in this function

App/src/libs/SidebarUtils.ts

Line 232 in 7f7cfb3

function getOptionData(

What changes do you think we should make in order to solve the problem?

in this function

App/src/libs/SidebarUtils.ts

Line 232 in 7f7cfb3

function getOptionData(

we should return isDeletedParentAction

    result.isDeletedParentAction = report.isDeletedParentAction;

We also need to do the same thing in the chat report selector here

App/src/pages/home/sidebar/SidebarLinksData.js

Line 170 in 7f7cfb3

parentReportID: report.parentReportID,

should add

        isDeletedParentAction: report.isDeletedParentAction

What alternative solutions did you explore? (Optional)

NA

Result

sol.mp4

[Christinadobrzyn]

I think this should get fixed, I think it can be part of the VIP-VSB - asking for a review.

https://expensify.slack.com/archives/C066HJM2CAZ/p1703269373036479

[Christinadobrzyn]

Added this to VIP-VSP. We can accept proposals for this!

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01df61cddd3904c57f

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @aimane-chnaif (External)

[melvin-bot]

@Christinadobrzyn, @aimane-chnaif Whoops! This issue is 2 days overdue. Let's get this updated quick!

[FitseTLT]

Can't reproduce it. Neither do I see the GRB nor see the deleted task above pinned chats after logging in Account B.

[melvin-bot]

@Christinadobrzyn, @aimane-chnaif Huh... This is 4 days overdue. Who can take care of this?

[DylanDylann]

I still can reproduce on the latest main, @FitseTLT Could you attach your video ?

[melvin-bot]

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

[alitoshmatov]

Looks like this issue and #33315 might have the same root cause. I suggest we hold this issue in favor of #33315 (comment).

[melvin-bot]

@Christinadobrzyn, @aimane-chnaif Now this issue is 8 days overdue. Are you sure this should be a Daily? Feel free to change it!

[melvin-bot]

@Christinadobrzyn, @aimane-chnaif 8 days overdue is a lot. Should this be a Weekly issue? If so, feel free to change it!

[Christinadobrzyn]

adding a HOLD to this in favour of #33477 (comment)

[mvtglobally]

Issue not reproducible during KI retests. (First week)

[Christinadobrzyn]

monitoring

[Christinadobrzyn]

I'm going to be ooo for a week so adding a buddy to monitor this while I'm gone.

Status - this is on hold for #33477 (comment) & KI retests aren't showing this (so we might be able to just close this).

[melvin-bot]

Triggered auto assignment to @garrettmknight (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[garrettmknight]

Still holding

[garrettmknight]

Still holding!

[garrettmknight]

Couldn't reproduce! Closing!