Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deploy Checklist: New Expensify 2023-12-22 #33480

Closed
32 tasks done
github-actions bot opened this issue Dec 22, 2023 · 11 comments
Closed
32 tasks done

Deploy Checklist: New Expensify 2023-12-22 #33480

github-actions bot opened this issue Dec 22, 2023 · 11 comments
Assignees
Labels
🔐 LockCashDeploys 🔐 Prevent new code from being deployed to staging Monthly KSv2 StagingDeployCash

Comments

@github-actions
Copy link
Contributor

github-actions bot commented Dec 22, 2023

Release Version: 1.4.16-5
Compare Changes: production...staging

This release contains changes from the following pull requests:

Deploy Blockers:

Deployer verifications:

  • I checked the App Timing Dashboard and verified this release does not cause a noticeable performance regression.
  • I checked Firebase Crashlytics and verified that this release does not introduce any new crashes. More detailed instructions on this verification can be found here.
  • I checked GitHub Status and verified there is no reported incident with Actions.

cc @Expensify/applauseleads

@kavimuru kavimuru added the 🔐 LockCashDeploys 🔐 Prevent new code from being deployed to staging label Dec 22, 2023
@OSBotify
Copy link
Contributor

🚀 All staging deploys are complete, @Expensify/applauseleads please begin QA on version https://github.com/Expensify/App/releases/tag/1.4.16-3 🚀

@rlinoz
Copy link
Contributor

rlinoz commented Dec 22, 2023

#33512 is fixed here in this PR #33516

Asked for CP here

@kavimuru
Copy link

Regression is 60% progress.

#29996 failing with #33518 reproduced in PROD checking it off
#32473 failing with #33511, it is reverted #33406 - OK to check it off?
#32641 failing with #32298, not fixed in Desktop - Ok to check it off?

@kavimuru
Copy link

Regression is just 1% left.
#32674 failing with #33540

@kavimuru
Copy link

Regression is completed.

#33238 failing with #33551 repro in PROD - checking it off

Unchecked PRs:
#32473 failing with #33511, it is reverted #33406 - OK to check it off?
#32641 failing with #32298, not fixed in Desktop - Ok to check it off?
#32674 failing with #33540

Open Blockers:
#33507
#33509
#33512
#33517
#33540
#33543
#33544
#33556
#33557

@mountiny
Copy link
Contributor

Checking #32473 off as it was reverted

#32641 checking off, desktop not a blocker, noted on the relevant GH

@mountiny
Copy link
Contributor

Reverting #32674 to fix bunch of the deploy blockers

@mountiny
Copy link
Contributor

#33544 demoted happening in prod too

@mountiny
Copy link
Contributor

#33543 demoted as happening in prod and edge case

@mountiny
Copy link
Contributor

Checking of the last blocker #33512 as it has been fixed in main but I dont think its major enough to require a CP.

All deploy blockers are checked off and we only need to CP the straight revert and then we can deploy

@mountiny mountiny self-assigned this Dec 25, 2023
@mountiny
Copy link
Contributor

:shipit:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🔐 LockCashDeploys 🔐 Prevent new code from being deployed to staging Monthly KSv2 StagingDeployCash
Projects
None yet
Development

No branches or pull requests

5 participants