-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[HOLD for payment 2024-01-05] [$500] Android - Request money - Suggested destination displayed instead of new one if entered offline #33505
Comments
Job added to Upwork: https://www.upwork.com/jobs/~01a99352e561737912 |
Triggered auto assignment to @conorpendergrast ( |
Bug0 Triage Checklist (Main S/O)
|
Triggered auto assignment to Contributor-plus team member for initial proposal review - @cubuspl42 ( |
ProposalPlease re-state the problem that we are trying to solve in this issue.Suggested destinations are displayed for the start and finish even after returning online. On the Distance expense receipt, the new address is shown below the suggested one What is the root cause of that problem?In here, we're not setting name of waypoint to null when saving waypoint in offline mode. This causes the new selected waypoint to retain the name of the old waypoint ( What changes do you think we should make in order to solve the problem?In here, set name of waypoint to null when saving waypoint in offline mode, or can set to We should do the same here. Basically we should do the same as we did in this PR (which is for the old money request flow), but we do it for the new money request flow. What alternative solutions did you explore? (Optional)NA |
@cubuspl42, @conorpendergrast Whoops! This issue is 2 days overdue. Let's get this updated quick! |
@dukenv0307 Did you test the proposed changes? Have you confirmed that the changes previously applied to the old flow are suitable for the new flow? |
@cubuspl42 Yes I've tested and it works well 🚀 |
I approve the proposal by @dukenv0307 C+ reviewed 🎀 👀 🎀 |
Triggered auto assignment to @arosiclair, see https://stackoverflow.com/c/expensify/questions/7972 for more details. |
📣 @cubuspl42 🎉 An offer has been automatically sent to your Upwork account for the Reviewer role 🎉 Thanks for contributing to the Expensify app! |
📣 @dukenv0307 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app! Offer link |
@cubuspl42 this PR is ready for review |
|
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.19-2 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue: If no regressions arise, payment will be issued on 2024-01-05. 🎊 After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.
For reference, here are some details about the assignees on this issue:
|
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
|
|
@cubuspl42, @conorpendergrast, @arosiclair, @dukenv0307 Whoops! This issue is 2 days overdue. Let's get this updated quick! |
Payouts due:
Upwork job is here. |
Paid, and contracts ended. This bug was identified by Applause via testing, so I suspect it's already covered under the existing regression testing. I'll close for now, but reopen if you disagree! |
If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!
Version Number: 1.4.16-3
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:
Action Performed:
Expected Result:
Newly entered destinations are displayed as start and finish
Actual Result:
Suggested destinations are displayed for the start and finish even after returning online. On the Distance expense receipt, the new address is shown below the suggested one
Workaround:
Unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
Screenshots/Videos
Add any screenshot/video evidence
Bug6324075_1703257350644.video_2023-12-22_10-01-33.mp4
View all open jobs on GitHub
Upwork Automation - Do Not Edit
The text was updated successfully, but these errors were encountered: