[HOLD for payment 2024-01-25] [Card Settings] 🐛 Damaged flow is saying it will immediately cancel the card, rather than saying it will continue to work until the new card is activated

[kevinksullivan]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: v1.4.16-3
Reproducible in staging?: Y
Reproducible in production?: Y
Email or phone of affected tester (no customers): [email protected]
Issue reported by: @kevinksullivan
Slack conversation: https://expensify.slack.com/archives/C05DWUDHVK7/p1703265858599339

Action Performed:

1. Navigated to wallet
2. Tapped Expensify Card row
3. Selected Report physical card loss / damage
4. Selected My card was damaged

Expected Result:

The copy should explain that the damaged card will remain active until the new one is activated button should say Ship card

Actual Result:

We're showing the same copy / button as we do for a stolen card, which is a different flow that immediately cancels the card and ships a new card with a different PAN

Screenshots/Videos

[melvin-bot]

Triggered auto assignment to @anmurali (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[kevinksullivan]

CC @JKobrynski can you comment so I can assign?

[grgia]

This is the relevant file for tracking

What needs to be changed:
There are two flows here depending on the first choice: Lost/Stolen OR Damaged. Both flows will still make the same API call.

LOST/STOLEN

• copy under address confirmation reads: "Your current card will be permanently deactivated as soon as your order is placed. Most cards arrive in a few business days."
• button copy reads: "Deactivate card"
• after pressing button, the current physical card should be in DEACTIVATED state and the new physical card should be in NOT ACTIVATED state

DAMAGED

• copy under address confirmation reads: "Your new card will arrive in 2-3 business days, and your existing card will continue to work until you activate your new one."
• button copy reads: "Ship new card"
• after pressing button, the current physical card should be in ACTIVE state (3) and the new physical card should be in NOT ACTIVATED state

[melvin-bot]

@grgia Whoops! This issue is 2 days overdue. Let's get this updated quick!

[melvin-bot]

@grgia Huh... This is 4 days overdue. Who can take care of this?

[melvin-bot]

@grgia 8 days overdue is a lot. Should this be a Weekly issue? If so, feel free to change it!

[grgia]

bumped here https://expensify.slack.com/archives/C03UK30EA1Z/p1704227935701489?thread_ts=1703268549.160679&cid=C03UK30EA1Z

[melvin-bot]

@grgia this issue was created 2 weeks ago. Are we close to a solution? Let's make sure we're treating this as a top priority. Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

[grgia]

bumped in slack, should get this assigned out soon!

[grgia]

If not, I'll make this internal

[JKobrynski]

Hi, I'm Julian from Callstack - expert contributor group - and I would like to take a look at this issue.

[JKobrynski]

The PR is ready for review!

[kevinksullivan]

Looks like we're waiting on @grgia for review here!

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.26-2 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• [Card Settings] fix card lost/damaged flow  #34098

If no regressions arise, payment will be issued on 2024-01-25. 🎊

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@grgia] The PR that introduced the bug has been identified. Link to the PR:
• [@grgia] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@grgia] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@grgia] Determine if we should create a regression test for this bug.
• [@grgia] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[hoangzinh]

@kevinksullivan could you help to assign me as a C+ in this issue? I reviewed the PR #34098. Thanks

[hoangzinh]

BugZero Checklist:

• The PR that introduced the bug has been identified. Link to the PR: ⛔ it's a feature request
• The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: N/A
• A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: N/A
• Determine if we should create a regression test for this bug: ⛔ I think this feature request is not really critical to have a regression test for it. Also, it requires adding a wallet, which is not easy to set up.

[melvin-bot]

Unable to auto-create job on Upwork. The BZ team member should create it manually for this issue.

[melvin-bot]

Current assignee @hoangzinh is eligible for the External assigner, not assigning anyone new.

[kevinksullivan]

@hoangzinh offer sent, lmk when you accept

https://www.upwork.com/jobs/~017041742568c125cc

[hoangzinh]

Accepted. Thanks @kevinksullivan

[hoangzinh]

@kevinksullivan when you have time, please help to process payment for this issue. Thanks

[kevinksullivan]

All set