[HOLD for payment 2024-01-04] [HOLD for payment 2024-01-03] [$500] Bank Account - Green square in place of BA icon

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: 1.4.17-1
Reproducible in staging?: y
Reproducible in production?: n
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:

Action Performed:

Pre-requisite: user must have connected a bank account to workspace.

1. Open New Expensify app.
2. Go to Settings > Workspaces > Workspace > Bank account.

Expected Result:

The bank account icon should be displayed on the added account, like the one displayed on the Wallet page.

Actual Result:

There is a green square in the place of the bank account icon.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01e1b5b4f91e738c9a
• Upwork Job ID: 1739684100655161344
• Last Price Increase: 2023-12-26
• Automatic offers:
• shubham1206agra | Reviewer | 28070497

Issue Owner

Current Issue Owner: @rushatgabhane

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot]

Triggered auto assignment to @neil-marcellini (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[shubham1206agra]

Proposal

Please re-state the problem that we are trying to solve in this issue

Bank Account - Green square in place of BA icon

What is the root cause of that problem?

This is happening from 3dc4373, cause they missed the EnableStep component while refactoring.

What changes do you think we should make in order to solve the problem?

Add displayInDefaultIconColor in MenuItem in EnableStep

What alternative solutions did you explore? (Optional)

[shubham1206agra]

Fixed

[shubham1206agra]

@mountiny Can you confirm the icon?

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01e1b5b4f91e738c9a

[melvin-bot]

Current assignee @shubham1206agra is eligible for the External assigner, not assigning anyone new.

[mountiny]

@shubham1206agra I think we are not changing the icon right so whatever is supposed to be there now, are you able to create a PR for this? Thanks!

[shubham1206agra]

@mountiny I need to check one more place where I suspect the problem. I will verify the problem with adhoc build.

[mountiny]

Making a build of the PR

[melvin-bot]

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

[melvin-bot]

Triggered auto assignment to @NicMendonca (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.17-8 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• [CP Staging] Fixed bank account icon #33604

If no regressions arise, payment will be issued on 2024-01-03. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

For reference, here are some details about the assignees on this issue:

• @rushatgabhane requires payment through NewDot Manual Requests
• @shubham1206agra requires payment automatic offer (Reviewer)

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@rushatgabhane / @shubham1206agra] The PR that introduced the bug has been identified. Link to the PR:
• [@rushatgabhane / @shubham1206agra] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@rushatgabhane / @shubham1206agra] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@rushatgabhane / @shubham1206agra] Determine if we should create a regression test for this bug.
• [@rushatgabhane / @shubham1206agra] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@NicMendonca] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[rushatgabhane]

manual request here https://staging.new.expensify.com/r/923381560208585

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.18-8 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• [CP Staging] Fixed bank account icon #33604

If no regressions arise, payment will be issued on 2024-01-04. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

For reference, here are some details about the assignees on this issue:

• @rushatgabhane requires payment through NewDot Manual Requests
• @shubham1206agra requires payment automatic offer (Reviewer)

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@rushatgabhane / @shubham1206agra] The PR that introduced the bug has been identified. Link to the PR:
• [@rushatgabhane / @shubham1206agra] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@rushatgabhane / @shubham1206agra] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@rushatgabhane / @shubham1206agra] Determine if we should create a regression test for this bug.
• [@rushatgabhane / @shubham1206agra] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@NicMendonca] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[rushatgabhane]

1. The PR that introduced the bug has been identified. Link to the PR: Expo image #30905

2. The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: Expo image #30905 (comment)

3. A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: No because it was a giant refacto.

4. Determine if we should create a regression test for this bug. No.

5. If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again - No

[JmillsExpensify]

Still two days to go, though I'm going to handle payment in Expensify anyway. $500 payment approved for @rushatgabhane based on this comment.

[NicMendonca]

@shubham1206agra you've been paid via Upwork!

[NicMendonca]

@rushatgabhane just a bump on the BZ checklist!

[melvin-bot]

@NicMendonca, @rushatgabhane, @mountiny, @shubham1206agra Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[rushatgabhane]

Checklist here #33602 (comment)
This issue can be closed

[mountiny]

@NicMendonca we need to pay to @shubham1206agra before closing

[NicMendonca]

@mountiny yep I did - #33602 (comment)

[NicMendonca]

@rushatgabhane thanks!