Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Payment issue for E/App PR#32765 #33606

Closed
melvin-bot bot opened this issue Dec 26, 2023 · 14 comments
Closed

Payment issue for E/App PR#32765 #33606

melvin-bot bot opened this issue Dec 26, 2023 · 14 comments
Assignees
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Engineering Internal Requires API changes or must be handled by Expensify staff Task

Comments

@melvin-bot
Copy link

melvin-bot bot commented Dec 26, 2023

Issue created to compensate the Contributor+ member for their work on #32765
E/E issue linked to the PR - https://www.github.com/Expensify/Expensify/issues/258522.
Contributor+ member who reviewed the PR - @mananjadhav.

Wait 7 days after the PR is deployed to production before issuing payment in case there are regressions.

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~0196dd349a2992afad
  • Upwork Job ID: 1739700338645696512
  • Last Price Increase: 2023-12-26
@melvin-bot melvin-bot bot added Awaiting Payment Auto-added when associated PR is deployed to production Bug Something is broken. Auto assigns a BugZero manager. Task Weekly KSv2 labels Dec 26, 2023
@melvin-bot melvin-bot bot added the Internal Requires API changes or must be handled by Expensify staff label Dec 26, 2023
Copy link
Author

melvin-bot bot commented Dec 26, 2023

Triggered auto assignment to @JmillsExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

Copy link
Author

melvin-bot bot commented Dec 26, 2023

Job added to Upwork: https://www.upwork.com/jobs/~0196dd349a2992afad

@melvin-bot melvin-bot bot added Daily KSv2 and removed Weekly KSv2 labels Dec 26, 2023
Copy link
Author

melvin-bot bot commented Dec 26, 2023

Bug0 Triage Checklist (Main S/O)

  • This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
  • This bug is not a duplicate report (check E/App issues and #expensify-bugs)
    • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
  • This bug is reproducible using the reproduction steps in the OP. S/O
    • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
    • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
  • This issue is filled out as thoroughly and clearly as possible
    • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
  • I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

Copy link
Author

melvin-bot bot commented Dec 26, 2023

Current assignee @mananjadhav is eligible for the Internal assigner, not assigning anyone new.

@melvin-bot melvin-bot bot added the Overdue label Dec 29, 2023
Copy link
Author

melvin-bot bot commented Jan 1, 2024

@JmillsExpensify, @mananjadhav Huh... This is 4 days overdue. Who can take care of this?

@melvin-bot melvin-bot bot added Daily KSv2 Overdue and removed Daily KSv2 Overdue labels Jan 2, 2024
Copy link
Author

melvin-bot bot commented Jan 5, 2024

@JmillsExpensify, @mananjadhav Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

Copy link
Author

melvin-bot bot commented Jan 9, 2024

@JmillsExpensify @mananjadhav this issue was created 2 weeks ago. Are we close to a solution? Let's make sure we're treating this as a top priority. Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

@mananjadhav
Copy link
Collaborator

@JmillsExpensify This is ready for payout, can you please add the payment summary?

@melvin-bot melvin-bot bot added Overdue and removed Overdue labels Jan 9, 2024
Copy link
Author

melvin-bot bot commented Jan 12, 2024

@JmillsExpensify, @mananjadhav Whoops! This issue is 2 days overdue. Let's get this updated quick!

@JmillsExpensify
Copy link

Payment summary: $500 for PR review and testing.

@melvin-bot melvin-bot bot removed the Overdue label Jan 14, 2024
@JmillsExpensify
Copy link

$500 payment approved for @mananjadhav based on comment above.

Copy link
Author

melvin-bot bot commented Jan 16, 2024

@JmillsExpensify @mananjadhav this issue is now 3 weeks old. There is one more week left before this issue breaks WAQ. What needs to happen to get a PR in review this week? Please create a thread in #expensify-open-source to discuss. Thanks!

Copy link
Author

melvin-bot bot commented Jan 17, 2024

@JmillsExpensify, @mananjadhav Whoops! This issue is 2 days overdue. Let's get this updated quick!

@mananjadhav
Copy link
Collaborator

@JmillsExpensify I think we're good to close here. This was an internal code change for iOS so we might not need a regression test for this one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Engineering Internal Requires API changes or must be handled by Expensify staff Task
Projects
None yet
Development

No branches or pull requests

2 participants