[REPRODUCTION NEEDED] [HOLD for task cleanup] [LOW] [$500] Task - Closed account shows "undefined" and task created by closed account is not accessible

[izarutskaya]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: v1.4.18-3
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause-Internal Team
Slack conversation: @

Action Performed:

Precondition: applause.expensifail.com accounts are used.

1. [User A] Create a group with User B and C.
2. [User B] Go to the group chat and create an unassigned task.
3. [User B] Delete account.
4. [User A] Send a message to another chat. (Important).
5. [User A] Log out and log back in.
6. [User A] Click Search icon and look for the group chat.
7. [User A] Go to the group chat and open the task report.

Expected Result:

In Step 6, the preview for the group chat will display the email of the closed account.
In Step 7, the task should be still accessible.

Actual Result:

In Step 6, the preview for the group chat displays "undefined".
In Step 7, the task is not accessible. Error page shows up.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6327255_1703734595277.20231227_223604__1___1_.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~013e5627e7dbd851e2
• Upwork Job ID: 1740334595657314304
• Last Price Increase: 2023-12-28

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~013e5627e7dbd851e2

[melvin-bot]

Triggered auto assignment to @strepanier03 (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @s77rt (External)

[DylanDylann]

@s77rt Currently, we get task title based on the task report. But when the task creator account is closed, the BE will not return this task report to everyone in the group, the task title in the parent report is empty and we also can't access to the task report

[ankit-ashutec]

@s77rt While investigating this issue, I believe this problem has already been addressed by another pull request but has not been released yet. However, I have identified another issue where the task title is not displayed anywhere, as shown in the picture below.

[ankit-ashutec]

[Updated]

Proposal

Please re-state the problem that we are trying to solve in this issue.

1. group chat will display the email and task title of the closed account.
2. the task should be still accessible.

What is the root cause of that problem?

We obtain the task title from the BE , and when the user who created the task is deleted, the BE is not sending the task report as required for displaying the name and task.

What changes do you think we should make in order to solve the problem?

The BE should also send the deleted user task report.

What alternative solutions did you explore? (Optional)

As @s77rt 's suggestion here, we will display deleted task if the task creator account is close

 return taskTitle ? Localize.translateLocal('task.messages.created', {title: taskTitle}) : Localize.translateLocal('parentReportAction.deletedTask');

And in TaskPreview.js, we need to prevent users from clicking on a task when the owner of that task's account has been deleted.

  const taskOwnerAccountID = Task.getTaskOwnerAccountID(props.taskReport);

    if (isDeletedParentAction || !taskOwnerAccountID) {
        return <RenderHTML html={`<comment>${props.translate('parentReportAction.deletedTask')}</comment>`} />;
    }

Task.js we just need to export getTaskOwnerAccountID.

[s77rt]

@ankit-ashutec Thanks for the proposal. Your RCA is correct. I think we should go with the alternative solution as the BE cannot send deleted data. But instead of changing every instance where getTaskTitle is called, we change getTaskTitle directly:

fallbackTitle || Localize.translateLocal('parentReportAction.deletedTask');

Also we'd need to prevent clicking on that deleted task. Can you please update your proposal to cover that as well?

[DylanDylann]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Task - Closed account shows "undefined" and task created by closed account is not accessible

What is the root cause of that problem?

Currently, we get task title based on the task report. But when the task creator account is closed, the BE will not return this task report to everyone in the group, the task title in the parent report is empty and we also can't access to the task report

What changes do you think we should make in order to solve the problem?

As @s77rt's suggestion here, we will display deleted task if the task creator account is close

App/src/components/ReportActionItem/TaskPreview.js

Lines 106 to 108 in 939632e

	if (isDeletedParentAction) {
	return <RenderHTML html={`<comment>${props.translate('parentReportAction.deletedTask')}</comment>`} />;
	}

So that we need to update like that

if (isDeletedParentAction || !taskTitle) {
        return <RenderHTML html={`<comment>${props.translate('parentReportAction.deletedTask')}</comment>`} />;
    }

With this approach, we also prevent users from clicking on the task report

We also update the same thing in the LHN

App/src/libs/TaskUtils.ts

Line 48 in 8cb48e4

return Localize.translateLocal('task.messages.created', {title: taskTitle});

we should update like that

   return taskTitle ? Localize.translateLocal('task.messages.created', {title: taskTitle}) :  Localize.translateLocal('parentReportAction.deletedTask');

Result

What alternative solutions did you explore? (Optional)

We also consider displaying another message like "Task is deleted because the creator account is closed" to avoid confusion

[s77rt]

@DylanDylann Thanks for the proposal. Your RCA is correct. However the solution won't work as expected as an empty report object does not necessary mean that the task is deleted. This caused many existing tasks showing up as deleted.

[DylanDylann]

@s77rt Updated proposal

Because we want to display [Deleted task] in this case we need to update the condition here

App/src/components/ReportActionItem/TaskPreview.js

Lines 106 to 108 in 939632e

	if (isDeletedParentAction) {
	return <RenderHTML html={`<comment>${props.translate('parentReportAction.deletedTask')}</comment>`} />;
	}

So that we also hide the checkbox before task title

If we change getTaskTitle directly:

fallbackTitle || Localize.translateLocal('parentReportAction.deletedTask');

[Deleted task] will display with the checkbox and the user still can access to task report by clicking on it

[s77rt]

@DylanDylann Thanks for the update. That would work but I think I overlooked the isDeletedParentAction prop. The BE cannot send the deleted task report but it can still send its report action parent.

[DylanDylann]

@s77rt This is task report action in this case

There are no signs to recognize that the task creation account is now closed. So that isDeletedParentAction still be false

[s77rt]

This should be internal. When a user closes his account we are deleting the linked tasks. Each task has a parent report action (or more - if share destination and assignee are different). We should update those report actions as follow:

previousMessage: reportAction.message
message: [
    type: 'COMMENT',
    html: '',
    text: '',
    isEdited: true,
    isDeletedParentAction: true,
]

🎀 👀 🎀 C+ reviewed

[melvin-bot]

Triggered auto assignment to @srikarparsi, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[s77rt]

@DylanDylann That's the task parent report action. It's up to the BE to update it correctly when the task (child) is deleted.

[ankit-ashutec]

@s77rt I have updated my proposal here. It will resolve the issue mentioned here without requiring a backend update.

[s77rt]

@ankit-ashutec Thanks for the update. I think this should be fixed internally as the parent report action is outdated. It can only be fixed in the BE.

[s77rt]

@srikarparsi #33701 (comment)

[strepanier03]

I tagged this for testing and if it can't be repro'd I'm going to close it.

[MelvinBot]

This has been labelled "Needs Reproduction". Follow the steps here: https://stackoverflowteams.com/c/expensify/questions/16989

[s77rt]

Still waiting for repro ^

[s77rt]

Same ^

[DylanDylann]

Currently, after we close an account that creates the task, the task preview display is empty and when clicking the task, Not Found Page appears. Because we still save taskReportID in the action but the task report is deleted

Screen.Recording.2024-10-01.at.14.40.12.mov

@s77rt I think we need to confirm the expectation again

cc @srikarparsi

[s77rt]

@DylanDylann Is the task preview text coming from the report action or the report?

Regarding task accessibility after account deletion, I have asked in Slack

[DylanDylann]

Let's see the logic to return taskTitle in TaskPreview

App/src/libs/TaskUtils.ts

Line 45 in 7dde09e

return Object.hasOwn(taskReport, 'reportID') && 'reportName' in taskReport && typeof taskReport.reportName === 'string' ? taskReport.reportName : fallbackTitle;

In this case, Object.hasOwn(taskReport, 'reportID') is false. Because reportID doesn't exist in taskReport

So this function will return fallbackTitle (fallbackTitle is action?.childReportName). But in this case, action?.childReportName is undefined

[s77rt]

@DylanDylann Ah okay got it! Thanks. Given the info we have the FE can we determine if a task is deleted?

[DylanDylann]

@s77rt Yes, To determine if a task is deleted, we need two checks:

• Check if this is the task: Using isCreatedTaskReportAction function
• Check if this task is deleted: Checking taskReport.taskReportID

[DylanDylann]

Anyways, we should confirm the expected first 😄

[s77rt]

Just bumped the slack thread.

[s77rt]

@DylanDylann

Check if this task is deleted: Checking taskReport.taskReportID

I'm not sure if that would work. What if the task exists but we just don't have it in Onyx? I think we may need a BE change in the report action e.g. check against childStateNum

[strepanier03]

Discussing here.

[strepanier03]

Due to changing the prioritization and utilization of Tasks, we are going to close this and most if not all other bugs dealing with tasks.

Thank you all, closing this now.