[HOLD for payment 2024-02-07] [$500] Room-As invited user, in LHN, sender user id is not displayed under room chat report.

[izarutskaya]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: 1.4.18-2
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause-Internal Team
Slack conversation: @

Action Performed:

1. Launch app
2. Tap on a room chat
3. Tap room header
4. Tap Invite
5. Invite a user to room (eg: [email protected]
   )
6. Login as invited user in mweb(eg: [email protected]
   )

Expected Result:

As invited user, in LHN, sender user id must be displayed under room chat report.

Actual Result:

As invited user, in LHN, sender user id is not displayed under room chat report.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6327346_1703749659586.yui.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01c454898c96abf670
• Upwork Job ID: 1740337825990307840
• Last Price Increase: 2024-01-04
• Automatic offers:
• 0xmiroslav | Reviewer | 28091022
• dukenv0307 | Contributor | 28091023

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01c454898c96abf670

[melvin-bot]

Triggered auto assignment to @garrettmknight (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @0xmiroslav (External)

[dukenv0307]

Proposal

Please re-state the problem that we are trying to solve in this issue.

As invited user, in LHN, sender user id is not displayed under room chat report.

What is the root cause of that problem?

When generating the last message alternateText here, we're not appending the actor user displayName/login into the invited x users message.

What changes do you think we should make in order to solve the problem?

1. From actorAccountId of the last action and personal details, we can get the actor user displayName/login. The right way to format it, we can do the same as for other "last message". The getDisplayNameForParticipant will probably be enough for this case (can use the lastActorDisplayName here).
2. Use that to append into the invited x users message here. We only do this if the actor is not current logged in user. Also need to check everywhere the invited x users last message is shown and do it for those places.

What alternative solutions did you explore? (Optional)

NA

[garrettmknight]

@0xmiroslav can you review this proposal?

[melvin-bot]

@garrettmknight, @0xmiroslav Eep! 4 days overdue now. Issues have feelings too...

[melvin-bot]

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

[garrettmknight]

@0xmiroslav can you give this one a review?

[melvin-bot]

@garrettmknight, @0xmiroslav Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[0xmiros]

@dukenv0307's proposal looks good to me.
🎀 👀 🎀 C+ reviewed

[melvin-bot]

Triggered auto assignment to @stitesExpensify, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[melvin-bot]

📣 @0xmiroslav 🎉 An offer has been automatically sent to your Upwork account for the Reviewer role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job

[melvin-bot]

📣 @dukenv0307 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @eVoloshchak (External)

[mallenexpensify]

@eVoloshchak, reassigning, please take over as C+. If you don't have bandwidth, unassign yourself. Thanks

[garrettmknight]

Working in the PR, all good.

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.34-1 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• fix: add actor display name in lhn #34212

If no regressions arise, payment will be issued on 2024-02-07. 🎊

For reference, here are some details about the assignees on this issue:

• @eVoloshchak requires payment through NewDot Manual Requests
• @dukenv0307 requires payment automatic offer (Contributor)

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@eVoloshchak] The PR that introduced the bug has been identified. Link to the PR:
• [@eVoloshchak] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@eVoloshchak] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@eVoloshchak] Determine if we should create a regression test for this bug.
• [@eVoloshchak] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@garrettmknight] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[eVoloshchak]

• The PR that introduced the bug has been identified. Link to the PR: there isn't a PR that caused this, this is the behaviour that was implemented initially
• The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: N/A
• A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: I don't think an additional discussion is needed, this isn't a bug per se, just a different expected behavior we've adapted to
• Determine if we should create a regression test for this bug.
  Is it easy to test for this bug? Yes
  Is the bug related to an important user flow? Yes
  Is it an impactful bug? No
  This isn't an impactful bug, but this is pretty important, chat is the main section of the app. I think it's worth having a regression test for this

Regression Test Proposal

1. Tap on a room chat
2. Tap the room header
3. Tap Invite
4. Invite a user (userA) to the room
5. Log in as invited user (userA)
6. Verify that: As invited user, in LHN, sender user name is displayed under room chat report (i.e. "{usernameB} invited 1 user")

Do we agree 👍 or 👎

[garrettmknight]

Summary of payments:

• Contributor: @dukenv0307 $500 paid via Upwork
• Reviewer: @eVoloshchak $500

[garrettmknight]

@eVoloshchak request payment when you're ready.

[eVoloshchak]

Requested the payment, thanks everyone!

[JmillsExpensify]

$500 approved for @eVoloshchak based on summary above.

[eVoloshchak]

@garrettmknight, seems like this one can be closed