Make referral banner dismissible #33925

gijoe0295 · 2024-01-04T07:49:10Z

Details

This PR makes referral banner dismissible temporarily.

Fixed Issues

$ #32499
PROPOSAL: #32499 (comment)

Tests

Press FAB >> Start chat
Press close referral banner
Verify the banner is closed
Verify the text input remains focused
Close the RHP
Repeat step 1
Verify the banner appears again
Repeat those steps with Request money and Search page

Verify that no errors appear in the JS console

Offline tests

NA

QA Steps

Press FAB >> Start chat
Press close referral banner
Verify the banner is closed
Verify the text input remains focused
Close the RHP
Repeat step 1
Verify the banner appears again
Repeat those steps with Request money and Search page

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Screen.Recording.2024-01-04.at.14.52.46-compressed.mov

Android: mWeb Chrome

Screen.Recording.2024-01-04.at.14.51.22-compressed.mov

iOS: Native

ios-compressed.mov

iOS: mWeb Safari

safari-compressed.mov

MacOS: Chrome / Safari

Screen.Recording.2024-01-04.at.14.29.34-compressed.mov

MacOS: Desktop

desktop-compressed.mov

melvin-bot · 2024-01-04T07:54:52Z

@dannymcclain @abdulrahuman5196 One of you needs to copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

dannymcclain

Looks to be working as expected to me. From a design perspective I think we're all good, but please make sure to still get a review from someone with a more technical background. 👍

gijoe0295 · 2024-01-09T05:26:48Z

@abdulrahuman5196 Please review.

abdulrahuman5196 · 2024-01-09T12:25:42Z

Hi, Will review today.

abdulrahuman5196 · 2024-01-11T09:28:58Z

Reviewing now

abdulrahuman5196 · 2024-01-11T10:04:17Z

src/components/OptionsSelector/BaseOptionsSelector.js

-                                width={20}
-                                fill={this.props.theme.icon}
-                            />
+                            <PressableWithoutFeedback


It seems the pressable and the icon have same size.

Screen.Recording.2024-01-11.at.3.31.42.PM.mov

Shouldn't we have some extra size for pressing? For now both the icon size and the pressing place size is 20

@dannymcclain yours thoughts on this?

@dannymcclain what do you think?

Good call—ideally the pressable area of the x icon should be at least a 44px square.

@dannymcclain Can you confirm whether it is 40 or 44? 40 is the pressable area of the back (and other) button.

But if we do so, the button will move to the left like this:

Before

After

As the previous Info icon did not have pressable space as 40 either, I suggest we keep it the same, i.e. keep the pressable and the icon having the same size as 20.

Gotcha—40 would be acceptable if that's what we do elsewhere.

I see what you're talking about in your before and after. The right thing to do here IMO would be to adjust the padding on the actual banner so that the x icon gets the proper amount of clickable space without impacting the size of the banner/layout of the icon. @Expensify/design do y'all think it's worth it to adjust the banner to give that icon a proper amount of clickable area?

I agree with that Danny. But I could have sworn we can also solve for this using React Native's hitslop, right? This we we can keep the button where it is but just define a greater hit area around around the button.

@abdulrahuman5196 @dannymcclain I've updated, please check. I tried to keep everything visually the same though it requires some hard-coding for the padding.

Or we can do nothing and the hitSlop will be automatically calculated.

Before

After

tgolen · 2024-01-19T20:23:48Z

What's the next step on this PR? I am beginning to work on #34387 which is blocked on the functionality in this PR. I'll start working off the branch, but I also want to encourage everyone to work with urgency to get this completed. It should be reviewed or updated every day and it's been 4 days with no activity.

abdulrahuman5196 · 2024-01-19T21:49:39Z

Hi, it's miss from my end. Will test and update first thing in my morning and close this out ASAP.

abdulrahuman5196 · 2024-01-22T11:13:48Z

Reviewing now

tgolen · 2024-01-22T21:47:59Z

src/pages/SearchPage/SearchPageFooter.tsx

-            <ReferralProgramCTA referralContentType={CONST.REFERRAL_PROGRAM.CONTENT_TYPES.REFER_FRIEND} />
-        </View>
+        <>
+            {shouldShowReferralCTA && (


I don't think this works, does it? I think there is some confusion with the SearchPage component: https://expensify.slack.com/archives/C01GTK53T8Q/p1705959664098999?thread_ts=1701232130.505309&cid=C01GTK53T8Q

Despite the problem with removing old file, it works fine for me.

@abdulrahuman5196 TL;DR: SearchPage.js was moved to SearchPage/index.js but the original file (SearchPage.js) was not removed. But the changes in this PR were made in the latest file (SearchPage/index.js) so we don't need to worry about it.

OK, looks like the old file SearchPage.js will be getting removed. Thanks!

tgolen · 2024-01-23T15:52:19Z

Bump @abdulrahuman5196 for review, please. Let's get this one finished up.

abdulrahuman5196 · 2024-01-23T18:42:45Z

Working on another critical PR yesterday and today. Will close out that and start in 30 minutes. Sorry for the delay

abdulrahuman5196 · 2024-01-23T19:25:33Z

NAB: @gijoe0295 Kindly update the Tests in author's checklist to reflect all the pages which has this change.

abdulrahuman5196 · 2024-01-23T19:38:13Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Screen.Recording.2024-01-24.at.12.47.33.AM.mov

Android: mWeb Chrome

Screen.Recording.2024-01-24.at.12.53.26.AM.mov

iOS: Native

Screen.Recording.2024-01-24.at.12.44.58.AM.mov

iOS: mWeb Safari

Screen.Recording.2024-01-24.at.12.46.05.AM.mov

MacOS: Chrome / Safari

Screen.Recording.2024-01-24.at.12.42.35.AM.mov

MacOS: Desktop

Screen.Recording.2024-01-24.at.12.43.48.AM.mov

abdulrahuman5196

Changes looks good and works well. Reviewers checklist is also complete.

All yours. @tgolen / @joelbettner

🎀 👀 🎀
C+ Reviewed

abdulrahuman5196 · 2024-01-23T19:40:18Z

@gijoe0295 Kindly also update the testing screenshots after high number of changes, since we added changes in couple more pages after last update.

gijoe0295 · 2024-01-24T06:33:00Z

Updated.

tgolen · 2024-01-24T15:58:49Z

All yours @joelbettner

OSBotify · 2024-01-24T22:54:27Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2024-01-25T09:06:37Z

🚀 Deployed to staging by https://github.com/joelbettner in version: 1.4.32-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2024-01-29T19:06:22Z

🚀 Deployed to production by https://github.com/francoisl in version: 1.4.32-5 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

make referral banner dismissable

c2866e5

gijoe0295 marked this pull request as ready for review January 4, 2024 07:54

gijoe0295 requested a review from a team as a code owner January 4, 2024 07:54

melvin-bot bot requested review from abdulrahuman5196 and dannymcclain and removed request for a team January 4, 2024 07:54

dannymcclain previously approved these changes Jan 4, 2024

View reviewed changes

abdulrahuman5196 reviewed Jan 11, 2024

View reviewed changes

jamesdeanexpensify mentioned this pull request Jan 11, 2024

[PAID] Make NewDot referral banners permanently dismissible #34387

Closed

gijoe0295 added 2 commits January 13, 2024 02:50

Merge branch 'main' of https://github.com/gijoe0295/App into gijoe-32499

7f13d57

dismiss money request banner

15d87b1

gijoe0295 dismissed dannymcclain’s stale review via 15d87b1 January 12, 2024 20:29

gijoe0295 added 4 commits January 16, 2024 09:37

Merge branch 'main'

21807d8

reapply changes

f64a93a

increase pressable space

d9f6a59

fix lint

bdc980d

tgolen mentioned this pull request Jan 19, 2024

Allow users to permanently dismiss the referral banners #34842

Merged

50 tasks

tgolen reviewed Jan 22, 2024

View reviewed changes

abdulrahuman5196 approved these changes Jan 23, 2024

View reviewed changes

melvin-bot bot requested a review from joelbettner January 23, 2024 19:39

tgolen approved these changes Jan 24, 2024

View reviewed changes

joelbettner approved these changes Jan 24, 2024

View reviewed changes

joelbettner merged commit bcd5939 into Expensify:main Jan 24, 2024
18 of 21 checks passed

github-actions bot mentioned this pull request Jan 25, 2024

Deploy Checklist: New Expensify 2024-01-25 #35138

Closed

48 tasks

lanitochka17 mentioned this pull request Jan 25, 2024

[HOLD for payment March 4th][HOLD for payment 2024-02-15] [$500] Search - "Invite a friend" banner do not move up when input field is focused in search page #35182

Closed

6 tasks

melvin-bot bot mentioned this pull request Jan 29, 2024

[HOLD for payment 2024-02-05] [$500] Chat - "Start a chat, get 250$" popup blocks recent contacts #32499

Closed

6 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Make referral banner dismissible #33925

Make referral banner dismissible #33925

gijoe0295 commented Jan 4, 2024 •

edited

Loading

melvin-bot bot commented Jan 4, 2024

dannymcclain left a comment

gijoe0295 commented Jan 9, 2024

abdulrahuman5196 commented Jan 9, 2024

abdulrahuman5196 commented Jan 11, 2024

abdulrahuman5196 Jan 11, 2024

gijoe0295 Jan 12, 2024

dannymcclain Jan 12, 2024

gijoe0295 Jan 12, 2024 •

edited

Loading

gijoe0295 Jan 12, 2024

dannymcclain Jan 12, 2024

shawnborton Jan 15, 2024

gijoe0295 Jan 16, 2024 •

edited

Loading

tgolen commented Jan 19, 2024

abdulrahuman5196 commented Jan 19, 2024

abdulrahuman5196 commented Jan 22, 2024

tgolen Jan 22, 2024

gijoe0295 Jan 23, 2024 •

edited

Loading

tgolen Jan 23, 2024

tgolen commented Jan 23, 2024

abdulrahuman5196 commented Jan 23, 2024

abdulrahuman5196 commented Jan 23, 2024

abdulrahuman5196 commented Jan 23, 2024 •

edited

Loading

abdulrahuman5196 left a comment

abdulrahuman5196 commented Jan 23, 2024

gijoe0295 commented Jan 24, 2024

tgolen commented Jan 24, 2024

OSBotify commented Jan 24, 2024

OSBotify commented Jan 25, 2024

OSBotify commented Jan 29, 2024

Make referral banner dismissible #33925

Make referral banner dismissible #33925

Conversation

gijoe0295 commented Jan 4, 2024 • edited Loading

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

melvin-bot bot commented Jan 4, 2024

dannymcclain left a comment

Choose a reason for hiding this comment

gijoe0295 commented Jan 9, 2024

abdulrahuman5196 commented Jan 9, 2024

abdulrahuman5196 commented Jan 11, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

gijoe0295 Jan 12, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

gijoe0295 Jan 16, 2024 • edited Loading

Choose a reason for hiding this comment

tgolen commented Jan 19, 2024

abdulrahuman5196 commented Jan 19, 2024

abdulrahuman5196 commented Jan 22, 2024

Choose a reason for hiding this comment

gijoe0295 Jan 23, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

tgolen commented Jan 23, 2024

abdulrahuman5196 commented Jan 23, 2024

abdulrahuman5196 commented Jan 23, 2024

abdulrahuman5196 commented Jan 23, 2024 • edited Loading

Reviewer Checklist

Screenshots/Videos

abdulrahuman5196 left a comment

Choose a reason for hiding this comment

abdulrahuman5196 commented Jan 23, 2024

gijoe0295 commented Jan 24, 2024

tgolen commented Jan 24, 2024

OSBotify commented Jan 24, 2024

OSBotify commented Jan 25, 2024

OSBotify commented Jan 29, 2024

gijoe0295 commented Jan 4, 2024 •

edited

Loading

gijoe0295 Jan 12, 2024 •

edited

Loading

gijoe0295 Jan 16, 2024 •

edited

Loading

gijoe0295 Jan 23, 2024 •

edited

Loading

abdulrahuman5196 commented Jan 23, 2024 •

edited

Loading