[HOLD for payment 2024-01-25] [$500] Storybook - "Page not found.." appears when navigate to Storybook link from chat

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: 1.4.21-2
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:

Issue found when executing PR #33077

Action Performed:

1. Navigate to staging.new.expensify.com
2. Paste this storybook url to any chat https://staging.new.expensify.com/docs/index.html?path=/story/components-optionrow--default
3. Click on the link

Expected Result:

User should navigates to Storybook page

Actual Result:

"Page not found.." appears when navigate to Storybook link from chat

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6331923_1704353714641.az_recorder_20240103_142211.1.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01fbe4578a663e3299
• Upwork Job ID: 1742845470117625856
• Last Price Increase: 2024-01-04
• Automatic offers:
• aimane-chnaif | Reviewer | 28095041
• tienifr | Contributor | 28095042

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01fbe4578a663e3299

[melvin-bot]

Triggered auto assignment to @miljakljajic (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @aimane-chnaif (External)

[tienifr]

Proposal

Please re-state the problem that we are trying to solve in this issue.

"Page not found.." appears when navigate to Storybook link from chat

What is the root cause of that problem?

The storybook link is being treated as internal Expensify/New Expensify path, so it tries to open using navigation which won't work.

What changes do you think we should make in order to solve the problem?

Treat storybook link as external path, we can check the path prefix of the storybook to determine this.

We can update here so that it additionally checks the path prefix of the storybook, if it matches then it will not be considered as internal new Expensify path.

We can enhance the CONST.PATHS_TO_TREAT_AS_EXTERNAL so that it uses RegEx to check rather than exact match, then we can put RegEx of the storybook links there

More info on the path of story book here.

What alternative solutions did you explore? (Optional)

An alternate implementation is we can use exact match for the storybook pathname docs/index.html but we need to compare the pathname instead of this attrPath which currently includes the search/hash as well

We should also double check other places that can let users open arbitrary link from the app as well to see if the same issue is present. The solution should be similar.

[miljakljajic]

@aimane-chnaif are you able to reproduce this? The link works fine for me?

[aimane-chnaif]

yes, reproduced. To reproduce, it should be deep link opened from chat, not directly visit.

[miljakljajic]

Got it, thank you. Please review @tienifr 's proposal when you're ready!

[aimane-chnaif]

Agree with @tienifr's proposal to treat storybook link as external path.
🎀 👀 🎀 C+ reviewed

[melvin-bot]

Triggered auto assignment to @nkuoch, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[melvin-bot]

📣 @aimane-chnaif 🎉 An offer has been automatically sent to your Upwork account for the Reviewer role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job

[melvin-bot]

📣 @tienifr 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.26-2 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Treat storybook link as external path #34410

If no regressions arise, payment will be issued on 2024-01-25. 🎊

For reference, here are some details about the assignees on this issue:

• @aimane-chnaif requires payment automatic offer (Reviewer)
• @tienifr requires payment automatic offer (Contributor)

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@aimane-chnaif] The PR that introduced the bug has been identified. Link to the PR:
• [@aimane-chnaif] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@aimane-chnaif] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@aimane-chnaif] Determine if we should create a regression test for this bug.
• [@aimane-chnaif] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@miljakljajic] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[miljakljajic]

@aimane-chnaif please accept the offer in upwork when you have a chance!

[miljakljajic]

paid and paid, closing.