[$500] Expense - Preview shows 0 requests briefly when visiting workspace chat for the first time

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: v1.4.21-4
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:

Action Performed:

Precondition: There are a few manual requests and ongoing scanning requests in the workspace chat.

1. Send a message in another chat (for web and desktop app)
2. Log out.
3. Log in.
4. Go to the workspace chat.

Expected Result:

The expense preview will show the number of requests.

Actual Result:

The expense preview shows 0 requests briefly, while there is no issue with the number of scanning requests.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6332084_1704370716093.20240104_085815.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01eca5a466b3de3517
• Upwork Job ID: 1742890349435052032
• Last Price Increase: 2024-01-27

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01eca5a466b3de3517

[melvin-bot]

Triggered auto assignment to @sakluger (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @abdulrahuman5196 (External)

[paultsimura]

Proposal

Please re-state the problem that we are trying to solve in this issue.

On the first render of the ReportPreview action, the total requests count is set to 0.

What is the root cause of that problem?

We are calculating the total number of requests using reportPreviewAction.childMoneyRequestCount, which is not loaded on the first render of the report preview, and defaults to 0:

App/src/libs/ReportActionsUtils.ts

Lines 626 to 631 in 8aec07c

	/**
	* Returns the number of money requests associated with a report preview
	*/
	function getNumberOfMoneyRequests(reportPreviewAction: OnyxEntry<ReportAction>): number {
	return reportPreviewAction?.childMoneyRequestCount ?? 0;
	}

This value is updated in Onyx only after the successful OpenReport API response:

And the numberOfScanningReceipts uses count of transactions instead of the reportAction data:

App/src/components/ReportActionItem/ReportPreview.js

Lines 153 to 154 in 8ff9006

	const transactionsWithReceipts = ReportUtils.getTransactionsWithReceipts(props.iouReportID);
	const numberOfScanningReceipts = _.filter(transactionsWithReceipts, (transaction) => TransactionUtils.isReceiptBeingScanned(transaction)).length;

What changes do you think we should make in order to solve the problem?

We can use TransactionUtils.getAllReportTransactions calculation as a fallback if the value from ReportActionsUtils.getNumberOfMoneyRequests is 0, since the TransactionUtils.getAllReportTransactions is using the same approach as numberOfScanningReceipts – counting transactions:

const numberOfRequests = ReportActionUtils.getNumberOfMoneyRequests(props.action) || _.size(TransactionUtils.getAllReportTransactions(props.iouReportID));

App/src/components/ReportActionItem/ReportPreview.js

Line 146 in 8ff9006

const numberOfRequests = ReportActionUtils.getNumberOfMoneyRequests(props.action);

What alternative solutions did you explore? (Optional)

[rojiphil]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Expense - Preview shows 0 requests briefly when visiting workspace chat for the first time. We are trying to avoid showing this briefly.

What is the root cause of that problem?

Briefly showing of 0 preview count is due to the fact that openReport takes time to update the childMoneyRequestCount of Report Preview Action.

As per the discussion here cc @mountiny , to tackle performance problems, BE would want to send just enough data and FE would be used to display just that with little modifications.

And I am not sure if relying on transactions count would be a good idea here as that would bring about external dependency even when the required childMoneyRequestCount is available within the Report Preview action. If for performance reason, BE does not send the transactions at some later point, we will again have the issue.

To me, it looks like showing the preview subtitle even when childMoneyRequestCount is 0 is the cause of the problem as shown here

What changes do you think we should make in order to solve the problem?

We can prevent showing the preview subtitle if childMoneyRequestCount is 0 by replacing the condition here like this:

         {!isScanning && numberOfRequests > 0 && (numberOfRequests > 1 || hasReceipts) && (

What alternative solutions did you explore? (Optional)

[abdulrahuman5196]

Will be working on review today.

[abdulrahuman5196]

The root cause mentioned by the contributors is correct, we don't have the childMoneyRequestCount and many other child information data. It is only got when OpenReport is successful.
@sakluger Could you kindly check internally if this is intentional? If not most likely the fix is goes to be internal.

[melvin-bot]

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

[melvin-bot]

@sakluger, @abdulrahuman5196 Eep! 4 days overdue now. Issues have feelings too...

[sakluger]

Checking internally on this now: https://expensify.slack.com/archives/C05DWUDHVK7/p1705435853915939

[sakluger]

We do want to fix this! I've added to Wave 5 - Release 5, and I am changing the priority to weekly since it's polish, which is lower priority.

[abdulrahuman5196]

@sakluger Could you kindly provide update if you have any?
#33949 (comment)

I don't have access to the mentioned slack chat?

[sakluger]

We may need to hold one more day to find out if this is BE or can be done in the FE, sorry for the wait.

[sakluger]

I threw the hot pick label so we can find an internal engineer to help.

[melvin-bot]

Current assignee @abdulrahuman5196 is eligible for the External assigner, not assigning anyone new.

[sakluger]

I heard back from our engineers - We'd like this solved in the front end. Thanks for checking!

[melvin-bot]

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

[abdulrahuman5196]

Thank you for the confirmation. Will check on frontend fixes.

[abdulrahuman5196]

Will be working on proposal review today.

[abdulrahuman5196]

@sakluger I don't see this issue anymore. Could you kindly check on this?

Screen.Recording.2024-01-31.at.8.24.47.PM.mov

[melvin-bot]

@sakluger @neil-marcellini @abdulrahuman5196 this issue is now 4 weeks old and preventing us from maintaining WAQ, can you:

• Decide whether any proposals currently meet our guidelines and can be approved as-is today
• If no proposals meet that standard, please take this issue internal and treat it as one of your highest priorities
• If you have any questions, don't hesitate to start a discussion in #expensify-open-source

Thanks!

[melvin-bot]

Current assignee @abdulrahuman5196 is eligible for the Internal assigner, not assigning anyone new.

[abdulrahuman5196]

@sakluger To check on this #33949 (comment)

[neil-marcellini]

I'm also not able to reproduce the bug, so I'm going to close this.

0totalBug.mov