Incorrect grammar in reports submitted to yourself

[m-natarajan]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: 1.4.22-0
Reproducible in staging?: yes
Reproducible in production?: yes
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @roryabraham
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1704393820452899

Action Performed:

1. In OldDot, create Collect plan, set as default
2. Set isPolicyExpenseChatEnabled = "true" on the policy by:
3. Opening the policy settings in OldDot
4. Open the JS console and run the following commands
5. p = Policy.getCurrent();
6. p.policy.isPolicyExpenseChatEnabled = "true";
7. p.save();
8. In OldDot, create report on ^ policy & add an expense
9. In OldDot, submit the report (to yourself) & approve it
10. Open the report in either OldDot or NewDot

Expected Result:

There should be a reportAction on the report saying "You submitted this report to yourself".

Actual Result:

There is a reportAction on the report saying "You submitted this report to you"

Workaround:

unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~018c688c4186cba91e
• Upwork Job ID: 1743087792909430784
• Last Price Increase: 2024-01-05

[melvin-bot]

Triggered auto assignment to @jliexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~018c688c4186cba91e

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @aimane-chnaif (External)

[jliexpensify]

This is a super minor issue and probably not worth fixing externally. Closing.

[roryabraham]

lol, harsh @jliexpensify 😂

[roryabraham]

It is a bit of a nitpick, but it just drives me crazy every time I see it 😂

[roryabraham]

I'm going to go ahead and fix this since it's a really easy back-end fix: https://github.com/Expensify/Web-Expensify/pull/40403

[melvin-bot]

Current assignee @aimane-chnaif is eligible for the Internal assigner, not assigning anyone new.

[jliexpensify]

LOL sorry @roryabraham I should have asked you about this one - I was going off this post

[roryabraham]

Yeah, that's totally fair. This probably wasn't the absolute best use of my time, but it didn't take long and is fixed now. Live and learn, probably next time I would just leave it closed.

[jliexpensify]

Haha all good, it's probably good it's fixed...it actually does bug me too!

[roryabraham]

It's technically not fixed yet, but will be once https://github.com/Expensify/Web-Expensify/pull/40403 is reviewed and merged

[melvin-bot]

This issue has not been updated in over 15 days. @roryabraham eroding to Monthly issue.

P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!

[roryabraham]

This is done