-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Hold for #34409] [$500] Android - Public room - Extra spacing above the room header #34050
Comments
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
|
Triggered auto assignment to @blimpich ( |
I don't consider this a blocker, considering it only occurs on Android, is a fairly minor UI mishap, and only happens under very specific circumstances. |
Triggered auto assignment to @greg-schroeder ( |
Bug0 Triage Checklist (Main S/O)
|
Hmmm, interesting. Maybe we should close this issue then if its not reproducible on main. |
Fine with that especially given it's super niche |
Issue is reproducible on build 1.4.24.0 @situchan Did you check in physical device or emulator? video_2024-01-10_12-55-28.mp4 |
Not overdue. Waiting to hear back from @situchan before assigning this out to external contributors. |
Held |
Still held |
Same |
Another case (diff reproduction steps) has been reported here #36010. Please make sure that one is covered. |
held |
Holding PR was C+ approved today, not merged yet |
PR was merged and deployed to prod |
Let's retest to see if it works - I can't test this personally cause I don't have an android device, asking QA |
Will bump QA |
Issue not reproducible during KI retests. (First week) |
Looks like deep link is broken. |
Issue not reproducible during KI retests. (Second week) |
I think I'm going to close this as QA can't repro |
Reopen if you disagree |
If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!
Version Number: 1.4.22-0
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:
Issue found when executing PR #33829
Action Performed:
Expected Result:
The room header has adequate spacing
Actual Result:
There is extra spacing above the room header
Workaround:
Unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
Screenshots/Videos
Add any screenshot/video evidence
View all open jobs on GitHub
Upwork Automation - Do Not Edit
The text was updated successfully, but these errors were encountered: