[HOLD for payment 2024-02-15] [$500] Task - Task assigned to "Hidden" does not show "Hidden" as assignee in main chat

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: 1.4.22-0
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:

Issue found when executing PR #29730

Action Performed:

1. Go to FAB > Assign task
2. Enter title > Next
3. Click Assignee
4. Enter a valid email with no display name that is registered on ND but has no chat history with the user
   (use [email protected]
   )
5. Create the task

Expected Result:

The task preview in the main chat will show "Hidden" as the assignee

Actual Result:

The task preview in the main chat does not show "Hidden" as the assignee

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6333411_1704479061341.20240105_195946__1_.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01e3fabdb897c1d05d
• Upwork Job ID: 1744829796306513920
• Last Price Increase: 2024-01-16
• Automatic offers:
• hoangzinh | Contributor | 28116810
• dukenv0307 | Contributor | 28117853

Issue Owner

Current Issue Owner: @stephanieelliott

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot]

Triggered auto assignment to @grgia (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[unidev727]

Proposal

from: @unicorndev-727

Please re-state the problem that we are trying to solve in this issue.

Task - Task assigned to "Hidden" does not show "Hidden" as assignee in main chat

What is the root cause of that problem?

This is not deploy blocker, I think (I can't find relevant PR for this issue in Deploy checklist).
The root cause is that we didn't use getDisplayNameForParticipant here.

App/src/components/ReportActionItem/TaskPreview.js

Line 99 in 7ae1ec7

const taskAssignee = assigneeDisplayName || LocalePhoneNumber.formatPhoneNumber(assigneeLogin);

What changes do you think we should make in order to solve the problem?

We should use getDisplayNameForParticipant.

const taskAssignee = ReportUtils.getDisplayNameForParticipant(taskAssigneeAccountID);

What alternative solutions did you explore?

N/A

[mvtglobally]

Still repro on build 1.4.22-2

Recording.898.mp4

[thienlnam]

Don't think this needs to be a blocker, but we should fix this

[dukenv0307]

Proposal

Please re-state the problem that we are trying to solve in this issue.

The task preview in the main chat does not show "Hidden" as the assignee

What is the root cause of that problem?

When we create a task with a new user, taskAssignee is empty because this user doesn't set a display name and BE doesn't return the login field of the new user.

App/src/components/ReportActionItem/TaskPreview.js

Line 99 in 26b4006

const taskAssignee = assigneeDisplayName || LocalePhoneNumber.formatPhoneNumber(assigneeLogin);

And then we don't show the mention here.

App/src/components/ReportActionItem/TaskPreview.js

Line 101 in 26b4006

taskAssignee && taskAssigneeAccountID !== 0

What changes do you think we should make in order to solve the problem?

Because MentionUserRenderer already covers the Hidden case here

App/src/components/HTMLEngineProvider/HTMLRenderers/MentionUserRenderer.js

Line 44 in 26b4006

displayNameOrLogin = LocalePhoneNumber.formatPhoneNumber(lodashGet(user, 'login', '')) || lodashGet(user, 'displayName', '') || translate('common.hidden');

I think we can remove taskAssignee in TaskPreview.

App/src/components/ReportActionItem/TaskPreview.js

Line 99 in 26b4006

const taskAssignee = assigneeDisplayName || LocalePhoneNumber.formatPhoneNumber(assigneeLogin);

App/src/components/ReportActionItem/TaskPreview.js

Line 101 in 26b4006

taskAssignee && taskAssigneeAccountID !== 0

And add the check taskAssigneeAccountID !== 0 to check the task has assignee or not

OPTIONAL: In MenuItem we prioritize showing the display name but in MentionUserRenderer we prioritize showing the login filed. So in MentionUserRenderer we can prioritize showing the display name to be consistent with MenuItem

App/src/components/HTMLEngineProvider/HTMLRenderers/MentionUserRenderer.js

Line 44 in 26b4006

displayNameOrLogin = LocalePhoneNumber.formatPhoneNumber(lodashGet(user, 'login', '')) || lodashGet(user, 'displayName', '') || translate('common.hidden');

What alternative solutions did you explore? (Optional)

NA

[melvin-bot]

Triggered auto assignment to @stephanieelliott (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01e3fabdb897c1d05d

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @parasharrajat (External)

[stephanieelliott]

Hey @parasharrajat a few proposals here for you to review!

[hoangzinh]

oh you're right. @dukenv0307's proposal looks good to me. It has the correct root cause and its solution looks good, it helps clean up redundant code.

Link to proposal #34052 (comment)

🎀👀🎀 C+ reviewed

[melvin-bot]

Triggered auto assignment to @tgolen, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[tgolen]

I like the proposal from @dukenv0307 also, including the optional cleanup to make the display logic consistent.

[melvin-bot]

📣 @dukenv0307 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[stephanieelliott]

PR is still under review, looks like @hoangzinh is working through the checklist

[stephanieelliott]

PR is still under active, seems like we are wrapping up though!

[stephanieelliott]

PR is on staging!

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.38-6 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Refactor task preview for hidden case #35027

If no regressions arise, payment will be issued on 2024-02-15. 🎊

For reference, here are some details about the assignees on this issue:

• @hoangzinh requires payment automatic offer (Contributor)
• @dukenv0307 requires payment automatic offer (Contributor)

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@hoangzinh] The PR that introduced the bug has been identified. Link to the PR:
• [@hoangzinh] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@hoangzinh] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@hoangzinh] Determine if we should create a regression test for this bug.
• [@hoangzinh] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@stephanieelliott] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[melvin-bot]

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

[stephanieelliott]

^^ was tested and found to be NAB!

[stephanieelliott]

Summarizing payment on this issue:

• Contributor: @dukenv0307 $500, paid via Upwork
• Contributor+: @hoangzinh $500, paid via Upwork

Upwork job is here: https://www.upwork.com/jobs/~1737876297360310272"