[Collect approvers] [$500] Expense - Report submission and approval messages only come through after refreshing the page

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: 1.4.22-0
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:

Action Performed:

Precondition:

• User is an admin of a Collect workspace on Old Dot

1. [Old Dot] Create a report with expense
2. [New Dot] Log in with the same account
3. [New Dot] Open the expense report from workspace chat
4. [Old Dot] Submit the report
5. [Old Dot] Approve the report
6. [Old Dot] Mark the report as reimbursement
7. [New Dot] Go to main chat and then click on the preview to return to report

Expected Result:

On New Dot, the system message for report submission and approval will appear in the expense report without refreshing the page

Actual Result:

On New Dot, the system message for report submission and approval only appear in the expense report after refreshing the page. While the reimbursement message appears without issue and without having to refresh the page

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6333487_1704486086954.33730_desktop.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~0137e8422a18862fdd
• Upwork Job ID: 1743372915513012224
• Last Price Increase: 2024-01-05
• Automatic offers:
• getusha | Reviewer | 28095067

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~0137e8422a18862fdd

[melvin-bot]

Triggered auto assignment to @NicMendonca (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @getusha (External)

[getusha]

Still waiting for proposals

[waterim]

Hello, Im Artem from Callstack and would like to help with this issue

[waterim]

After my investigation I found an issue that pusher is not sending a "reportComment" event, it updates the state, but not sending a message.

At the same time for REIMBURSED pushed is updating state and also sends a reportComment event.

Looks like a backend issue.

[melvin-bot]

Current assignee @getusha is eligible for the Internal assigner, not assigning anyone new.

[melvin-bot]

Triggered auto assignment to @bondydaa (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[melvin-bot]

📣 @getusha 🎉 An offer has been automatically sent to your Upwork account for the Reviewer role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job

[melvin-bot]

@bondydaa, @NicMendonca, @waterim, @getusha Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[melvin-bot]

This issue has not been updated in over 15 days. @marcochavezf, @greg-schroeder, @getusha eroding to Monthly issue.

P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!

[melvin-bot]

This issue has not been updated in over 15 days. @marcochavezf, @greg-schroeder, @getusha eroding to Monthly issue.

P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!

[greg-schroeder]

@marcochavezf can you help me understand where this issue is at? Should this be closed as the PR was deployed a while ago...

[marcochavezf]

Hmm seems there's still an issue here. I will move it to weekly (since it's a polish issue) to check it out accordingly

[greg-schroeder]

Okay, thanks!

[marcochavezf]

Just finishing a doc and I will come back to this one. Meanwhile I will change it to daily

[trjExpensify]

Is this still a bug? It hasn't been retested since Feb, and I can't recall the refresh on some recent testing. Let's clarify if it's still a bug, and what conditions exactly we need to replicate.

[melvin-bot]

@marcochavezf, @greg-schroeder, @getusha Eep! 4 days overdue now. Issues have feelings too...

[greg-schroeder]

Asking for retest

[marcochavezf]

I was able to reproduce the approval message from OldDot, working on a fix

[marcochavezf]

PR up

[greg-schroeder]

PR was just deployed

[greg-schroeder]

Automation didn't work - seems this can be closed as no external folks worked on this.