Deploy Checklist: New Expensify 2024-01-09

[github-actions]

Release Version: 1.4.23-4
Compare Changes: production...staging

This release contains changes from the following pull requests:

• [TS migration] Migrate 'User.js' lib to TypeScript #28695
• Update subscribe on leave #30812
• Using visibleChatMemberList instead of participants ids #30863
• Flip TU constants for QA #31094
• [TS migration] Migrate 'updatePropsPaperWorklet' lib to TypeScript #31546
• Adds Client-side Violations when creating money requests #32528
• delete money request with no trace if only changelogs exist #32543
• Theme switching ESLint rules #32569
• [W7: H Requests] Educational Interstitial #32667
• Add UpdateMoneyRequestTag command #32769
• Fix the green line ignoring 'mark as read' #32894
• [TS migration] Migrate 'Reactions' component to TypeScript #32929
• fix duplicate endpoints #32999
• Hide thread option in context menu when deleting action in offline mode #33052
• [TS migration] Migrate 'ConfirmPopover.js' component to TypeScript #33112
• fix: hide new marker for pending deleted action in online mode #33162
• #30468 parse supported timezone #33186
• Fix a fail to add and edit/delete message doesn't get cleared when closing the error message #33198
• Rename style container for the TextInput #33221
• Create UpdateMoneyRequestMerchant #33227
• Fixed mapbox zoom for single waypoint #33234
• [TS Migration] migrate FloatingActionButton to TypeScript #33247
• Chat onStartReached loader fix #33343
• [TS migration] Migrate 'QRShare' component to TypeScript #33345
• Fix/33006 #33355
• [Form Provider Refactor] BaseGetPhysicalCard #33360
• Update Reimbursing-Reports.md #33374
• Dont show hidden notif pref in profile page #33387
• Remove redundant and trailing slashes in route path #33444
• Parse welcomeNote before sending to Web #33468
• Chat - Send money text displayed in workspace chat #33520
• [HelpDot] use collapsible FAQ in all pages #33532
• https://github.com/Expensify/App/pull/33563
• Fixed icon fill colors #33607
• Add checks for editing APPROVED reports #33633
• fix: prevent double click outside RHP #33640
• [TS migration] Migrate 'Section.js' component to TypeScript #33645
• fix: Use lastMessageText for the task alternate text during search #33656
• Remove deprecated methods and refactor code to be a little cleaner #33676
• fix: Red dot does not appear in LHN conversation when IOU deletion error occurs #33697
• Fix focus on footer link selection #33743
• Fix default avatar render with low quality #33745
• [TS migration] Migrate 'HeaderPageLayout' and 'IllustratedHeaderPageLayout' components to TypeScript #33757
• Add dev env param #33776
• Move room visibility label to ValuePicker #33808
• Remove all instances of the policyRooms beta #33827
• Fix incorrect text color in some places #33832
• fix: move hiding only to the SectionList #33833
• fix: make merchant not required for p2p #33844
• Disable checkbox of task preview if not visit the task report #33857
• Fix invite message text is overflown #33858
• Do not allow emojis in address #33865
• Fix pressOnEnter of button to be disabled when screen is not focused #33889
• [NoQA] Avoid setting timezone and call private report notes for anonymous user #33911
• [TS migration] Migrate 'AmountTextInput' component to TypeScript #33955
• Fix/26946: Reset amount when edit waypoint  #33959
• Fix workspace reimbursement section blinks #33962
• Fix double clicking mini context menu selects the message #33963
• Update en.ts #33968
• fix: Clipped text on tab header on money request #34005
• Add Create Workspace test #34023
• [NoQA] Lint fix for Educational Interstitial #34026
• [NoQA] Skip the two report screen reassure tests #34042
• fix routes for tax rate and amount page #34094
• [No QA] [TS migration] Follow-up: update ReportActionReaction type #34095
• [No QA] Update en.ts #34104
• [CP Stag] Close modal when new merchant is empty #34158
• fix forwarding ref in FAB #34188
• Allow admins/managers to see RBR errors on reports #34195
• [CP Stag] rename style container for the native TextInput #34199

Deploy Blockers:

• Chat - Focus lost after choosing emoji from EmojPicker #33984
• [HOLD for payment 2024-01-17] [HOLD for payment 2024-01-18] Chat - The app crashes if I open an image attachment in offline mode #34047
• [C+ Checklist Needs Completion] [$500] Status - The colon between hours and minutes is misaligned #34136
• [$500] Android – Settings - App flickering when enter an authenticator code in 2FA creation page #34140
• [HOLD for payment 2024-01-18] [HOLD for payment 2024-01-17] IOU - Merchant editor does not close when removing merchant #34145
• [$500] BA - When page is reloaded in any form page, "Open in app" banner turns dark mode #34154
• Workspace - Room visibility options are also displayed as tooltips #34156
• [$500] Web - Workspace - Public room can't be opened for the second time #34165
• [HOLD for payment 2024-01-18] [HOLD for payment 2024-01-17] Scan - No red dot for Amount and Merchant when viewing failed scan request as Admin #34179
• IOU - An administrator cannot edit an unpaid IOU created by an employee #34181
• [HOLD for payment 2024-01-18] LHN - Tooltip Appears After FAB Opens and Displays the List When Hovering Over the FAB Icon #34183
• Language - Back button redirects to the same page when modifying link with slashes #34184
• [$500] [HOLD for payment 2024-01-18] [HOLD for payment 2024-01-17] LHN - Clicking the (FAB) after opening the modal does not close the modal #34185
• [$500] Web-Bank Account-Error message disappears when navigate back to Company information page #34193

Deployer verifications:

• I checked the App Timing Dashboard and verified this release does not cause a noticeable performance regression.
• I checked Firebase Crashlytics and verified that this release does not introduce any new crashes. More detailed instructions on this verification can be found here.
• I checked GitHub Status and verified there is no reported incident with Actions.

cc @Expensify/applauseleads

[OSBotify]

🚀 All staging deploys are complete, @Expensify/applauseleads please begin QA on version https://github.com/Expensify/App/releases/tag/1.4.23-0 🚀

[Julesssss]

Checked off #34156 as it isn't a blocker, and occurs on prod already

[kbecciv]

Regression is 12% left

#28695 - validation pending
#30863 - validation pending
#32528 - validation pending
#32543 - validation pending
#32667 blocked with comment #32667 (comment)
#32769 - validation pending
#33345 - validation pending
#33360 - validation pending
#33444 - validation pending
#33633 - validation pending
#33656 - validation pending
#33676 - validation pending
#33833 failing #22508, repo in prod, checking Off
#33857 - validation pending
#33858 - validation pending
#33889 - validation pending
#33959 - validation pending

Deploy blockers:

#33984
#34136
#34140
#34136
#34145
#34154
#34165
#34179
#34183
#34184
#34185

[roryabraham]

#34183 and #34185 should both be fixed by #34188 in 1.4.23-2, build running here

[thienlnam]