Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[$500] Integrate the report field value selector component with the backend #34198

Closed
thienlnam opened this issue Jan 10, 2024 · 16 comments
Closed
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 External Added to denote the issue can be worked on by a contributor Reviewing Has a PR in review

Comments

@thienlnam
Copy link
Contributor

thienlnam commented Jan 10, 2024

To set the report field, the report needs to first exist. If you’re creating a new IOU the report does not exist in the BE yet until it is submitted

So for draft new reports, we have to store the values locally until SubmitReport is called here, and then you can pass an additional field which contains the report field values

For existing reports, we can just call Report_SetFields

API Endpoint: Report_SetFields
Params:

  • Authtoken
  • reportID
  • reportFields = {“expensify_field_id_ASDF”:{“fieldID”:“field_id_ASDF”,“type”:“dropdown”, “value”: “new_value”}…}

For the SubmitReport usage, you’d also pass the same format as reportFields above under the key nameValuePairs

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~012de31b87d4a511c0
  • Upwork Job ID: 1757429370800812032
  • Last Price Increase: 2024-02-13
@thienlnam thienlnam added the Daily KSv2 label Jan 10, 2024
@melvin-bot melvin-bot bot added Reviewing Has a PR in review Weekly KSv2 and removed Daily KSv2 labels Jan 14, 2024
@allroundexperts
Copy link
Contributor

PR created!

@thienlnam thienlnam self-assigned this Jan 16, 2024
Copy link

melvin-bot bot commented Feb 2, 2024

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

@melvin-bot melvin-bot bot added Monthly KSv2 and removed Weekly KSv2 labels Feb 7, 2024
Copy link

melvin-bot bot commented Feb 7, 2024

This issue has not been updated in over 15 days. @allroundexperts, @thienlnam eroding to Monthly issue.

P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!

@thienlnam
Copy link
Contributor Author

We're done here

@slafortune slafortune added the Bug Something is broken. Auto assigns a BugZero manager. label Feb 12, 2024
@slafortune slafortune reopened this Feb 12, 2024
Copy link

melvin-bot bot commented Feb 12, 2024

Triggered auto assignment to @alexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

@melvin-bot melvin-bot bot added Daily KSv2 and removed Monthly KSv2 labels Feb 12, 2024
@slafortune
Copy link
Contributor

reopening as requested here

@jjcoffee
Copy link
Contributor

@alexpensify I'm due payment for the PR review on this. It hit production last week, so I think payment is due today. Thanks! 🙇

@alexpensify
Copy link
Contributor

@jjcoffee - Noted but please give me a day to catch up here.

@jjcoffee
Copy link
Contributor

@alexpensify Sure no worries, take your time! I think @allroundexperts is also due payment for raising the PR.

@alexpensify alexpensify added the External Added to denote the issue can be worked on by a contributor label Feb 13, 2024
@melvin-bot melvin-bot bot changed the title Integrate the report field value selector component with the backend [$500] Integrate the report field value selector component with the backend Feb 13, 2024
Copy link

melvin-bot bot commented Feb 13, 2024

Job added to Upwork: https://www.upwork.com/jobs/~012de31b87d4a511c0

@melvin-bot melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Feb 13, 2024
Copy link

melvin-bot bot commented Feb 13, 2024

Current assignee @allroundexperts is eligible for the External assigner, not assigning anyone new.

@alexpensify alexpensify removed the Help Wanted Apply this label when an issue is open to proposals by contributors label Feb 13, 2024
@alexpensify
Copy link
Contributor

alexpensify commented Feb 13, 2024

Here is the payment summary:

Upwork Job: https://www.upwork.com/jobs/~012de31b87d4a511c0

Extra Notes regarding payment: This one is related to Wave 6 - https://github.com/Expensify/Expensify/issues/309051

@alexpensify
Copy link
Contributor

Thanks for the patience here. I've sent a request to @jjcoffee in Upwork, please accept and I can complete the required process.

@allroundexperts - please submit a request in Chat. Thanks!

@jjcoffee
Copy link
Contributor

@alexpensify Accepted, thanks for sorting this out!

@alexpensify
Copy link
Contributor

Thanks, @jjcoffee was paid via Upwork. Closing this GH now.

@JmillsExpensify
Copy link

$1,500 approved for @allroundexperts

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 External Added to denote the issue can be worked on by a contributor Reviewing Has a PR in review
Projects
None yet
Development

No branches or pull requests

6 participants