-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[$500] Integrate the report field value selector component with the backend #34198
Comments
PR created! |
If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results. If a regression has occurred and you are the assigned CM follow the instructions here. If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future. |
This issue has not been updated in over 15 days. @allroundexperts, @thienlnam eroding to Monthly issue. P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do! |
We're done here |
Triggered auto assignment to @alexpensify ( |
reopening as requested here |
@alexpensify I'm due payment for the PR review on this. It hit production last week, so I think payment is due today. Thanks! 🙇 |
@jjcoffee - Noted but please give me a day to catch up here. |
@alexpensify Sure no worries, take your time! I think @allroundexperts is also due payment for raising the PR. |
Job added to Upwork: https://www.upwork.com/jobs/~012de31b87d4a511c0 |
Current assignee @allroundexperts is eligible for the External assigner, not assigning anyone new. |
Here is the payment summary:
Upwork Job: https://www.upwork.com/jobs/~012de31b87d4a511c0 Extra Notes regarding payment: This one is related to Wave 6 - https://github.com/Expensify/Expensify/issues/309051 |
Thanks for the patience here. I've sent a request to @jjcoffee in Upwork, please accept and I can complete the required process. @allroundexperts - please submit a request in Chat. Thanks! |
@alexpensify Accepted, thanks for sorting this out! |
Thanks, @jjcoffee was paid via Upwork. Closing this GH now. |
$1,500 approved for @allroundexperts |
To set the report field, the report needs to first exist. If you’re creating a new IOU the report does not exist in the BE yet until it is submitted
So for draft new reports, we have to store the values locally until SubmitReport is called here, and then you can pass an additional field which contains the report field values
For existing reports, we can just call Report_SetFields
API Endpoint: Report_SetFields
Params:
For the SubmitReport usage, you’d also pass the same format as reportFields above under the key nameValuePairs
Upwork Automation - Do Not Edit
The text was updated successfully, but these errors were encountered: