[$500] mWeb - Amount only is seen on header in IOU details page if navigated through deep link

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: v1.4.24-0
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:

Action Performed:

1. Create a new account, lets call it Account A
2. Create another new account, account B
3. Send an IOU from account A to account B and go to IOU details page and copy the URL
4. Sign in with account B
5. Navigate to the copied URL on step 3
6. Observe the IOU header in the IOU details page

Expected Result:

There should be "From ... " under the header

Actual Result:

1. Only the amount is visible
2. Getting Not Found View
3. After reload, the [Deleted message] title can be briefly seen
4. Money request info is missing and had to reload another time to get the correct view

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6338722_1704969427565.Screen_Recording_20240110_223735_Chrome.mp4

Screen.Recording.2024-02-18.at.2.01.32.PM.mov

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~013f1ca3c28189a2c4
• Upwork Job ID: 1745430304265371648
• Last Price Increase: 2024-01-18
• Automatic offers:
• s77rt | Reviewer | 0
• shahinyan11 | Contributor | 0

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~013f1ca3c28189a2c4

[melvin-bot]

Triggered auto assignment to @lschurr (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @s77rt (External)

[shahinyan11]

@kbecciv I encountered different behavior when performing the above steps. I see Hmm... it's not here page

[abeebridwan]

Proposal

Please re-state the problem that we are trying to solve in this issue.

The IOU header is incomplete in the IOU details page of Account B when accessed through the IOU details page URL of Account A. Subtitle("From ... ") under the Header is not rendered/missing.
This is noteworthy because an IOU has already been sent from Account A to Account B.

What is the root cause of that problem?

parentReport is not filled with the correct data. parentReport got its data from Onyx that didn't return the correct data when the IOU details page is navigate to with the url. The report in not Onyx.

What changes do you think we should make in order to solve the problem?

Since contributors can't work on Onyx without permission--- according to slack comms. Hence, Correct data should be filled/send in Onyx for IOU detail page to access when the request is made. The parentReport should be made available on Onyx...

What alternative solutions did you explore? (Optional)

[s77rt]

I'm not able to reproduce this one. But I think user B should just wait for the pusher events from the server to get the iou report.

[s77rt]

@abeebridwan Were you able to reproduce this? If so can you confirm if waiting fixes the issue?

[abeebridwan]

@s77rt
yes I am able to reproduce ... everytime I tried
will check if waiting fixes it

[abeebridwan]

@abeebridwan Were you able to reproduce this? If so can you confirm if waiting fixes the issue?

@s77rt even after waiting for 10secs ... still not changes
didn't fix it

[abeebridwan]

@s77rt
same happening on Desktop chrome ... for both(account A and Account B)
https://www.loom.com/share/f96bb7a1803a46268b7fcb647ef553a0

[s77rt]

@abeebridwan Would refreshing the page fix the issue? I think we are just missing a case where we should re-render the header component

[melvin-bot]

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

[lschurr]

Any update on this one @s77rt @abeebridwan?

[s77rt]

Just retested. I was able to reproduce this. For account B I had to close all the tabs so I don't get any pusher events. If we directly navigate to the chat report, the server won't send us pusher events for the iou report (the parent of that chat report).

This should be internal. cc @lschurr

PS: I think we can also fix this at the frontend level e.g. open iou report if it does not exist but I think it's better to at least check if we can get this fixed with pusher events

Screen.Recording.2024-01-18.at.5.35.53.PM.mov

[s77rt]

🎀 👀 🎀 C+ reviewed
https://expensify.slack.com/archives/C01GTK53T8Q/p1705599372427019

[melvin-bot]

Triggered auto assignment to @rlinoz, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[abeebridwan]

Just retested. I was able to reproduce this. For account B I had to close all the tabs so I don't get any pusher events. If we directly navigate to the chat report, the server won't send us pusher events for the iou report (the parent of that chat report).

This should be internal. cc @lschurr

PS: I think we can also fix this at the frontend level e.g. open iou report if it does not exist but I think it's better to at least check if we can get this fixed with pusher events

Screen.Recording.2024-01-18.at.5.35.53.PM.mov

@s77rt I don't there is a pusher event for the parent report... if i am correct.. fixing it in the front-end won't be the optimal way

[rlinoz]

on hold.

[s77rt]

Same ^

[shahinyan11]

@rlinoz @s77rt Hi there. Do we have any updates? The issue on which we hold was closed

[s77rt]

@shahinyan11 Can you still reproduce the bug on #34528?

[melvin-bot]

📣 @ShaheFS! 📣
Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork.
Please follow these steps:

1. Make sure you've read and understood the contributing guidelines.
2. Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
3. Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
4. Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details.
   
   Format:

Contributor details
Your Expensify account email: <REPLACE EMAIL HERE>
Upwork Profile Link: <REPLACE LINK HERE>

[shahinyan11]

@shahinyan11 Can you still reproduce the bug on #34528?

No I could not reproduce

[lschurr]

Sounds like this is fixed - Is there a PR for this one or it was fixed elsewhere? Are any payments due?

[s77rt]

@shahinyan11 Can you reproduce the bug reported in this issue? If so can you please update your proposal (if necessary)

[shahinyan11]

@shahinyan11 Can you reproduce the bug reported in this issue? If so can you please update your proposal (if necessary)

There have been updates and at the moment there is no Request money option. I tested the flow using Submit Expenses and the problem does not exist.

[s77rt]

Let's close this (no longer reproducible) cc @rlinoz

[rlinoz]

Closing, thanks!

[shahinyan11]

@rlinoz @s77rt Should not I receive any payment for this? I spent time on this issue and opened PR

[rlinoz]

Sorry I didn't remember that there was a PR open for this one, you are right.

[rlinoz]

Hey @lschurr this is fixed by something else apparently, but we had a PR in this one, so I think we are just waiting payment now to close it.

[lschurr]

Ok, the original bug was fixed here: #34528
But this PR was opened by @shahinyan11 and reviewed by @s77rt

So we'll pay as normal via Upwork.

[lschurr]

Payment summary:

• Contributor: $500 @shahinyan11 via Upwork
• Reviewer: $500 @s77rt via Upwork