[HOLD for payment 2024-10-16] [$500] Feature Request: Add :emojicode: selectors when editing messages.

[m-natarajan]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Problem:

Add :emojicode: selectors when editing messages.

Solution:

As a NewDot user I have become accustomed to being able to express myself with emojis, and the default way I do that is by typing :emojicodes:. However, when editing an existing message, we have an emoji picker, but no support for :emojicodes:

Context/Examples/Screenshots/Notes:

Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @roryabraham
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1704991655069279

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01b0abd6fa6e877b41
• Upwork Job ID: 1745886924480851968
• Last Price Increase: 2024-01-19
• Automatic offers:
• dukenv0307 | Contributor | 28120470

Issue Owner

Current Issue Owner: @twisterdotcom

[melvin-bot]

Triggered auto assignment to @laurenreidexpensify (NewFeature), see https://stackoverflowteams.com/c/expensify/questions/14418#:~:text=BugZero%20process%20steps%20for%20feature%20requests for more details.

[neonbhai]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Add :emojicode: selectors when editing messages

What is the root cause of that problem?

New Feature

What changes do you think we should make in order

We use ComposerWithSuggestions for normal message input (which has emoji and mention suggestions),

App/src/pages/home/report/ReportActionCompose/ReportActionCompose.js

Line 409 in 964548a

<ComposerWithSuggestions

but use the basic Composer for Editing messages.:

App/src/pages/home/report/ReportActionItemMessageEdit.tsx

Line 413 in 964548a

<Composer

We should configure the ReportActionItemMessageEdit to use ComposerWithSuggestions

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01b0abd6fa6e877b41

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @eVoloshchak (External)

[dukenv0307]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Implement suggestion emojis and mention when editing message

What is the root cause of that problem?

New feaure

What changes do you think we should make in order to solve the problem?

We only use Composer when editing message.

We can implement a new component like ComposerWithSuggestionsEdit. We can re-use some logic in ComposerWithSuggestions to implement this new component.

We shouldn't implement ComposerWithSuggestions for ReportActionItemMessageEdit because the global composer has many things different logic.

Here is the test branch: https://github.com/dukenv0307/App/tree/fix/34442

Optimize logic can be done in the PR

What alternative solutions did you explore? (Optional)

NA

Result

Screen.Recording.2024-01-15.at.12.38.09.mov

[laurenreidexpensify]

Not overdue, Melvin being a bit harsh with the weekend clock

[laurenreidexpensify]

@eVoloshchak bump on review thanks

[eVoloshchak]

I think we should proceed with @neonbhai's proposal
Using ComposerWithSuggestions is the cleaner approach, it will allow us to reuse an already existing logic
I do agree with the following concern from @dukenv0307 though

We shouldn't implement ComposerWithSuggestions for ReportActionItemMessageEdit because the global composer has many things different logic.

But I don't think creating a third component with overlapping logic would be a better solution. ComposerWithSuggestions ideally should just be a Composer with Suggestions component (that is not entirely the case now, the logic in ComposerWithSuggestions differs a little, but introducing a prop to control it in case we need to would be simpler)

🎀👀🎀 C+ reviewed!

[melvin-bot]

Current assignee @stitesExpensify is eligible for the choreEngineerContributorManagement assigner, not assigning anyone new.

[dukenv0307]

@eVoloshchak Actually, ComposerWithSuggestions is built for the global composer and it has many required props which don't have in ReportActionItemMessageEdit and some logic like focus of text input that doesn't same for composer of ReportActionItemMessageEdit.

that is not entirely the case now, the logic in ComposerWithSuggestions differs a little, but introducing a prop to control it in case we need to would be simpler

I believe that controlling ComposerWithSuggestions to use for edit message is very complex and it isn't simpler than create a new component as my suggestion. You can see my demo branch for more detail.

[melvin-bot]

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

[laurenreidexpensify]

next step: @stitesExpensify to assign

[stitesExpensify]

@eVoloshchak does this change your opinion on which approach we should take? #34442 (comment)

[eVoloshchak]

does this change your opinion on which approach we should take? #34442 (comment)

@stitesExpensify, it does. I took a look at @dukenv0307's test branch and ComposerWithSuggestions once again and I agree, there is too much logic that is specific to global composer, it would be simpler to just have a separate component. We should think of a better name for ComposerWithSuggestionsEdit on the PR stage

Let's proceed with @dukenv0307, sorry for the confusion folks

[melvin-bot]

⚠️ It looks like this issue is labelled as a New Feature but not tied to any GitHub Project. Keep in mind that all new features should be tied to GitHub Projects in order to properly track external CAP software time ⚠️

[melvin-bot]

Triggered auto assignment to Design team member for new feature review - @dubielzyk-expensify (NewFeature)

[laurenreidexpensify]

@twisterdotcom handing this one over for parental leave cover. We're still in review for the PR, so this will just be handling payment. We're also blocked on #41071 I believe. Thanks!

[laurenreidexpensify]

(I also don't know why the automation decided this was ready for payment a few months ago, am updating now)

[melvin-bot]

This issue has not been updated in over 15 days. @eVoloshchak, @twisterdotcom, @stitesExpensify, @dukenv0307 eroding to Monthly issue.

P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!

[eVoloshchak]

This feature was added by another PR (#44720) already it turns out
There is one small UI issue (#41071 (review)), but otherwise, this is fully implemented

@laurenreidexpensify, @stitesExpensify, what would be the correct course of action here?
Should we at least fix this UI issue?

[twisterdotcom]

We should fix the UI issue and pay out an acceptable amount for the work done up until now. I don't have a good sense of it, but I would say $500 might not be it. @eVoloshchak what's your honest assessment?

[eVoloshchak]

This is a second PR (the first one contained a regression and had to be reverted), so the full payment would have been $250. Given that and the fact that the UI fix would be straightforward (just need to change a single padding number), $150 seems fair to me

[twisterdotcom]

$150 it is. Payment Summary:

• @eVoloshchak paid $150 via NewDot requests (C+)
• @dukenv0307 paid $150 via Upwork here (Contributor)

[dukenv0307]

Thanks @twisterdotcom, I have accepted the offer on Upwork

[melvin-bot]

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.46-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Fix padding for edit composer suggestions #41071

If no regressions arise, payment will be issued on 2024-10-16. 🎊

For reference, here are some details about the assignees on this issue:

• @eVoloshchak requires payment through NewDot Manual Requests
• @dukenv0307 requires payment automatic offer (Contributor)

[melvin-bot]

BugZero Checklist: The PR adding this new feature has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@eVoloshchak / @dukenv0307] Please propose regression test steps to ensure the new feature will work correctly on production in further releases.
• [@twisterdotcom] Link the GH issue for creating/updating the regression test once above steps have been agreed upon.

[twisterdotcom]

I already did all the payment summary here.

[JmillsExpensify]

$150 approved for @eVoloshchak