[HOLD #37281][$1000] Onyx data does not get removed cleanly on sign out

[m-natarajan]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number:
Reproducible in staging?: needs reproduction ( Don't have account with several hundreds of chats)
Reproducible in production?:
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @marcaaron
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1705012041676559

Action Performed:

1. Signed into an account with many many chats
2. Signed out
3. Signed in with a brand new account (which should have only the Concierge chat)

Expected Result:

Nothing from the account that I signed out from should be persisted in the client data whatsoever.

Actual Result:

Tons of chats from the first account show up in the second account. A ton of Onyx keys still have values of {hasDraft: false} and there are also straight up reports that shouldn't be there at all. These also show up in the LHN.

Workaround:

unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01211aa8ecc46d7a5e
• Upwork Job ID: 1759703332875366400
• Last Price Increase: 2024-03-24

[melvin-bot]

Triggered auto assignment to @anmurali (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

@anmurali Whoops! This issue is 2 days overdue. Let's get this updated quick!

[anmurali]

I cannot reproduce

The two reports I see are Concierge DM and domain room, and the new account has both.

@marcaaron can you test this again and reopen if you still run into it?

[marcaaron]

It seems dependent on how much data you have in the first account when signing out. If you have a lot - not all of it gets cleared.

We can close it - but feels like there is some obvious reason why this is happening and it should be patched at some point. Switching from one account to another is not such a common thing though so we can deprioritize it for now (but it is still happening for me).

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01211aa8ecc46d7a5e

[melvin-bot]

Triggered auto assignment to Contributor Plus for review of internal employee PR - @thesahindia (Internal)

[mallenexpensify]

Experiencing what I believe is the same bug
https://expensify.slack.com/archives/C049HHMV9SM/p1708356217921739

I put the below on hold

• [HOLD #34473] After switching accounts, some chats from old account show upon launch then in LHN #36804

@thesahindia can you see if you're able to reproduce? thx

[thesahindia]

Yeah it's the same issue. I have experienced it in the past.

[thesahindia]

Please reassign. I am planning to go OOO.

[melvin-bot]

Triggered auto assignment to Contributor Plus for review of internal employee PR - @s77rt (Internal)

[melvin-bot]

@anmurali, @s77rt Huh... This is 4 days overdue. Who can take care of this?

[melvin-bot]

@anmurali, @s77rt Still overdue 6 days?! Let's take care of this!

[melvin-bot]

@anmurali, @s77rt Now this issue is 8 days overdue. Are you sure this should be a Daily? Feel free to change it!

[s77rt]

Still discussing in Slack

[mvtglobally]

Issue not reproducible during KI retests. (First week)

[s77rt]

No update. Still discussing in Slack

[melvin-bot]

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

[s77rt]

Bumped the slack thread

[shubham1206agra]

@anmurali This might be fixed with #37281.
cc @roryabraham @s77rt

[s77rt]

@shubham1206agra Thank you! Indeed that PR shall prevent this issue from happening. Let's put this one on hold

[mallenexpensify]

Put on hold, removed External and Help Wanted, bumped to Weekly

Thanks @shubham1206agra for the tip!

[s77rt]

#37281 is merged. Issue not longer reproducible. Let's close this

[mallenexpensify]

Throwing retest-weekly on this to confirm, then we can close. thx!

[anmurali]

@mallenexpensify any updates?

[mallenexpensify]

Closing, just tried to repro with no luck