Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[$500] Chat - Composed message still displayed in compose box after Ctrl+K and user select #34506

Closed
1 of 6 tasks
lanitochka17 opened this issue Jan 15, 2024 · 16 comments
Closed
1 of 6 tasks
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 External Added to denote the issue can be worked on by a contributor Help Wanted Apply this label when an issue is open to proposals by contributors

Comments

@lanitochka17
Copy link

lanitochka17 commented Jan 15, 2024

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!


Version Number: 1.4.25-1
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:

Action Performed:

  1. Login to https://staging.new.expensify.com/
  2. Type something in the compose box but don't send the message
  3. Press on CTRL + K
  4. Search for a user and navigate to the conversation

Expected Result:

The message you were previously composing is not displayed in the compose box

Actual Result:

The message you were previously composing is still displayed in the compose box

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • Windows: Chrome
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6343025_1705330523071.bandicam_2024-01-15_16-54-42-313.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~01a6cae98f12b7b6db
  • Upwork Job ID: 1746910171171639296
  • Last Price Increase: 2024-01-15
@lanitochka17 lanitochka17 added External Added to denote the issue can be worked on by a contributor Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. labels Jan 15, 2024
@melvin-bot melvin-bot bot changed the title Chat - Composed message still displayed in compose box after Ctrl+K and user select [$500] Chat - Composed message still displayed in compose box after Ctrl+K and user select Jan 15, 2024
Copy link

melvin-bot bot commented Jan 15, 2024

Job added to Upwork: https://www.upwork.com/jobs/~01a6cae98f12b7b6db

@melvin-bot melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Jan 15, 2024
Copy link

melvin-bot bot commented Jan 15, 2024

Triggered auto assignment to @MitchExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

Copy link

melvin-bot bot commented Jan 15, 2024

Triggered auto assignment to Contributor-plus team member for initial proposal review - @mollfpr (External)

@dummy-1111
Copy link
Contributor

I'm not sure if this is a bug

@0xSero
Copy link

0xSero commented Jan 15, 2024

Hello,

I am not sure if this is currently being worked on, but regardless I'll leave a response on how I'd fix this, I would set up a listener for a switch in user chats and reset the chatbox message if chat changes, it could also be done on the CTRL + K commands.

Copy link

melvin-bot bot commented Jan 15, 2024

📣 @Seroxdesign! 📣
Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork.
Please follow these steps:

  1. Make sure you've read and understood the contributing guidelines.
  2. Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
  3. Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
  4. Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details.
    Screen Shot 2022-11-16 at 4 42 54 PM
    Format:
Contributor details
Your Expensify account email: <REPLACE EMAIL HERE>
Upwork Profile Link: <REPLACE LINK HERE>

@johnbchron
Copy link

johnbchron commented Jan 15, 2024

@MitchExpensify Can we get confirmation that this is a bug? The video appears to re-select the same chat, which if that was the intended action, the bug would be regarding the population of the draft comment, which seems like not a bug given the existence of getDraftComment, etc.

Copy link

melvin-bot bot commented Jan 15, 2024

📣 @johnbchron! 📣
Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork.
Please follow these steps:

  1. Make sure you've read and understood the contributing guidelines.
  2. Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
  3. Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
  4. Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details.
    Screen Shot 2022-11-16 at 4 42 54 PM
    Format:
Contributor details
Your Expensify account email: <REPLACE EMAIL HERE>
Upwork Profile Link: <REPLACE LINK HERE>

@johnbchron
Copy link

Contributor details
Your Expensify account email: [email protected]
Upwork Profile Link: https://www.upwork.com/freelancers/~018db43a7e191535c4

Copy link

melvin-bot bot commented Jan 15, 2024

✅ Contributor details stored successfully. Thank you for contributing to Expensify!

@MitchExpensify
Copy link
Contributor

I don't see how this is a bug, it looks like the draft feature that is working as intended

@MitchExpensify
Copy link
Contributor

Closing, @lanitochka17 do we need to update testrail so this doesn't get flagged again?

@MitchExpensify
Copy link
Contributor

Yeah I think this is only a bug if the message you were composing for User A showed in the compose box when navigating to a chat with anyone other than user A. Perhaps we update step 17 to clarify that @lanitochka17 ?

@lanitochka17
Copy link
Author

@MitchExpensify sounds good. Please will update step.

@MitchExpensify
Copy link
Contributor

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 External Added to denote the issue can be worked on by a contributor Help Wanted Apply this label when an issue is open to proposals by contributors
Projects
None yet
Development

No branches or pull requests

6 participants