IOU - The paid IOU shows a message about the disabled category

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: 1.4.25-1
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:

Action Performed:

Preconditions:
In OldDot under admin, create a Collect group policy, enable categories and add 3 categories, add an employee to the policy.

Steps:

1. Open https://staging.new.expensify.com/
2. Log in to the employee's account
3. Tap on the green plus button (FAB)
4. Select Request money
5. Select any currency and amount
6. Click next
7. Choose a WS room
8. Click on "Show more"
9. In the "Category" section, select any category
10. Complete the IOU
11. Open https://staging.expensify.com/
12. Log in to the admin account
13. Navigate to the Collect group policy settings
14. In the category tab, disable the employee's selected category from step 9
15. Open https://staging.new.expensify.com/
    in incognito mode.
16. Log in as an administrator
17. Go to the employee report and pay the IOU
18. Under the employee's account, open the IOU details

Expected Result:

The message about the disabled category should disappear after IOU payment

Actual Result:

The paid IOU shows a message about the disabled category

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6343587_1705353489660.Recording__1087.mp4

View all open jobs on GitHub

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot]

Triggered auto assignment to @deetergp (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[neonbhai]

Proposal

Please re-state the problem that we are trying to solve in this issue.

The paid IOU shows a message about the disabled category

What is the root cause of that problem?

This occurs as we will show a violation without checking if the Request is paid.



The only condition to show a violation is the canUseViolations beta flag:

App/src/components/ReportActionItem/MoneyRequestView.js

Line 346 in d5f0f6f

{canUseViolations && <ViolationMessages violations={getViolationsForField('category')} />}

What changes do you think we should make in order

We should check if the Request isSettled before showing violations:

const shouldShowViolations = canUseViolations && !isSettled;

Then here:

{shouldShowViolations && <ViolationMessages violations={getViolationsForField('category')} />}

We will do the same for other fields.

[cead22]

The message about the disabled category should disappear after IOU payment

This is not the expected behavior, so closing. Adding the source of expected behavior can be useful when logging bugs

Violations seem to be working correctly here, and they're behind a beta, so even if this wasn't the expected behavior, we shouldn't block on violations for the time being