IOU - After getting paid, the request money is added again along with the previously paid IOU

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: 1.4.25-4
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:

Action Performed:

1. Login with User A and open User B's chat
2. Go to the request money section enter an amount and complete the flow
3. Login with User B from another browser and open User A's chat
4. Click on "Pay elsewhere."
5. Return to User A's account
6. Navigate to the request money section again and complete the flow

Expected Result:

A new request money should not be added along with the previously paid IOU

Actual Result:

After getting paid, the request money is added again along with the previously paid IOU

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6343665_1705357475259.2024-01-16_00-35-53.mp4

View all open jobs on GitHub

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot]

Triggered auto assignment to @roryabraham (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[roryabraham]

Yikes, this is real bad

[roryabraham]

Was able to reproduce this

[mountiny]

This feels more like backend issue. When paid the chatReport.IOUReportID should be unset

To make sure though i think we could check when requesting if that report is in processing state and if its in higher than that, create new optimistic report.

Is this repo with in production? What about production API

[mountiny]

Feel free to mark this external to get more people to look into this too

[abzokhattab]

cannot reproduce it on the latest main .. are you able to reproduce it on main @roryabraham ?

[bernhardoj]

This is a Pusher issue.

the pusher sends 4 report data in which the first 2 clears the iouReportID but the last one gives the iouReportID back.

[mountiny]

@bernhardoj what command is this response of?

[bernhardoj]

I got the pusher after paying the money request from the other user.

[mountiny]

Its related to this PR cc @NikkiWines https://github.com/Expensify/Web-Expensify/pull/40051 I believe. Before, we did not correctly send the data for report previews which we do not.

Before that change we did not get as far as here in the method and in case of report preview we stopped execution of the method. Now that does not happen and on these lines we send the incorrect data in this case

[mountiny]

Made a PR to fix this in API

[mountiny]

Not app blocker so I will close this