[ON HOLD Payment 4/3/24] [Violations] [$500] Don't show RBR on the LHN for transaction threads with violations if the report has already been reimbursed/settled

[cead22]

• Slack discussion (internal)
• Transaction threads for transactions that have violations show up on the LHN with a RBR for the use that's requesting money
• The idea behind RBR is to show the user a path to take an action to fix a potential issue
• This is reasonable for the user requesting money because their requests/transactions may contain violations that can prevent them from getting approved and paid
• Once the requests are paid, we agreed to continue showing violations in order to show that the request may not be in compliance with the current workspace rules, which is useful for the users requesting money, and also users paying those requests
• However, the RBR specifically on the LHN isn't as relevant because the main idea behind that is to show a path to fix an issue, but in this case, the "issue" is the request has violations, but since they've been paid/settled, this isn't important for the requestor to do

Given that, let's not show RBR on the LHN for transaction threads with violations, if the transactions/money requests have been paid/settled

@trevor-coleman @lindboe can you please comment here so I can assign you? Thanks

---

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: v1.4.43-14
Reproducible in staging?: Presumably
Reproducible in production?: Presumably
Issue reported by: @situchan #35449 (comment)

Action Performed:

• Make sure you're on the violations beta
• Request money without adding a category from workspace that requires category (it should have a missing category violation)
• Submit the request if you need to
• Approve the request as a workspace admin
• Open the transaction thread as the requester. You may need to navigate to another chat, and then back to the transaction thread

Expected Result:

• RBR should not be shown on the LHN for the submitter

Actual Result:

• RBR is shown on the LHN for the submitter

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01e69e67564d338f8f
• Upwork Job ID: 1761101186954891264
• Last Price Increase: 2024-02-23
• Automatic offers:
• situchan | Reviewer | 0
• FitseTLT | Contributor | 0

[trevor-coleman]

Commenting for assignment

[cead22]

ReportUtils PR was just merged, so we're starting to work on other issues, but that one was higher priority

[cead22]

Still a priority but other issues are being worked on first

[melvin-bot]

@cead22, @trevor-coleman Huh... This is 4 days overdue. Who can take care of this?

[lindboe]

@cdanwards this is the ticket you were pulling into optimistic IDs, right? since we're already making RBR changes there?

[cead22]

WIP

[situchan]

Happy to take this as C+ since I already have context

[JmillsExpensify]

Following on that last comment, we're getting lots of reports of this issue in the app, so it would be super ideal if we can get this PR raised and merged this week.

[FitseTLT]

PR is on review stage 👍

[JmillsExpensify]

Good movement on the linked PR. Ideally we can even get it merged before the week closes out.

[cead22]

PR is merged

[sakluger]

FYI this still seems to be broken for me. I left a more detailed comment in the PR: #37767 (comment).

[cead22]

I'm pretty sure that error is unrelated, and this is happening because OpenReport is failing with a JSON error

It looks like this started on Friday

[cead22]

I found the issue and submitted a PR

[cead22]

That said, the problem is unrelated to this GH issue, so I'm going to close this one since it's done

[FitseTLT]

@cead22 What about Payments?? 😆

[cead22]

Argh, they always get me. I see the upwork jobs were created, but not sure what else we need for payments -- @CortneyOfstad @zanyrenney can you help with this please?

[FitseTLT]

It was just deployed today. I am only claiming to reopen it 👍

[CortneyOfstad]

No worries — since it was just deployed today, we will need to wait the 7-day period, so going to adjust the title to reflect the payment date if there are no regressions 👍

PR link here ¸— #37767

[CortneyOfstad]

Payment has been completed! Will post payment summary below.

@situchan does this need a regression test? For some reason the checklist is not populating, so just wanted to confirm. Thanks!

[CortneyOfstad]

Payment Summary

@FitseTLT (Contributor) — paid $500 via Upwork
@situchan (C+) — paid $500 via Upwork

[zanyrenney]

Seeing as payment is complete, we can close this one out. Thanks for managing the payment @CortneyOfstad ❤️