[HOLD for payment 2024-02-07] [$500] Magic code - An additional page appears when navigate from Abracadabra page

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: 1.4.25-1
Reproducible in staging?: y
Reproducible in production?: n
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:

Action Performed:

1. Create new account
2. Copy the Magic link and change it to staging
3. Open a new tab and navigate to the staging magic link> change the last numbers
4. Verify the a Magic code expired page is displayed
5. Navigate to the original tab

Expected Result:

Original tab( magic code page) should be open

Actual Result:

An additional page appears (Magic code page flickers) when navigate from Abracadabra page to original tab

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6343716_1705361816806.Recording__1817.1.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~0139aec2eed464b4a1
• Upwork Job ID: 1747260699342594048
• Last Price Increase: 2024-01-16
• Automatic offers:
• jjcoffee | Reviewer | 28108571
• s-alves10 | Contributor | 28108572

Issue Owner

Current Issue Owner: @mallenexpensify

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot]

Triggered auto assignment to @mountiny (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[situchan]

This looks similar to #34532. Can we ask QA team to retest on v1.4.25-6?

[mountiny]

yep already did, had the same idea

[isagoico]

This issue is still reproducible in 25-6. Also noticed that after going back to the login tab:

• The go back button is unresponsive
• The request link timer resets back to 30 seconds every time the user navigates away and back

magic.link.mp4

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~0139aec2eed464b4a1

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @jjcoffee (External)

[dummy-1111]

This issue is reproducible in production as well. Not a deploy blocker

[mountiny]

checking with QA

[kbecciv]

@mountiny Three members of the QA team are unable to reproduce the issue in the production.

Recording.1824.mp4

[dummy-1111]

What does the above video mean? It's staging. This is reproducible in the production for sure
Please check the below video(37s ~ 38s)

bandicam.2024-01-17.02-00-01-573.h264.mp4

[melvin-bot]

Triggered auto assignment to @mallenexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[mountiny]

I am so confused from this bug or how it should even work, I think its not a blocker per @s-alves10 video

[NikkiWines]

@s-alves10's video does show that this isn't a staging only issue, so agreed that it's not a blocker.

@mountiny, the gist of the issue is that we shouldn't be showing the Another login page is open view for just a split second after navigating back to the original tab but before showing the blank magic code view.

We also shouldn't be briefly showing the Incorrect magic code view that seems to pop up occasionally after the Another login page is open view.

Ideally, the flow should be seamless. After navigating back to the original tab you should only see the black magic code view.

expired.code.flow.mov

[mountiny]

@jjcoffee is this reproducible after reverting the onyx bump?

@lanitochka17 can your team retest please?

[isagoico]

I'm still able to see the issue in staging Web. It is extremely fast so I set the video to 0.4:

slomox.mp4

I see the same flicker in production:

Prod.slomox.mp4

---

Related to the behavior I posted here:

The go back button is unresponsive
The request link timer resets back to 30 seconds every time the user navigates away and back

The go back button is now responsive in STG 🎉

[dummy-1111]

@jjcoffee
PR is ready for review #34791

[jjcoffee]

Thanks, reviewing tomorrow!

[jjcoffee]

Hmm actually I'm not able to reproduce this on staging or latest main anymore. Can anyone else double check? cc @kbecciv @s-alves10

[dummy-1111]

@jjcoffee This issue is still reproducible in staging

bandicam.2024-01-27.06-17-01-892.mp4

[jjcoffee]

@s-alves10 Hmm does it depend on device/browser maybe?

[dummy-1111]

I tested it in chrome browser. Another login page appears a very short period of time. Please take a look between 4s ~ 5s of the video

34567.mp4

[mallenexpensify]

Is this something that we expect to happen frequently? Seems like a pretty extreme edge case for a normal user, especially if we're not regularly logging people out. cc @mountiny for 👀 too. Was looking at these QA steps

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.33-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• fix: check visibility as well to show another login message #34791

If no regressions arise, payment will be issued on 2024-02-07. 🎊

For reference, here are some details about the assignees on this issue:

• @jjcoffee requires payment automatic offer (Reviewer)
• @s-alves10 requires payment automatic offer (Contributor)

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@jjcoffee] The PR that introduced the bug has been identified. Link to the PR:
• [@jjcoffee] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@jjcoffee] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@jjcoffee] Determine if we should create a regression test for this bug.
• [@jjcoffee] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@mallenexpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[mountiny]

Yeah I agree this is minor

[jjcoffee]

• The PR that introduced the bug has been identified. Link to the PR: Show notification instead of login page when user has another tab open - #26161 #27385
• The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: https://github.com/Expensify/App/pull/27385/files#r1478381371
• A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: N/A - just needed more thorough testing
• Determine if we should create a regression test for this bug. Yes
• If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.

Regression Test Proposal

Web only:

1. Log out if logged in
2. Enter email or phone number and tap Continue to go to the magic code page
3. Open a new tab and navigate to the magic link (edit the magic code in the link to make the code invalid, e.g. change the last number)
4. Verify that the magic code expired page is displayed
5. Navigate to the original tab and switch back and forth between the tabs
6. Verify that the magic code page is opened without any flickering of the "Another login page is open" text

Do we agree 👍 or 👎

[melvin-bot]

@mallenexpensify, @jjcoffee, @mountiny, @s-alves10 Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[mallenexpensify]

Contributor: @s-alves10 paid $500 via Upwork
Contributor+: @jjcoffee paid $500 via Upwork.

Testrail GH https://github.com/Expensify/Expensify/issues/368509

Thanks!

[greg-schroeder]

Hey all - can anyone confirm if this issue might be related to what was implemented here?

#36651

[dummy-1111]

@greg-schroeder

Yes, I think so. I show the Another Login Page is Open view only when both tabs or windows are visible intentionally. Isn't this enough?

[greg-schroeder]

Thanks @s-alves10! I'll close that other one as expected behavior then