[HOLD for payment 2024-02-07] [$500] [ECARD TRANSACTIONS] report sub-total says Out of pocket, instead of Out-of-pocket spend (missing hyphen, and "spend")

[kevinksullivan]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Issue reported by: @kevinksullivan
Slack conversation: https://expensify.slack.com/archives/C05DWUDHVK7/p1705442308576449

Action Performed:

1. Create a free workspace and set it as your default
2. Incur a charge on an Expensify Card
3. Add a manual request
4. Tap into the report containing both expenses

Expected Result:

The sub-total should show Out-of-pocket spend, with the reimbursable total.

Actual Result:

The subtotal shows Out of pocket, and is missing the hyphens, and "spend".

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~014c5b9f85422667c6
• Upwork Job ID: 1748142102095720448
• Last Price Increase: 2024-01-19
• Automatic offers:
• Ollyws | Contributor | 28109141

[melvin-bot]

Triggered auto assignment to @JmillsExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[ghost]

Proposal

Please re-state the problem that we are trying to solve in this issue.

report sub-total says Out of pocket, instead of Out-of-pocket spend (missing hyphen, and "spend")

What is the root cause of that problem?

App/src/languages/en.ts

Line 2006 in a8acf44

outOfPocket: 'Out of pocket',

What changes do you think we should make in order to solve the problem?

We can just add Out-of-pocket spend in place of Out of pocket

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~014c5b9f85422667c6

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @Ollyws (External)

[melvin-bot]

📣 @AnshuAgarwal24 You have been assigned to this job!
Please apply to the Upwork job and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Once you apply to this job, your Upwork ID will be stored and you will be automatically hired for future jobs!
Keep in mind: Code of Conduct | Contributing 📖

[melvin-bot]

📣 @Ollyws 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[grgia]

@Ollyws I went ahead and assigned this one out since it's simple

[grgia]

I don't think we need C+ review for this though since it's a copy change

[ghost]

Thanks for assigning it to me @grgia. I will work on it and you can expect a PR by EOD today.

[ghost]

Upwork Proposal Sent - Upwork Proposal

[ghost]

PR raised

[kevinksullivan]

Waiting on @grgia 's review

[dylanexpensify]

Where's the new PR mentioned in closed PR @AnshuAgarwal24

[dylanexpensify]

#34790 (comment)

[pecanoro]

@dylanexpensify Right above your comment 😄

[ghost]

Please accept my proposal on Upwork! and by when I can expect the payment will be done ? @pecanoro @grgia

[pecanoro]

@AnshuAgarwal24 7 days after hitting production.

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.33-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Updated Out of Pocket Text Updated (English and Spanish) #35162

If no regressions arise, payment will be issued on 2024-02-07. 🎊

For reference, here are some details about the assignees on this issue:

• @Ollyws requires payment automatic offer (Contributor)
• @AnshuAgarwal24 requires payment (Needs manual offer from BZ)

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@Ollyws] The PR that introduced the bug has been identified. Link to the PR:
• [@Ollyws] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@Ollyws] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@Ollyws] Determine if we should create a regression test for this bug.
• [@Ollyws] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[melvin-bot]

Issue is ready for payment but no BZ is assigned. @bfitzexpensify you are the lucky winner! Please verify the payment summary looks correct and complete the checklist. Thanks!

[Ollyws]

This didn't require C+ review and the contributor has already been paid so we're good to close.