[$500] [MEDIUM] Distance: Hmm not here on editing waypoints , Phone time display& app back button overlaps

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: 1.4.26
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal team
Slack conversation:

Action Performed:

1. Launch app
2. Tap fab
3. Tap request money--- Distance
4. Enter start, finish waypoints
5. Tap "add stop" and enter a location
6. Tap next
7. Select a Workspace
8. Tap to save the request
9. Tap on the distance request created to open distance request details page, then tap again to open the request itself
10. Tap distance section
11. Tap any of the waypoints (start, stop or finish)

Expected Result:

Hmm not here must not be shown when tapping in waypoints from edit distance
Phone time display and app back button must not overlap

Actual Result:

Hmm not here shown when tapping in waypoints from edit distance
Phone time display and app back button overlaps

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6345661_1705517827254.edit.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01fb77766c12cee78d
• Upwork Job ID: 1747720175925194752
• Last Price Increase: 2024-03-15

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01fb77766c12cee78d

[melvin-bot]

Triggered auto assignment to @conorpendergrast (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @alitoshmatov (External)

[wildan-m]

@lanitochka17 can you consistently reproduce it? I can only reproduce it once, and then not reproducible anymore

[wildan-m]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Hmm not here on editing waypoints, Phone time display& app back button overlaps

What is the root cause of that problem?

There are two separate issues:

1. Hmm not here on editing waypoints
2. Phone time display & app back button overlap

The first issue occurs when the request report is being processed and we promptly open the edit page of the waypoint. I am not always able to reproduce this issue, but I can do so more consistently on the web when following the reproduction steps quickly.

The problem arose when we initiated a new report thread here:

App/src/components/ReportActionItem/MoneyRequestAction.tsx

Line 99 in c8826dd

Report.openReport(thread.reportID, userLogins, thread, action.reportActionID);

The server returns an error Open Report Auth Error, which block the waypoint editing.

The second issue is the layout issue, we are wrapping IOURequestStepWaypoint with not found page from withWritableReportOrNotFound HOC, this makes not found page shown without safe area from ScreenWrapper

What changes do you think we should make in order to solve the problem?

The first issue appears to be a backend problem, as an open auth error is encountered when creating a thread. To address this from the frontend, we can resolve it by disregarding the open auth error when adding a report in progress with the report.isOptimisticReport check.

function canUserPerformWriteAction(report: OnyxEntry<Report>) {
    const reportErrors = getAddWorkspaceRoomOrChatReportErrors(report);

    // If the Money Request report is marked for deletion, let us prevent any further write action.
    if (isMoneyRequestReportPendingDeletion(report)) {
        return false;
    }

    return !isArchivedRoom(report) && report && (isEmptyObject(reportErrors) || report.isOptimisticReport) && isAllowedToComment(report) && !isAnonymousUser;
}

Or check report?.pendingFields?.createChat

    return !isArchivedRoom(report) && (isEmptyObject(reportErrors) || report?.pendingFields?.createChat === CONST.RED_BRICK_ROAD_PENDING_ACTION.ADD) && report && isAllowedToComment(report) && !isAnonymousUser;

This way, the page not found page will not block waypoint editing during the report addition process.

For 2nd issue,
we can add shouldShowWrapper param to withWritableReportOrNotFound HOC

export default (shouldShowWrapper = false) => (WrappedComponent) => {
    // eslint-disable-next-line rulesdir/no-negated-variables
    function WithWritableReportOrNotFound({forwardedRef, ...props}) {
        const {
            route: {
                params: {iouType},
            },
            report,
        } = props;
        const iouTypeParamIsInvalid = !_.contains(_.values(CONST.IOU.TYPE), iouType);
        const canUserPerformWriteAction = ReportUtils.canUserPerformWriteAction(report);
        if (iouTypeParamIsInvalid || !canUserPerformWriteAction) {
            if(shouldShowWrapper)
            {
                return <ScreenWrapper><FullPageNotFoundView shouldShow /></ScreenWrapper>;
            }
            return <FullPageNotFoundView shouldShow />;
        }

Or we can also extract ScreenWrapper from IOURequestStepWaypoint to MoneyRequestWaypointPage like what we did to EditRequestReceiptPage

Branch to test.

What alternative solutions did you explore? (Optional)

[lanitochka17]

Issue is still reproducible on the latest build 1.4.30-0

ye.mp4

[JordanLevy19]

Hi @lanitochka17 - how can I report a separate bug I uncovered from testing this issue? I've read through the contributing guidelines but can't seem to find anything regarding submitting new issues or bugs that are not posted on up-work or in the GitHub tickets. Thank You!

[melvin-bot]

📣 @JordanLevy19! 📣
Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork.
Please follow these steps:

1. Make sure you've read and understood the contributing guidelines.
2. Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
3. Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
4. Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details.
   
   Format:

Contributor details
Your Expensify account email: <REPLACE EMAIL HERE>
Upwork Profile Link: <REPLACE LINK HERE>

[JordanLevy19]

Contributor details
Your Expensify account email: [email protected]
Upwork Profile Link: https://www.upwork.com/freelancers/~01514944ec46d16d1c

[melvin-bot]

✅ Contributor details stored successfully. Thank you for contributing to Expensify!

[alitoshmatov]

@JordanLevy19 Currently bug reports from external contributors are not accepted. But if you think this bug is vulnerability you can refer to this https://github.com/Expensify/App/blob/main/contributingGuides/CONTRIBUTING.md#reporting-vulnerabilities

[melvin-bot]

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

[JordanLevy19]

@alitoshmatov ahh ok ok thank you for getting back to me on that!

[wildan-m]

@alitoshmatov any feedback with this proposal?

[alitoshmatov]

I also couldn't reproduce this issue

Screenrecorder-2024-01-26-14-58-49-492.mp4

[wildan-m]

@alitoshmatov try to reproduce on the web desktop with quick speed.

If that's not working, please try again with simulate slow 3g network throttle in chrome dev tools

[conorpendergrast]

@alitoshmatov Let me know if you're still struggling to reproduce, and I'll try too!

[alitoshmatov]

@conorpendergrast That would be great.

[wildan-m]

@alitoshmatov @abekkala any updates on the discussion?

[abekkala]

https://expensify.slack.com/archives/C03SSAQ7P/p1709307776542729

[melvin-bot]

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

[wildan-m]

@alitoshmatov @abekkala I can't access both links. Could you please send me a copy?

[abekkala]

I have asked internally for someone to take a look at this one!

https://expensify.slack.com/archives/C02MW39LT9N/p1709588018696859

[mvtglobally]

Issue not reproducible during KI retests. (First week)

[wildan-m]

Issue not reproducible during KI retests. (First week)

The error message returned from the backend remains the same, but the behavior has changed. Previously, the error message was displayed when editing waypoints. Now, if the report is not ready, it will completely block the money request view. (Is this the new expected behavior?)

GMT20240305-091824_Clip_Wildan.M.s.Clip.03_05_2024.mp4

Using this reproduction step, I can confirm that the second issue related to the back arrow overlap still exists.

[abekkala]

@wildan-m can you get the requestID from this action?

Once I have the requestID we can review the logs.

[wildan-m]

@abekkala I'm unsure which request ID to share. If you're referring to when calling CreateDistanceRequest, here is one: 85fe6a37df114ab5-CGK. However, if it pertains to opening the report, this attached log might be helpful.

staging.new.expensify.com-1709686997589.log

[tgolen]

@wildan-m I'm interested in getting the requestID of whatever request is being returned with the error in question. IE: this one:

The error message returned from the backend remains the same

Once I have that requestID I can look into the server logs to see what's causing it.

[wildan-m]

Hi, the behavior has reverted to the previous state. I am able to replicate the issue on the latest staging.

GMT20240307-015258_Clip_Wildan.M.s.Clip.03_07_2024.mp4

@tgolen here is a response sample 8606f3a57b06357a-CGK

{
    "code": 666,
    "jsonCode": 666,
    "type": "Expensify\\Libs\\Error\\ExpError",
    "UUID": "5CBABCBB-13F3-4535-9AB2-28C50BDDD7A2",
    "message": "Auth OpenReport returned an error",
    "title": "",
    "data": {
        "onyxData": [
            {
                "onyxMethod": "merge",
                "key": "report_781276570513805",
                "value": {
                    "errorFields": {
                        "createChat": {
                            "1709776405511156": "Auth OpenReport returned an error"
                        }
                    }
                }
            }
        ]
    },
    "htmlMessage": "",
    "onyxData": [
        {
            "onyxMethod": "merge",
            "key": "report_781276570513805",
            "value": {
                "errorFields": {
                    "createChat": {
                        "1709776405511156": "Auth OpenReport returned an error"
                    }
                }
            }
        }
    ],
    "requestID": "8606f3a57b06357a-CGK"
}

[melvin-bot]

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

[abekkala]

@wildan-m have you been able to retrieve the requestID? Once we have that an engineer will be able to take a look!

[wildan-m]

@abekkala Hey, thanks for asking. I already shared them in the previous messages. You can check them out and let me know what you think.

[melvin-bot]

@abekkala, @alitoshmatov Whoops! This issue is 2 days overdue. Let's get this updated quick!

[melvin-bot]

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

[abekkala]

It looks like the error shown in 8606f3a57b06357a-CGK is one that we've spotted previously and there is already a GH in progress to fix: https://github.com/Expensify/Expensify/issues/367045

I'm going to close this one out for now.

[wildan-m]

@abekkala, there exist two distinct issues. Addressing one does not imply the resolution of the other. Upon utilizing deeplinking within the native application to attempt access to the edit point links, which are inaccessible, it becomes apparent that the arrow's placement is excessively elevated. Shall we disregard this problem?

More details:
#34666 (comment)