Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[$500] IOU Report - Two separate IOU reports created in the same 1:1 chat #34674

Closed
1 of 6 tasks
isagoico opened this issue Jan 17, 2024 · 17 comments
Closed
1 of 6 tasks
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 External Added to denote the issue can be worked on by a contributor Help Wanted Apply this label when an issue is open to proposals by contributors

Comments

@isagoico
Copy link

isagoico commented Jan 17, 2024

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!


Version Number: 1.4.25-8
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @mallenexpensify
Slack conversation: https://expensify.slack.com/archives/C01GTK53T8Q/p1705451831035939?thread_ts=1705449509.628199&cid=C01GTK53T8Q

Action Performed:

@mallenexpensify reproduction steps

  1. Received money request from Scott
  2. Noticed it didn't include the $2.87 I knew I already owed him
  3. Asked Scott to request $1 manually
  4. $1 was added to the the most recent IOU request, old one hasn't been updated the past two transactions

Alternate reproduction steps:

  1. Create 2 manual IOUs in a 1:1 conversation with user B
  2. Create a Split with a scanned expense in a group conversation that includes user B and another user
  3. Wait for the Scan to finish
  4. Create a manual Split in the same conversation
  5. Navigate back to the 1:1 to check the IOU reports

Expected Result:

There should be only one, ongoing IOU request between two users.

Actual Result:

There are two active IOU requests

Workaround:

N/A

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

image
image

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~01a527a0df0c4b582d
  • Upwork Job ID: 1747731238713110528
  • Last Price Increase: 2024-01-31
@isagoico isagoico added External Added to denote the issue can be worked on by a contributor Daily KSv2 Needs Reproduction Reproducible steps needed Bug Something is broken. Auto assigns a BugZero manager. labels Jan 17, 2024
@melvin-bot melvin-bot bot changed the title IOU Report - Two separate IOU reports created in the same 1:1 chat [$500] IOU Report - Two separate IOU reports created in the same 1:1 chat Jan 17, 2024
Copy link

melvin-bot bot commented Jan 17, 2024

Job added to Upwork: https://www.upwork.com/jobs/~01a527a0df0c4b582d

Copy link

melvin-bot bot commented Jan 17, 2024

Triggered auto assignment to @joekaufmanexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

@melvin-bot melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Jan 17, 2024
Copy link

melvin-bot bot commented Jan 17, 2024

Triggered auto assignment to Contributor-plus team member for initial proposal review - @eVoloshchak (External)

@isagoico
Copy link
Author

I was able to reproduce the issue, here are the steps:

  1. Create 2 manual IOUs in a 1:1 conversation with user B
  2. Create a Split with a scanned expense in a group conversation that includes user B and another user
  3. Wait for the Scan to finish
  4. Create a manual Split in the same conversation
  5. Navigate back to the 1:1 to check the IOU reports

On the image below:

  1. IOU report 1 contains the expenses made in the 1:1 conversation
  2. IOU report 2 contains the split expenses made in the group conversation

image

@mallenexpensify mallenexpensify removed the Needs Reproduction Reproducible steps needed label Jan 18, 2024
@mallenexpensify
Copy link
Contributor

@eVoloshchak any reason you can think this shouldn't be external?

@melvin-bot melvin-bot bot added the Overdue label Jan 22, 2024
@joekaufmanexpensify
Copy link
Contributor

Not overdue. Pending proposals

@melvin-bot melvin-bot bot removed the Overdue label Jan 22, 2024
@joekaufmanexpensify
Copy link
Contributor

Same

@eVoloshchak
Copy link
Contributor

any reason you can think this shouldn't be external?

@mallenexpensify, this could be a BE issue, but could also be a problem on the FE.
I'm leaning toward the first one, but it's only a guess, I haven't done any investigating myself.
Let's leave this External for now and wait for proposals

Copy link

melvin-bot bot commented Jan 24, 2024

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

@joekaufmanexpensify
Copy link
Contributor

Sounds good!

@melvin-bot melvin-bot bot added the Overdue label Jan 29, 2024
@eVoloshchak
Copy link
Contributor

Not overdue, waiting for proposals

@melvin-bot melvin-bot bot removed the Overdue label Jan 29, 2024
@joekaufmanexpensify
Copy link
Contributor

I will bring this one to slack to solicit proposals if nothing soon

@joekaufmanexpensify
Copy link
Contributor

Going to look at which project this fits into tomorrow

Copy link

melvin-bot bot commented Jan 31, 2024

@eVoloshchak @joekaufmanexpensify this issue was created 2 weeks ago. Are we close to approving a proposal? If not, what's blocking us from getting this issue assigned? Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

Copy link

melvin-bot bot commented Jan 31, 2024

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

@melvin-bot melvin-bot bot added the Overdue label Feb 2, 2024
@joekaufmanexpensify
Copy link
Contributor

Hmm, I followed the exact reproduction steps listed above, and could not reproduce. Specifically, I:

  1. Logged into [email protected], and created two manual IOUs with [email protected].
  2. Then, I did a scanned split with [email protected], [email protected], and [email protected].
  3. Then, I did a manual split with [email protected], [email protected], and [email protected].
  4. When I go back to the DM between [email protected] and [email protected], I see all 4 requests combined into one report.
image image image

@melvin-bot melvin-bot bot removed the Overdue label Feb 2, 2024
@joekaufmanexpensify
Copy link
Contributor

Going to close this one for now, as it doesn't seem to be consistently reproducible. If there are other steps that can be used to consistently reproduce this, let me know, and happy to investigate further!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 External Added to denote the issue can be worked on by a contributor Help Wanted Apply this label when an issue is open to proposals by contributors
Projects
None yet
Development

No branches or pull requests

4 participants