Deploy Checklist: New Expensify 2024-01-18

[github-actions]

Release Version: 1.4.27-1
Compare Changes: production...staging

This release contains changes from the following pull requests:

• [TS migration] Migrate 'MoneyReportHeader.js' component to TypeScript #33570
• Fix tooltip doesn't show after closing the emoji picker #33690
• [TS migration] Migrate 'Policy.js' lib to TypeScript #33691
• [TS migration] Migrate KYCWall component #33714
• Create Cancel Payment command (again) #33836
• Delete docs/articles/expensify-classic/billing-and-subscriptions/Free… #33899
• [TS migration] Migrate 'SelectionList' component to TypeScript #34008
• Display description as HTML in money request preview #34010
• Add overflow menu to mini context menu #34031
• Connect Bank Account Redirection Fix #34117
• fix: Red dot remains after error is cleared #34125
• [TS migration] Migrate 'KeyboardShortcuts' page to TypeScript #34224
• [TS migration] Migrate 'AddressSearch' component to TypeScript #34231
• prevent offline navigation on money request report deletion #34320
• Wallet - Fix the errors button is non-functional in Additional details #34332
• [TS migration] Migrate 'AutoEmailLink.js' component to TypeScript #34333
• hide partial merchant name #34359
• Fix isWorkspaceMemberLeavingWorkspaceRoom condition for threads #34461
• [No QA] Fix wording regarding test accounts #34582
• Fix a new group is always created on creating a split scan request #34634
• [CP Staging] Revert "[TS migration] Migrate 'SelectionList' component to TypeScript" #34733

Deploy Blockers:

• [HOLD for payment 2024-01-26] [HOLD for payment 2024-01-25] Cancel payment - Canceled label in expense preview disappears after refreshing the page #34680
• [HOLD for payment 2024-01-26] [HOLD for payment 2024-01-25] Request money - System message shows negative amount briefly when paying request #34685
• [HOLD for payment 2024-02-05] [HOLD for payment 2024-01-28] [HOLD for payment 2024-01-26] Request money - Contact selection list in Request money page is missing user avatars #34725
• [HOLD for payment 2024-02-05] [HOLD for payment 2024-01-28] [HOLD for payment 2024-01-26] Request money - "Recent" and "Contacts" does not disappear when there is no relavant results #34729
• [HOLD for payment 2024-02-07] Context menu - Context menu opens in LHN when navigating via Tab and Enter key #34739
• Web - "Failed to delete contact method" appears when user remove contact method #34758
• [MEDIUM] Backwards Compatibility: "Billable no longer valid" appears in Manual but not Scan request when disabled #34765

Deployer verifications:

• I checked the App Timing Dashboard and verified this release does not cause a noticeable performance regression.
• I checked Firebase Crashlytics and verified that this release does not introduce any new crashes. More detailed instructions on this verification can be found here.
• I checked GitHub Status and verified there is no reported incident with Actions.

cc @Expensify/applauseleads

[OSBotify]

🚀 All staging deploys are complete, @Expensify/applauseleads please begin QA on version https://github.com/Expensify/App/releases/tag/1.4.27-0 🚀

[Julesssss]

Checking off #34725 & #34729 as fixed with this revert PR. Tests will be confirmed during the testing of #34733

[kbecciv]

TR is 30% left

#33691 - pending validation in IOS app
#34117 - pending validation in IOS app and Web
#34125 - pending validation in IOS app
#34231 is failing #34726, repro in prod, checking off
#34332 - pending validation in IOS app
#34333 - pending validation in Desktop
#34733 - pending validation in Desktop

[mvtglobally]

Regression is completed

PR #34125 is failing #34758

[thienlnam]

Checklist is clear - going to kick it off!

[thienlnam]

There's a couple crashes which seem to be affecting a decent amount of users

MainActivity.onCreate
This issue has 57 crash events affecting 33 users and is impacting the latest version of staging... Version 1.4.27-1

ReactNativeBlobUtilReq.run
This issue has 32 crash events affecting 9 users
This one is probably fine as it is not happening in the latest version

[thienlnam]

Digging deeper into the MainActivity.onCreate

Appears this is only happening on Android the OnePlus8Pro / One phones

couldn't find DSO to load: libhermes.so caused by: couldn't find DSO to load: libjsi.so caused by: couldn't find DSO to load: libfolly_runtime.so caused by: couldn't find DSO to load: libglog.so caused by: couldn't find DSO to load: libc++_shared.so caused by: dlopen failed: "/data/data/com.expensify.chat/lib-3/libc++_shared.so" is for EM_AARCH64 (183) instead of EM_X86_64 (62) result: 0 result: 0 result: 0 result: 0 result: 0

Looks like this has happened before. However, the proposed fix which is adding com.facebook.soloader:soloader to RN build.gradle has not changed facebook/react-native#29528 (comment)

Turns out it still exists https://github.com/Expensify/react-native/blob/main/ReactAndroid/hermes-engine/build.gradle#L202

[thienlnam]

Considering this is only impacting a single device as we can see - I think it's fine to continue deploy

[thienlnam]