Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Tracking] [Wave Collect] [Quick Action] NewDot: Quick Action Button #34802

Closed
31 of 33 tasks
trjExpensify opened this issue Jan 19, 2024 · 74 comments
Closed
31 of 33 tasks
Assignees
Labels
Daily KSv2 NewFeature Something to build that is a new item.

Comments

@trjExpensify
Copy link
Contributor

trjExpensify commented Jan 19, 2024

Design Doc

Proposal

WN
Strategy: We’re migrating customers to our new superapp where an abundance of choice and feature discovery is at the forefront to encourage them to “land and expand” across a growing number of use cases. That said, it’s crucial that we maintain the streamlined usability our existing customers know and love. Getting the balance right is important for both the success of reunification, and the long term usability of our superapp.

Problem: We’ve over indexed Global Create to optimise for feature discovery, at the expense of our core use cases. Put plainly, it takes more steps to scan a receipt in NewDot than it does on the OldApp. This is important to address now as migration plans are in progress, to avoid the “first look” of our new app being one that adds more time and effort to perform an action taken a thousand times before, increasing the likelihood to return to Classic. Needless to say, this is already coming up with our employees as early adopters.

Solution: Add a quick action button to the bottom of global create. The button will record the last action you took (i.e Request Money > Scan) and the destination for it (i.e To: Duraflame, Inc.). When used for submitting receipts to a workspace like this example, we’ll also stop showing the confirmation page to enter additional expense details unless the workspace has required categories or tags for coding, a la “fire and forget” in OldApp.

Tasks

  • Post Proposal (full Problem/Solution statement) in #whatsnext
  • Wait at least one full business day, and until the post has a majority (2/3) of positive reactions (👍)
  • Paste Proposal in the space above with a link to the Slack thread
  • Email [email protected] and paste in the Proposal
  • Fill out the High-level overview of the problem, Timeline, and Terminology sections of the Design Doc
  • Email [email protected] (continue the same email chain as before) with the link to your Design Doc
  • Host a pre-design meeting (example) in #expensify-open-source to discuss any necessary details in public before filling out the High-level of proposed solution section.
  • Fill out the High-level of proposed solution section
  • Email [email protected] again with links to the doc and pre-design conversation in Slack
  • Add the DesignDocReview label to get the High-level of proposed solution section reviewed
  • Respond to any questions or concerns and bring up blockers in Slack to get a consensus if necessary
  • Confirm that the doc has the minimum necessary number of reviews before proceeding
  • Host another pre-design meeting in #expensify-open-source to ask for engineering feedback on the technical solution.
  • Fill out the Detailed implementation of the solution and related sections.
  • Re-add the DesignDocReview label to this issue
  • Respond to any questions or concerns and bring up blockers in Slack to get consensus if necessary
  • Confirm that the doc has the minimum necessary number of reviews before proceeding
  • Email [email protected] one last time to let them know the Design Doc is moving into the implementation phase
  • Implement the changes
  • Add regression tests so that QA can test your feature with every deploy (instructions) (GH)
  • Send out a follow up email to [email protected] once everything has been implemented and do a Project Wrap-Up retrospective that provides:
    • Summary of what we accomplished with this project
    • What went well?
    • What could we have done better?
    • What did we learn?

Implementation Issues

@trjExpensify trjExpensify added Weekly KSv2 Planning Changes still in the thought process NewFeature Something to build that is a new item. labels Jan 19, 2024
@trjExpensify trjExpensify self-assigned this Jan 19, 2024
Copy link

melvin-bot bot commented Jan 19, 2024

Current assignee @trjExpensify is eligible for the NewFeature assigner, not assigning anyone new.

@dylanexpensify dylanexpensify moved this to Release 3: Migration for All in [#whatsnext] Wave 05 - Deprecate Free Jan 19, 2024
@melvin-bot melvin-bot bot added the Overdue label Jan 29, 2024
@trjExpensify
Copy link
Contributor Author

Pre-design here. Threads are dying down, plan to get the HL doc together by the start of next week.

@melvin-bot melvin-bot bot removed the Overdue label Jan 29, 2024
@melvin-bot melvin-bot bot added the Overdue label Feb 7, 2024
@trjExpensify
Copy link
Contributor Author

plan to get the HL doc together by the start of next week.

Alrighty, ideal nav ended up being ready to launch last week, so it knocked my timeline out by a couple of days. But the HL is now out for review.

Copy link

melvin-bot bot commented Feb 7, 2024

👋 Hello Generalist Track Team - you have been assigned to review this High Level Design Doc. Check out this Stack Overflow for some tips on reviewing a design doc. Once you are done, simply press the Add "Reviewed Doc" comment button in the right hand side K2 panel or follow these instructions.


@mountiny
Copy link
Contributor

mountiny commented Feb 8, 2024

I have read and reviewed this Design Doc!

1 similar comment
@jliexpensify
Copy link
Contributor

I have read and reviewed this Design Doc!

@Gonals Gonals added Reviewing Has a PR in review and removed Reviewing Has a PR in review labels Feb 8, 2024
@melvin-bot melvin-bot bot added the Overdue label May 27, 2024
Copy link

melvin-bot bot commented May 27, 2024

@trjExpensify, @Gonals Whoops! This issue is 2 days overdue. Let's get this updated quick!

@trjExpensify
Copy link
Contributor Author

Checked-in on the tooltip.

@melvin-bot melvin-bot bot added Overdue and removed Overdue labels May 28, 2024
Copy link

melvin-bot bot commented May 31, 2024

@trjExpensify, @Gonals Whoops! This issue is 2 days overdue. Let's get this updated quick!

@trjExpensify
Copy link
Contributor Author

Conflicts to resolve, bumped on those and resolution of this final bug in the tooltip PR.

@melvin-bot melvin-bot bot added Overdue and removed Overdue labels Jun 3, 2024
Copy link

melvin-bot bot commented Jun 7, 2024

@trjExpensify, @Gonals Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

@trjExpensify
Copy link
Contributor Author

Latest.

@melvin-bot melvin-bot bot added Overdue and removed Overdue labels Jun 10, 2024
@trjExpensify
Copy link
Contributor Author

Latest.

@melvin-bot melvin-bot bot added Overdue and removed Overdue labels Jun 13, 2024
Copy link

melvin-bot bot commented Jun 18, 2024

@trjExpensify, @Gonals Eep! 4 days overdue now. Issues have feelings too...

@trjExpensify
Copy link
Contributor Author

Latest. Over to Rocio and Alberto and we can finally get that merged. 🙏

@melvin-bot melvin-bot bot added Overdue and removed Overdue labels Jun 18, 2024
@trjExpensify
Copy link
Contributor Author

PR has been merged! @Gonals, all set to send the wrap-up for the project and close this out. :)

@melvin-bot melvin-bot bot added Overdue and removed Overdue labels Jun 24, 2024
@trjExpensify
Copy link
Contributor Author

Wrap-up sent. Couple of days to go on the regression period for the tooltip polish, and then we'll close this.

@melvin-bot melvin-bot bot added Overdue and removed Overdue labels Jun 26, 2024
@trjExpensify
Copy link
Contributor Author

Regression period over, closing!

@melvin-bot melvin-bot bot removed the Overdue label Jun 28, 2024
@github-project-automation github-project-automation bot moved this from Tracking issues to Done in [#whatsnext] #wave-collect Jun 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Daily KSv2 NewFeature Something to build that is a new item.
Projects
No open projects
Development

No branches or pull requests