[HOLD] - [$500] Violation - Expense violation message is missing from Employee's view and no amount

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: 1.4.28-0
Reproducible in staging?: Y
Reproducible in production?: Y
Issue reported by: Applause - Internal Team

Issue found when executing PR #31448

Action Performed:

Precondition:

• Admin and employee are part of Control workspace in Old Dot
• The Control workspace has set up Max Expense Amount violation

1. [Employee] Go to workspace chat
2. [Employee] Create a manual request that exceeds the maximum amount
3. [Employee] Submit the request
4. [Employee] Go to request details page
5. [Employee] Note that there is no "Expense exceeds auto approval limit of" message
6. [Admin] Go to the request details page

Expected Result:

In Step 5, "Expense exceeds auto approval limit of" message will be present from Employee's view
In Step 6, "Expense exceeds auto approval limit of" message will be complete with the maximum amount allowed for the violation

Actual Result:

✅ In Step 5, "Expense exceeds auto approval limit of" message is not present from Employee's view
In Step 6, "Expense exceeds auto approval limit of" message is missing maximum amount allowed for the violation

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6347711_1705676185324.20240119_202533.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~019aaa92dcff420820
• Upwork Job ID: 1748367750109818880
• Last Price Increase: 2024-01-19

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~019aaa92dcff420820

[melvin-bot]

Triggered auto assignment to @jliexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @situchan (External)

[lanitochka17]

We think that this bug might be related to #wave6-collect-submitters
CC @greg-schroeder

[cead22]

I'm taking this one, to check if the fix is on the backend first.

In Step 5, "Expense exceeds auto approval limit of" message will be present from Employee's view

For context: we don't show this to the person requesting money because they can't do anything about this violation

[cead22]

Planning on triaging this today

[cead22]

After testing this while on this branch https://github.com/Expensify/App/pull/34303/files, I think this issue will be fixed by that PR, so putting it on HOLD for now

[melvin-bot]

@cead22 Eep! 4 days overdue now. Issues have feelings too...

[cead22]

On hold, not overdue

[melvin-bot]

@cead22 Huh... This is 4 days overdue. Who can take care of this?

[melvin-bot]

@cead22 6 days overdue. This is scarier than being forced to listen to Vogon poetry!

[JmillsExpensify]

Linked issue still hasn't merged, though it looks very close.

[cead22]

PR got merged but hasn't been deployed yet

[cead22]

This should be fixed now