[$500] Contact Method - The profile avatar changes when the default contact email is updated

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: 1.4.28-0
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:

Action Performed:

1. Go to Settings > Profile > Contact Method > Add Contact Method
2. Change the contact method to the newly added one and observe the profile avatar; it changes

Expected Result:

The profile avatar should not change when the default contact email is updated

Actual Result:

The profile avatar changes when the default contact email is updated

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6347761_1705678905632.avatar.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~0139065cb9535c6083
• Upwork Job ID: 1748378817917579264
• Last Price Increase: 2024-01-19

[melvin-bot]

Triggered auto assignment to @sakluger (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~0139065cb9535c6083

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @jjcoffee (External)

[barros001]

This seems to be a BE issue. When the default contact method is updated the backend returns a new avatar:

        {
            "key": "personalDetailsList",
            "onyxMethod": "merge",
            "value": {
                "15912050": {
                    "accountID": 15912050,
                    "avatar": "https://d2k5nsl2zxldvw.cloudfront.net/images/avatars/default-avatar_18.png",
                    "displayName": "[email protected]",
                    "firstName": "",
                    "lastName": "",
                    "login": "[email protected]",
                    "payPalMeAddress": "",
                    "phoneNumber": "",
                    "pronouns": "",
                    "status": null,
                    "timezone": {
                        "automatic": true,
                        "selected": "America/New_York"
                    },
                    "validated": true
                }
            }
        }

vs:

        {
            "key": "personalDetailsList",
            "onyxMethod": "merge",
            "value": {
                "15912050": {
                    "accountID": 15912050,
                    "avatar": "https://d2k5nsl2zxldvw.cloudfront.net/images/avatars/default-avatar_12.png",
                    "displayName": "[email protected]",
                    "firstName": "",
                    "lastName": "",
                    "login": "[email protected]",
                    "payPalMeAddress": "",
                    "phoneNumber": "",
                    "pronouns": "",
                    "status": null,
                    "timezone": {
                        "automatic": true,
                        "selected": "America/New_York"
                    },
                    "validated": true
                }
            }
        }

The account ID remains the same but the avatar changes, likely because behind the scenes there are two separate accounts and the backend is failing to maintain the avatar fixed, similarly to how accountID is handled.

[cjoshidev]

Agree with @barros001

I have found out that if the case user does have an image it is not causing the change.

And also there is one more bug if the user does have an image attached to the email and if the other email doesn't have any image.

Removing the email with the image is not removing the image. It will be shown for other email as well

[melvin-bot]

📣 @cjoshi-zeals! 📣
Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork.
Please follow these steps:

1. Make sure you've read and understood the contributing guidelines.
2. Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
3. Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
4. Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details.
   
   Format:

Contributor details
Your Expensify account email: <REPLACE EMAIL HERE>
Upwork Profile Link: <REPLACE LINK HERE>

[cjoshidev]

Contributor details
Your Expensify account email: [email protected]
Upwork Profile Link: https://www.upwork.com/freelancers/~01c8c1ca43cddf7d39

[melvin-bot]

⚠️ Invalid email. Please make sure to create an Expensify account with this email first here.

[cjoshidev]

Contributor details
Your Expensify account email: [email protected]
Upwork Profile Link: https://www.upwork.com/freelancers/~01c8c1ca43cddf7d39

[melvin-bot]

⚠️ Missing/invalid email or upwork profile link. Please make sure you add both your Expensify email and Upwork profile link in the format specified.

[cjoshidev]

Contributor details
Your Expensify account email: [email protected]
Upwork Profile Link: https://www.upwork.com/freelancers/~01c8c1ca43cddf7d39

[melvin-bot]

✅ Contributor details stored successfully. Thank you for contributing to Expensify!

[jjcoffee]

Yeah I agree with @barros001. This is arguably a regression from #32090 where we switched to using the avatar returned by the BE instead of generating it from hashing the accountID. We'd just need to change the BE to generate the avatar from the accountID.

@sakluger can you apply the Engineering tag and make this internal?

[melvin-bot]

Current assignee @jjcoffee is eligible for the Internal assigner, not assigning anyone new.

[melvin-bot]

Auto-assigning issues to engineers is no longer supported. If you think this issue should receive engineering attention, please raise it in #whatsnext, and if it gets enough 👍, then please find a volunteer.

[sakluger]

Thanks @barros001 and @jjcoffee. We aren't currently using the engineering auto-assigner, but I added to the #vip-vsb project board and will ask for a volunteer.

[melvin-bot]

@rlinoz, @sakluger, @jjcoffee Whoops! This issue is 2 days overdue. Let's get this updated quick!

[rlinoz]

I will try to open a PR to fix this today.

[rlinoz]

Waiting for a deploy to put the last PR for review.

[melvin-bot]

@rlinoz, @sakluger, @jjcoffee Whoops! This issue is 2 days overdue. Let's get this updated quick!

[rlinoz]

Oh this can actually be closed 😄