[HOLD for payment 2024-02-07] [$500] Thread - "Join" button appear when user Leave thread #34820

lanitochka17 · 2024-01-19T17:32:21Z

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

Version Number: 1.4.28-0
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:

Action Performed:

Navigate to a conversation
Start a thread and send some messages
Click on the three dot menu and hit "Leave thread"

Expected Result:

User should navigate back to the parent conversation with no visual issues

Actual Result:

"Join" button appear when user Leave thread

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

Screenshots/Videos

Add any screenshot/video evidence

Bug6347846_1705683544658.az_recorder_20240119_170154.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~012a09bc563f2546c1
Upwork Job ID: 1748398010896543744
Last Price Increase: 2024-01-19
Automatic offers:

s77rt | Reviewer | 28120092
DylanDylann | Contributor | 28120093

melvin-bot · 2024-01-19T17:32:25Z

Job added to Upwork: https://www.upwork.com/jobs/~012a09bc563f2546c1

melvin-bot · 2024-01-19T17:32:26Z

Triggered auto assignment to @lschurr (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

melvin-bot · 2024-01-19T17:32:30Z

Triggered auto assignment to Contributor-plus team member for initial proposal review - @s77rt (External)

lanitochka17 · 2024-01-19T17:34:20Z

We think that this bug might be related to #vip-vsb.
CC @quinthar

ishpaul777 · 2024-01-19T17:47:43Z

Proposal

Please re-state the problem that we are trying to solve in this issue.

"Join" button appear when user Leave thread

What is the root cause of that problem?

Below are the conditions that need to be met to show the join button, technically when user click leave thread all conditions meet and join button appears while we are navigating the user to the parent chat.

App/src/pages/home/HeaderView.js

Lines 155 to 156 in 56fb814

    
           const canJoin = canJoinOrLeave && !isWhisperAction && props.report.notificationPreference === CONST.REPORT.NOTIFICATION_PREFERENCE.HIDDEN; 
        
           const canLeave = canJoinOrLeave && ((isChatThread && props.report.notificationPreference.length) || isUserCreatedPolicyRoom || canLeaveRoom);

What changes do you think we should make in order to solve the problem?

We need to check if navigation is in progress, we can use useIsFocused hook to check if screen is focused, so join is not visible until user is redirected to the parent chat

What alternative solutions did you explore? (Optional)

Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

abzokhattab · 2024-01-19T17:52:41Z

Proposal

Please re-state the problem that we are trying to solve in this issue.

"Join" button appear when user Leave thread

What is the root cause of that problem?

when leaving a room we change the reportID optimistically to null

App/src/libs/actions/Report.ts

Line 2095 in 6c72ef8

reportID: null,

and the join button is shown based on this condition:

App/src/pages/home/HeaderView.js

Lines 156 to 157 in 7b1035c

    
           const canJoinOrLeave = (isChatThread && !isEmptyChat) || isUserCreatedPolicyRoom || canLeaveRoom; 
        
           const canJoin = canJoinOrLeave && !isWhisperAction && props.report.notificationPreference === CONST.REPORT.NOTIFICATION_PREFERENCE.HIDDEN;

so when leaving a thread the isThreadChat falsely returns true while transitioning resulting in showing the join button.

What changes do you think we should make in order to solve the problem?

we can pass the isReportReadyForDisplay from the ReportScreen component as a prop with default value as false then update the condition that is responsible for showing the header tooltip:

App/src/pages/home/HeaderView.js

Line 309 in 7b1035c

{canJoin && !isSmallScreenWidth && joinButton}

to:

{canJoin && !isSmallScreenWidth && joinButton && props.isReportReadyForDisplay}

alternativly

we can fix the isThreadChat function since it shouldn't return true for a report the user left, to fix it we need to fix the underlying isThread
function to check if the current reportID exits:

    return Boolean(report?.reportID && report?.parentReportID && report?.parentReportActionID);

paultsimura · 2024-01-19T17:53:39Z

Proposal

Please re-state the problem that we are trying to solve in this issue.

The navigation on leaving Thread is delayed

What is the root cause of that problem?

First of all, I'd like to stress out that the issue is not only with the "Join" button but with the skeleton view as well.
This is happening because we do not explicitly pass the navigation command on leaving the thread in Report.leaveRoom() as opposed to the leaving room:

App/src/libs/actions/Report.ts

Lines 2169 to 2177 in 56fb814

    
           if (isWorkspaceMemberLeavingWorkspaceRoom) { 
        
               const participantAccountIDs = PersonalDetailsUtils.getAccountIDsByLogins([CONST.EMAIL.CONCIERGE]); 
        
               const chat = ReportUtils.getChatByParticipants(participantAccountIDs); 
        
               if (chat?.reportID) { 
        
                   // We should call Navigation.goBack to pop the current route first before navigating to Concierge. 
        
                   Navigation.goBack(ROUTES.HOME); 
        
                   Navigation.navigate(ROUTES.REPORT_WITH_ID.getRoute(chat.reportID)); 
        
               } 
        
           }

We wait until it's removed from Onyx, and then the user gets navigated automatically because the thread report no longer exists. And this moment between the report being deleted and the user being navigated is causing the behavior in this issue.

What changes do you think we should make in order to solve the problem?

We need to explicitly navigate the user to the parent report upon leaving the thread:

if (isChatThread(report)) {
    Navigation.goBack(ROUTES.HOME);
    Navigation.navigate(ROUTES.REPORT_WITH_ID.getRoute(report.parentReportID));
} else if (isWorkspaceMemberLeavingWorkspaceRoom) {
        const participantAccountIDs = PersonalDetailsUtils.getAccountIDsByLogins([CONST.EMAIL.CONCIERGE]);
        const chat = ReportUtils.getChatByParticipants(participantAccountIDs);
        if (chat?.reportID) {
            // We should call Navigation.goBack to pop the current route first before navigating to Concierge.
            Navigation.goBack(ROUTES.HOME);
            Navigation.navigate(ROUTES.REPORT_WITH_ID.getRoute(chat.reportID));
        }
}

Result:

Screen.Recording.2024-01-19.at.19.00.15.mov

What alternative solutions did you explore? (Optional)

DylanDylann · 2024-01-20T05:33:42Z

Dupe of #31220

s77rt · 2024-01-20T22:32:45Z

@ishpaul777 Thanks for the proposal. Your RCA makes sense however the solution is a workaround. I don't see how the screen being focused or not should control the visibility of the join/leave buttons.

s77rt · 2024-01-20T22:36:04Z

@abzokhattab Your proposal does not follow the template, it's incomplete (missing a clear RCA).

s77rt · 2024-01-20T22:46:26Z

@paultsimura Thanks for the proposal. Regarding your RCA:

This is happening because we do not explicitly pass the navigation command on leaving the thread

This is not exactly true. The bug can be reproduced whether we navigate explicitly or not. This is because both navigation and Onyx updates are async. Doing one after the other does not guarantee any order.

s77rt · 2024-01-20T22:57:07Z

@DylanDylann I agree this could have been handled in the linked issue. I checked your proposal. The RCA is correct. The suggested solution does not fix the problem but the alternative solution does. Except that we should check the existence of the report id instead of the "emptiness" of the report. This is because optimistically the report would still be there.

Please update/copy the proposal from other issue and tag me once done

abzokhattab · 2024-01-21T01:11:20Z

@s77rt Thank you, yeah you are correct i forgot to add the RCA, I have updated the RCA and added a second solution that addresses fixing the isThread function which i believe is the actual root cause.

DylanDylann · 2024-01-21T03:40:35Z

@s77rt I updated the proposal

s77rt · 2024-01-21T18:22:25Z

@abzokhattab Thanks for the update. The RCA makes sense. As for the solution I don't think we should use isReportReadyForDisplay as we already have an inner variable (isLoading) for the loading state of the header. Also the isThread function is not necessary incorrect.

s77rt · 2024-01-21T18:22:36Z

@DylanDylann Can you please post the proposal here

DylanDylann · 2024-01-21T18:34:15Z

Proposal

Please re-state the problem that we are trying to solve in this issue.

Thread - "Join" button appear when user Leave thread

What is the root cause of that problem?

After clicking on "Leave thread", we set the optimistic data for this thread as below:

App/src/libs/actions/Report.ts

Lines 2103 to 2118 in 52adf77

    
           const optimisticData: OnyxUpdate[] = [ 
        
               { 
        
                   onyxMethod: Onyx.METHOD.MERGE, 
        
                   key: `${ONYXKEYS.COLLECTION.REPORT}${reportID}`, 
        
                   value: isWorkspaceMemberLeavingWorkspaceRoom 
        
                       ? { 
        
                             notificationPreference: CONST.REPORT.NOTIFICATION_PREFERENCE.HIDDEN, 
        
                         } 
        
                       : { 
        
                             reportID: null, 
        
                             stateNum: CONST.REPORT.STATE_NUM.APPROVED, 
        
                             statusNum: CONST.REPORT.STATUS_NUM.CLOSED, 
        
                             notificationPreference: CONST.REPORT.NOTIFICATION_PREFERENCE.HIDDEN, 
        
                         }, 
        
               }, 
        
           ];

Then we use this useEffect to handle case onyxReportID: undefined | null. It will navigate the user to the previous report.
When the above useEffect executing, it will display the above optimistic report for a while, which leads to the bug

What changes do you think we should make in order to solve the problem?

We can hide the Join button (and the HeaderView) once the report.reportID is empty as we did in other screens.
To hide the Join button, we can update:

App/src/pages/home/HeaderView.js

Line 155 in 52adf77

const canJoin = canJoinOrLeave && !isWhisperAction && props.report.notificationPreference === CONST.REPORT.NOTIFICATION_PREFERENCE.HIDDEN;

to

   const canJoin = props.report.reportID && canJoinOrLeave && !isWhisperAction && props.report.notificationPreference === CONST.REPORT.NOTIFICATION_PREFERENCE.HIDDEN;

If we want to hide the header as well, update:

App/src/pages/home/HeaderView.js

Line 217 in 52adf77

const isLoading = !props.report || !title;

to:

    const isLoading = !props.report.reportID || !props.report || !title;

What alternative solutions did you explore? (Optional)

NA

DylanDylann · 2024-01-21T18:41:10Z

@s77rt I just add the alternative solution in here based on your comment here that the main solution does not work

s77rt · 2024-01-22T14:29:30Z

@DylanDylann Thank you. Let's go with updating the isLoading variable to fix all the header content.

🎀 👀 🎀 C+ reviewed
Link to proposal

melvin-bot · 2024-01-22T14:29:36Z

Triggered auto assignment to @neil-marcellini, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

neil-marcellini · 2024-01-24T19:47:04Z

@DylanDylann Thank you. Let's go with updating the isLoading variable to fix all the header content.

🎀 👀 🎀 C+ reviewed Link to proposal

Looks pretty good. Please go ahead and get started.

melvin-bot · 2024-01-24T19:47:19Z

📣 @s77rt 🎉 An offer has been automatically sent to your Upwork account for the Reviewer role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job

melvin-bot · 2024-01-24T19:47:23Z

📣 @DylanDylann 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

DylanDylann · 2024-01-26T00:43:01Z

@s77rt PR #35202 is ready to review

melvin-bot · 2024-01-31T16:27:23Z

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

melvin-bot · 2024-01-31T22:39:24Z

Reviewing label has been removed, please complete the "BugZero Checklist".

melvin-bot · 2024-01-31T22:39:27Z

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.34-1 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

Fix/34820: Hide join button once leaving #35202

If no regressions arise, payment will be issued on 2024-02-07. 🎊

For reference, here are some details about the assignees on this issue:

@s77rt requires payment automatic offer (Reviewer)
@DylanDylann requires payment automatic offer (Contributor)

melvin-bot · 2024-01-31T22:39:28Z

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

[@s77rt / @DylanDylann] The PR that introduced the bug has been identified. Link to the PR:
[@s77rt / @DylanDylann] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
[@s77rt / @DylanDylann] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
[@s77rt / @DylanDylann] Determine if we should create a regression test for this bug.
[@s77rt / @DylanDylann] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
[@lschurr] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

s77rt · 2024-02-02T21:00:17Z

The PR that introduced the bug has been identified: Add ReportHeaderSkeletonView to ReportScreen #30367 and Show join button in the chat header #33791
The offending PR has been commented on: Add ReportHeaderSkeletonView to ReportScreen #30367 (comment) and Show join button in the chat header #33791 (comment)
A discussion in #expensify-bugs has been started: Not needed
Determine if we should create a regression test for this bug: No, I think this is a minor visual bug

lschurr · 2024-02-07T16:58:48Z

Payment summary:

Contributor: @DylanDylann $500 paid in Upwork
Contributor+: @s77rt $500 paid in Upwork

lschurr · 2024-02-07T17:00:29Z

This is complete.

lanitochka17 added External Added to denote the issue can be worked on by a contributor Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. labels Jan 19, 2024

melvin-bot bot changed the title ~~Thread - "Join" button appear when user Leave thread~~ [$500] Thread - "Join" button appear when user Leave thread Jan 19, 2024

melvin-bot bot assigned lschurr Jan 19, 2024

melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Jan 19, 2024

melvin-bot bot assigned s77rt Jan 19, 2024

melvin-bot bot assigned neil-marcellini Jan 22, 2024

neil-marcellini assigned DylanDylann Jan 24, 2024

melvin-bot bot removed the Help Wanted Apply this label when an issue is open to proposals by contributors label Jan 24, 2024

DylanDylann mentioned this issue Jan 25, 2024

Fix/34820: Hide join button once leaving #35202

Merged

50 tasks

melvin-bot bot added Reviewing Has a PR in review Weekly KSv2 and removed Daily KSv2 labels Jan 25, 2024

paultsimura mentioned this issue Jan 31, 2024

[$500] Header of the chat is loading when re-join the thread Offline #35487

Closed

6 tasks

melvin-bot bot added Weekly KSv2 Awaiting Payment Auto-added when associated PR is deployed to production and removed Weekly KSv2 labels Jan 31, 2024

melvin-bot bot changed the title ~~[$500] Thread - "Join" button appear when user Leave thread~~ [HOLD for payment 2024-02-07] [$500] Thread - "Join" button appear when user Leave thread Jan 31, 2024

melvin-bot bot removed the Reviewing Has a PR in review label Jan 31, 2024

This was referenced Feb 2, 2024

Add ReportHeaderSkeletonView to ReportScreen #30367

Merged

Show join button in the chat header #33791

Merged

melvin-bot bot added Daily KSv2 and removed Weekly KSv2 labels Feb 7, 2024

lschurr closed this as completed Feb 7, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[HOLD for payment 2024-02-07] [$500] Thread - "Join" button appear when user Leave thread #34820

[HOLD for payment 2024-02-07] [$500] Thread - "Join" button appear when user Leave thread #34820

lanitochka17 commented Jan 19, 2024 •

edited by melvin-bot bot

Loading

melvin-bot bot commented Jan 19, 2024

melvin-bot bot commented Jan 19, 2024

melvin-bot bot commented Jan 19, 2024

lanitochka17 commented Jan 19, 2024

ishpaul777 commented Jan 19, 2024

abzokhattab commented Jan 19, 2024 •

edited

Loading

paultsimura commented Jan 19, 2024 •

edited

Loading

DylanDylann commented Jan 20, 2024 •

edited

Loading

s77rt commented Jan 20, 2024

s77rt commented Jan 20, 2024

s77rt commented Jan 20, 2024

s77rt commented Jan 20, 2024

abzokhattab commented Jan 21, 2024 •

edited

Loading

DylanDylann commented Jan 21, 2024

s77rt commented Jan 21, 2024

s77rt commented Jan 21, 2024

DylanDylann commented Jan 21, 2024 •

edited

Loading

DylanDylann commented Jan 21, 2024 •

edited

Loading

s77rt commented Jan 22, 2024

melvin-bot bot commented Jan 22, 2024

neil-marcellini commented Jan 24, 2024

melvin-bot bot commented Jan 24, 2024

melvin-bot bot commented Jan 24, 2024

DylanDylann commented Jan 26, 2024

melvin-bot bot commented Jan 31, 2024

melvin-bot bot commented Jan 31, 2024

melvin-bot bot commented Jan 31, 2024

melvin-bot bot commented Jan 31, 2024

s77rt commented Feb 2, 2024

lschurr commented Feb 7, 2024

lschurr commented Feb 7, 2024

[HOLD for payment 2024-02-07] [$500] Thread - "Join" button appear when user Leave thread #34820

[HOLD for payment 2024-02-07] [$500] Thread - "Join" button appear when user Leave thread #34820

Comments

lanitochka17 commented Jan 19, 2024 • edited by melvin-bot bot Loading

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Screenshots/Videos

melvin-bot bot commented Jan 19, 2024

melvin-bot bot commented Jan 19, 2024

melvin-bot bot commented Jan 19, 2024

lanitochka17 commented Jan 19, 2024

ishpaul777 commented Jan 19, 2024

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What alternative solutions did you explore? (Optional)

abzokhattab commented Jan 19, 2024 • edited Loading

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

alternativly

paultsimura commented Jan 19, 2024 • edited Loading

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

Result:

What alternative solutions did you explore? (Optional)

DylanDylann commented Jan 20, 2024 • edited Loading

s77rt commented Jan 20, 2024

s77rt commented Jan 20, 2024

s77rt commented Jan 20, 2024

s77rt commented Jan 20, 2024

abzokhattab commented Jan 21, 2024 • edited Loading

DylanDylann commented Jan 21, 2024

s77rt commented Jan 21, 2024

s77rt commented Jan 21, 2024

DylanDylann commented Jan 21, 2024 • edited Loading

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What alternative solutions did you explore? (Optional)

DylanDylann commented Jan 21, 2024 • edited Loading

s77rt commented Jan 22, 2024

melvin-bot bot commented Jan 22, 2024

neil-marcellini commented Jan 24, 2024

melvin-bot bot commented Jan 24, 2024

melvin-bot bot commented Jan 24, 2024

DylanDylann commented Jan 26, 2024

melvin-bot bot commented Jan 31, 2024

melvin-bot bot commented Jan 31, 2024

melvin-bot bot commented Jan 31, 2024

melvin-bot bot commented Jan 31, 2024

s77rt commented Feb 2, 2024

lschurr commented Feb 7, 2024

lschurr commented Feb 7, 2024

lanitochka17 commented Jan 19, 2024 •

edited by melvin-bot bot

Loading

abzokhattab commented Jan 19, 2024 •

edited

Loading

paultsimura commented Jan 19, 2024 •

edited

Loading

DylanDylann commented Jan 20, 2024 •

edited

Loading

abzokhattab commented Jan 21, 2024 •

edited

Loading

DylanDylann commented Jan 21, 2024 •

edited

Loading

DylanDylann commented Jan 21, 2024 •

edited

Loading