Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[$500] The whisper to invite someone to a room is persistent #34868

Closed
2 of 6 tasks
kavimuru opened this issue Jan 22, 2024 · 8 comments
Closed
2 of 6 tasks

[$500] The whisper to invite someone to a room is persistent #34868

kavimuru opened this issue Jan 22, 2024 · 8 comments
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 External Added to denote the issue can be worked on by a contributor Help Wanted Apply this label when an issue is open to proposals by contributors

Comments

@kavimuru
Copy link

kavimuru commented Jan 22, 2024

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!


Version Number: 1.4.29-0
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @kadiealexander
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1705609789474709

Action Performed:

  1. Reply to a comment in a room, tagging someone who isn't in the reply room
  2. Click either of the "Invite them" or "Do nothing" buttons.

Expected Result:

The whisper disappears and the action you chose is taken.

Actual Result:

When clicking the "Invite them" button, the whisper disappears for a moment then reappears. When clicking "Do nothing", nothing happens and the whisper remains.

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Recording.1689.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~01dde2be0ebbf260bf
  • Upwork Job ID: 1749372415518834688
  • Last Price Increase: 2024-01-22
  • Automatic offers:
    • ishpaul777 | Contributor | 28118225
@kavimuru kavimuru added External Added to denote the issue can be worked on by a contributor Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. labels Jan 22, 2024
@melvin-bot melvin-bot bot changed the title The whisper to invite someone to a room is persistent [$500] The whisper to invite someone to a room is persistent Jan 22, 2024
Copy link

melvin-bot bot commented Jan 22, 2024

Job added to Upwork: https://www.upwork.com/jobs/~01dde2be0ebbf260bf

@ishpaul777
Copy link
Contributor

ishpaul777 commented Jan 22, 2024

I am working on it #33665 (comment), PR #34560

@trjExpensify
Copy link
Contributor

Hm.. why didn't this get assigned to someone? @jasperhuangg are you working with @ishpaul777 on it?

Copy link

melvin-bot bot commented Jan 23, 2024

📣 @ishpaul777 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

@trjExpensify trjExpensify added External Added to denote the issue can be worked on by a contributor and removed External Added to denote the issue can be worked on by a contributor labels Jan 23, 2024
@melvin-bot melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Jan 23, 2024
Copy link

melvin-bot bot commented Jan 23, 2024

Current assignee @ishpaul777 is eligible for the External assigner, not assigning anyone new.

@jasperhuangg
Copy link
Contributor

This was a regression from his earlier PR that I noted in the review after it was merged.

That's why an issue wasn't created initially.

@jasperhuangg jasperhuangg closed this as not planned Won't fix, can't repro, duplicate, stale Jan 23, 2024
@ishpaul777
Copy link
Contributor

@trjExpensify Can you Please withdraw offer made by Melv. on upwork

@trjExpensify
Copy link
Contributor

Yep, done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 External Added to denote the issue can be worked on by a contributor Help Wanted Apply this label when an issue is open to proposals by contributors
Projects
None yet
Development

No branches or pull requests

4 participants