-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Wave6] Remove links from the next steps message #34871
Comments
Triggered auto assignment to @muttmuure ( |
Ha funny @muttmuure |
Hello, Im Artem from Callstack and would like to help with this issue! |
Job added to Upwork: https://www.upwork.com/jobs/~010faf9f4e9ae96068 |
Triggered auto assignment to Contributor Plus for review of internal employee PR - @rushatgabhane ( |
Hey @mountiny Here is a place in "NextStep.php" file where this link is creating. I think this should be a backend fix. |
I could do that too |
@mountiny in frontend part just The only way to remove links from the frontend is to change |
Will look tomorrow |
Did not get around at the end of the week |
Started a draft PR, I need to test it more and add automated tests too |
PR is up and in review |
I think this is done and handled by an agency. Closing |
Not sure this did not close, this should be completed no cahnges required in the App |
Problem
Coming from https://expensify.slack.com/archives/C049HHMV9SM/p1705600357375529
The next steps in the App are exact mirror of what we show in OldDot right now, however, that is not fully compatible with NewDot. Especially there can be buttons or links in the message that do not funciton as intended in NewDot leading to confusing experience.
Solution
We have already removed the buttons. Lets also make sure we do not hyper link the links in the next steps, leave them as normal text
Upwork Automation - Do Not Edit
The text was updated successfully, but these errors were encountered: