Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Wave6] Remove links from the next steps message #34871

Closed
mountiny opened this issue Jan 22, 2024 · 14 comments
Closed

[Wave6] Remove links from the next steps message #34871

mountiny opened this issue Jan 22, 2024 · 14 comments
Assignees
Labels
Internal Requires API changes or must be handled by Expensify staff NewFeature Something to build that is a new item. Reviewing Has a PR in review Weekly KSv2

Comments

@mountiny
Copy link
Contributor

mountiny commented Jan 22, 2024

Problem

Coming from https://expensify.slack.com/archives/C049HHMV9SM/p1705600357375529

The next steps in the App are exact mirror of what we show in OldDot right now, however, that is not fully compatible with NewDot. Especially there can be buttons or links in the message that do not funciton as intended in NewDot leading to confusing experience.

Solution

We have already removed the buttons. Lets also make sure we do not hyper link the links in the next steps, leave them as normal text

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~010faf9f4e9ae96068
  • Upwork Job ID: 1749392983082467328
  • Last Price Increase: 2024-01-22
@mountiny mountiny added Daily KSv2 NewFeature Something to build that is a new item. labels Jan 22, 2024
@mountiny mountiny self-assigned this Jan 22, 2024
Copy link

melvin-bot bot commented Jan 22, 2024

@melvin-bot melvin-bot bot added Weekly KSv2 and removed Daily KSv2 labels Jan 22, 2024
@mountiny
Copy link
Contributor Author

image

Ha funny @muttmuure

@waterim
Copy link
Contributor

waterim commented Jan 22, 2024

Hello, Im Artem from Callstack and would like to help with this issue!

@mountiny mountiny added the Internal Requires API changes or must be handled by Expensify staff label Jan 22, 2024
Copy link

melvin-bot bot commented Jan 22, 2024

Job added to Upwork: https://www.upwork.com/jobs/~010faf9f4e9ae96068

Copy link

melvin-bot bot commented Jan 22, 2024

Triggered auto assignment to Contributor Plus for review of internal employee PR - @rushatgabhane (Internal)

@waterim
Copy link
Contributor

waterim commented Jan 23, 2024

Hey @mountiny
This link is rendering just in component which is coming from the backend

Here is a place in "NextStep.php" file where this link is creating.
image

I think this should be a backend fix.

@mountiny
Copy link
Contributor Author

I could do that too

@waterim
Copy link
Contributor

waterim commented Jan 23, 2024

@mountiny in frontend part just <renderHTML>component is rendering with the data from backend

The only way to remove links from the frontend is to change <renderHTML> to a simple <View> element, but Im not sure what else we are passing from the backed

@mountiny
Copy link
Contributor Author

Will look tomorrow

@mountiny
Copy link
Contributor Author

Did not get around at the end of the week

@mountiny
Copy link
Contributor Author

Started a draft PR, I need to test it more and add automated tests too

@mountiny
Copy link
Contributor Author

PR is up and in review

@mountiny mountiny added the Reviewing Has a PR in review label Jan 30, 2024
@muttmuure
Copy link
Contributor

I think this is done and handled by an agency. Closing

@mountiny
Copy link
Contributor Author

mountiny commented Feb 9, 2024

Not sure this did not close, this should be completed no cahnges required in the App

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Internal Requires API changes or must be handled by Expensify staff NewFeature Something to build that is a new item. Reviewing Has a PR in review Weekly KSv2
Projects
None yet
Development

No branches or pull requests

4 participants