[HOLD for payment 2024-04-25] [MEDIUM] New Feature : Click to autofocus does not work in the Scan receipt camera

[kavimuru]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: 1.4.29-0
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @mountiny
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1705687521786479

Action Performed:

1. Scan a receipt using camera
2. Keep closer to the receipt
3. Try to tap in to focus the image

Expected Result:

We should be able to tap in to focus the image

Actual Result:

Click to autofocus does not work and cannot tap in to focus the image

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~018f43696563238cad
• Upwork Job ID: 1749863408754200576
• Last Price Increase: 2024-01-23

Issue Owner

Current Issue Owner: @Christinadobrzyn

[melvin-bot]

Triggered auto assignment to @NicMendonca (NewFeature), see https://stackoverflowteams.com/c/expensify/questions/14418#:~:text=BugZero%20process%20steps%20for%20feature%20requests for more details.

[mountiny]

Asking Margelo if they can work on this

[mrousavy]

Yup, we'll do it right after Flash for V3 is done!

[janicduplessis]

I can take this one!

[mountiny]

@janicduplessis Can you also address the rotation issue?

Our native apps have landscape mode disabled so the UI does not rotate but the camera does which leads to weird UX 😄

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~018f43696563238cad

[melvin-bot]

Triggered auto assignment to Contributor Plus for review of internal employee PR - @ishpaul777 (Internal)

[janicduplessis]

@mountiny Yes I can have a look at that also, should it be a separate issue / pr?

[mountiny]

It can be a same pr i think

[mountiny]

Progress is looking good

[melvin-bot]

Triggered auto assignment to @conorpendergrast (NewFeature), see https://stackoverflowteams.com/c/expensify/questions/14418#:~:text=BugZero%20process%20steps%20for%20feature%20requests for more details.

[NicMendonca]

Going on leave so re-assigning!

[mrousavy]

wdym it's not fully working yet @mountiny ?

[mountiny]

@mrousavy yeah on ios, you are still not able to focus from various distances I believe and there is this PR to help with it #35926

[mrousavy]

Ah yeah true, we might want to use the dual wide camera again so it can automatically switch to the "macro lens". I can also fix that in a follow-up PR once the V4 revert is reverted :)

[janicduplessis]

Yea, maybe you want to make that change @mrousavy, since in v4 the api to pick device is a lot nicer, right now I have to do the fallback to different cameras manually. I think our conclusion from that PR is the best is dual-wide -> ultra-wide -> wide as priority of device to use.

[mrousavy]

will do in a follow-up PR in a few mins!

[mountiny]

nice, thank you

[chrispader]

In #39589 there's the fix for macro autofocus on iOS devices

[mountiny]

Thanks, let me know if you need any help

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.62-17 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Fix: VisionCamera macro autofocus not working on iOS  #39589

If no regressions arise, payment will be issued on 2024-04-25. 🎊

For reference, here are some details about the assignees on this issue:

• @janicduplessis does not require payment (Contractor)
• @ishpaul777 requires payment (Needs manual offer from BZ)

[melvin-bot]

BugZero Checklist: The PR adding this new feature has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@ishpaul777] Please propose regression test steps to ensure the new feature will work correctly on production in further releases.
• [@Christinadobrzyn] Link the GH issue for creating/updating the regression test once above steps have been agreed upon.

[mountiny]

$250 to @ishpaul777

changed to $500 per - #34898 (comment)

[Christinadobrzyn]

Payouts due:

• Contributor+: $500 @ishpaul777 (upwork offer - https://www.upwork.com/nx/wm/offer/101986939)

Upwork job is here.

[ishpaul777]

The issue and second PR was before the bounty drop, I think the previous bounty should be applicable @mountiny @Christinadobrzyn 😃

[mountiny]

Thanks for flagging $500 it is

[melvin-bot]

Payment Summary

Upwork Job

• Contributor: @janicduplessis is from an agency-contributor and not due payment
• ROLE: @ishpaul777 paid $500 via Upwork (https://www.upwork.com/nx/wm/offer/101986939)

BugZero Checklist (@Christinadobrzyn)

• I have verified the correct assignees and roles are listed above and updated the neccesary manual offers
• I have verified that there are no duplicate or incorrect contracts on Upwork for this job (https://www.upwork.com/ab/applicants/1749863408754200576/hired)
• I have paid out the Upwork contracts or cancelled the ones that are incorrect
• I have verified the payment summary above is correct

[Christinadobrzyn]

Alright paid out based on this payment summary

No regression test here since it's Internal so closing. Let me know if I missed anything