Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[$500] Room - Unable to scroll up to the top in public room as anonymous user #34980

Closed
5 of 6 tasks
kbecciv opened this issue Jan 23, 2024 · 39 comments
Closed
5 of 6 tasks
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Engineering Hot Pick Ready for an engineer to pick up and run with Internal Requires API changes or must be handled by Expensify staff

Comments

@kbecciv
Copy link

kbecciv commented Jan 23, 2024

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!


Version Number: 1.4.30-0
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/4228454
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal team
Slack conversation:

Action Performed:

Precondition: user created a public room and added multiple messages

  1. Navigate to the public room via a link, e.g. https://staging.new.expensify.com/r/5408450846930023
  2. Scroll up to the very beginning

Expected Result:

User can scroll to the beginning of the chat history

Actual Result:

Flickering loading animation displayed, anonymous user is unable to scroll up to the beginning

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6352302_1706032162727.video_2024-01-23_12-42-30.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~015a97f638ac603602
  • Upwork Job ID: 1749853750439735296
  • Last Price Increase: 2024-01-23
@kbecciv kbecciv added External Added to denote the issue can be worked on by a contributor Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. labels Jan 23, 2024
@melvin-bot melvin-bot bot changed the title Room - Unable to scroll up to the top in public room as anonymous user [$500] Room - Unable to scroll up to the top in public room as anonymous user Jan 23, 2024
Copy link

melvin-bot bot commented Jan 23, 2024

Triggered auto assignment to @joekaufmanexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

Copy link

melvin-bot bot commented Jan 23, 2024

Job added to Upwork: https://www.upwork.com/jobs/~015a97f638ac603602

@melvin-bot melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Jan 23, 2024
Copy link

melvin-bot bot commented Jan 23, 2024

Triggered auto assignment to Contributor-plus team member for initial proposal review - @mananjadhav (External)

@kbecciv
Copy link
Author

kbecciv commented Jan 23, 2024

We think that this bug might be related to #vip-vsb
CC @quinthar

@joekaufmanexpensify
Copy link
Contributor

I can't reproduce this on web. Going to try on mobile

@joekaufmanexpensify
Copy link
Contributor

Okay, I can reproduce on mobile web:

2024-01-23_18-18-22.mp4

@joekaufmanexpensify
Copy link
Contributor

Agreed this feels like a #vip-vsb issue.

@s-alves10
Copy link
Contributor

This issue looks like a backend issue. GetOlderActions API returns the following error
image

@joekaufmanexpensify
Copy link
Contributor

Got it. @mananjadhav ,do you agree?

@mananjadhav
Copy link
Collaborator

Yeah looks like @s-alves10 is correct.

@joekaufmanexpensify joekaufmanexpensify added Internal Requires API changes or must be handled by Expensify staff and removed External Added to denote the issue can be worked on by a contributor Help Wanted Apply this label when an issue is open to proposals by contributors labels Jan 29, 2024
Copy link

melvin-bot bot commented Jan 29, 2024

Current assignee @mananjadhav is eligible for the Internal assigner, not assigning anyone new.

@joekaufmanexpensify
Copy link
Contributor

Got it. TY! Made it internal

@joekaufmanexpensify
Copy link
Contributor

Still needs an internal volunteer

@melvin-bot melvin-bot bot added the Overdue label Feb 2, 2024
@joekaufmanexpensify
Copy link
Contributor

Same

@melvin-bot melvin-bot bot added Overdue and removed Overdue labels Feb 2, 2024
Copy link

melvin-bot bot commented Feb 20, 2024

@mananjadhav @joekaufmanexpensify this issue is now 4 weeks old and preventing us from maintaining WAQ. This should now be your highest priority. Please post below what your plan is to get a PR in review ASAP. Thanks!

@melvin-bot melvin-bot bot added Daily KSv2 and removed Weekly KSv2 labels Feb 20, 2024
@joekaufmanexpensify joekaufmanexpensify added Weekly KSv2 and removed Daily KSv2 labels Feb 20, 2024
@mallenexpensify mallenexpensify added Daily KSv2 Hot Pick Ready for an engineer to pick up and run with and removed Weekly KSv2 labels Feb 21, 2024
@mallenexpensify
Copy link
Contributor

Posted in #vip-vsb cuz it's likely a priority with #exfy-roadmap
https://expensify.slack.com/archives/C066HJM2CAZ/p1708478107200569
also posted in #engineering

Bumped to Daily and added Hot Pick

@joekaufmanexpensify
Copy link
Contributor

Sounds good!

@melvin-bot melvin-bot bot added the Overdue label Feb 23, 2024
@joekaufmanexpensify
Copy link
Contributor

Still looking for internal volunteer

@melvin-bot melvin-bot bot added Overdue and removed Overdue labels Feb 23, 2024
@joekaufmanexpensify
Copy link
Contributor

Not overdue

@melvin-bot melvin-bot bot removed the Overdue label Feb 26, 2024
@joekaufmanexpensify
Copy link
Contributor

Waiting for engineer to grab

@mvtglobally
Copy link

Issue not reproducible during KI retests. (First week)

@joekaufmanexpensify
Copy link
Contributor

Got it. I will retest!

@melvin-bot melvin-bot bot added the Overdue label Mar 1, 2024
@joekaufmanexpensify
Copy link
Contributor

Will retest this afternoon

@melvin-bot melvin-bot bot removed the Overdue label Mar 1, 2024
@joekaufmanexpensify
Copy link
Contributor

Yep, this is no longer reproducible for me. Closing as this seems to be fixed!

@kbecciv
Copy link
Author

kbecciv commented Mar 5, 2024

QA team is able to reproduce the issue in build 1.4.47.0,
OP is updated with reproduction steps.

bandicam.2024-03-06.00-40-28-206.mp4

@kbecciv kbecciv reopened this Mar 5, 2024
@joekaufmanexpensify
Copy link
Contributor

Got it. I will try and reproduce!

@joekaufmanexpensify
Copy link
Contributor

I think this new report is a bit different than the original one. The original report here didn't really involve the skeleton UI. he new report seems like a dupe of #37661 . Closing as we're working on fixing the loading/scrolling of public rooms without showing the skeleton UI there!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Engineering Hot Pick Ready for an engineer to pick up and run with Internal Requires API changes or must be handled by Expensify staff
Projects
No open projects
Status: CRITICAL
Development

No branches or pull requests

7 participants