-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[HOLD for payment 2024-03-07] [$500] [MEDIUM] Scan - Merchant message disappears after deleting receipt and reappears after adding receipt #34997
Comments
Job added to Upwork: https://www.upwork.com/jobs/~01f34025c8418af8d7 |
Triggered auto assignment to @kadiealexander ( |
Triggered auto assignment to Contributor-plus team member for initial proposal review - @c3024 ( |
We think that this bug might be related to #wave6. |
ProposalPlease re-state the problem that we are trying to solve in this issue.Merchant error message disappeared even it's a policy chat What is the root cause of that problem?The problem starts here App/src/components/ReportActionItem/MoneyRequestView.js Lines 222 to 226 in 872eb17
hasErrors is true when we have required empty fields after scanning. When we delete a receipt, hasReceipt becomes false, indicating that the corresponding hasErrors will also be false, and no error will be displayed.
What changes do you think we should make in order to solve the problem?We can change this to
The error will be displayed only when we don't have a receipt being scanned, and it is a policy expense chat and merchant is empty. What alternative solutions did you explore? (Optional)We can add another check !TransactionUtils.isReceiptBeingScanned(transaction) here
|
ProposalPlease re-state the problem that we are trying to solve in this issue.
What is the root cause of that problem?
What changes do you think we should make in order to solve the problem?
What alternative solutions did you explore? (Optional)
|
I'll update in a few hours. Thanks for the bump. |
We don't show RBR and error for the required fields when they are empty only while the receipt is scanned. The empty field check is already being done so checking whether the receipt is scanned as suggested by @Nodebrute is I think the correct way to fix this. However, this change should be done for all required fields as well as the brick indicator field. In cases when there is no receipt, setting
|
Triggered auto assignment to @Julesssss, see https://stackoverflow.com/c/expensify/questions/7972 for more details. |
|
@Julesssss bump! |
I was sick, but it looks like we should now discuss @dukenv0307's points before committing to the proposal.
|
This comment was marked as off-topic.
This comment was marked as off-topic.
This issue has not been updated in over 15 days. @Julesssss, @kadiealexander, @c3024, @dukenv0307 eroding to Monthly issue. P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do! |
The PR is merged. |
|
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.45-6 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue: If no regressions arise, payment will be issued on 2024-03-07. 🎊 For reference, here are some details about the assignees on this issue:
|
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
|
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
Regression Test Proposal
👍 or 👎 |
If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results. If a regression has occurred and you are the assigned CM follow the instructions here. If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future. |
Ignore ^ |
Payouts due:
Upwork job is here. |
Issue for adding steps to Testrail: https://github.com/Expensify/Expensify/issues/376654 |
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Version Number: 1.4.30-0
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:
Action Performed:
Expected Result:
Since merchant is a requirement for workspace request, the merchant requirement message will remain until a merchant is entered
Actual Result:
After deleting the receipt while merchant is empty, the merchant message disappears. After adding a receipt, the message reappears
Workaround:
Unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
Screenshots/Videos
Add any screenshot/video evidence
Bug6352447_1706038465358.20240123_234633.mp4
View all open jobs on GitHub
Upwork Automation - Do Not Edit
The text was updated successfully, but these errors were encountered: