-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[$1000] Jump to last unread chat when opening a report #35011
Comments
Triggered auto assignment to @trjExpensify ( |
Job added to Upwork: https://www.upwork.com/jobs/~01fc144b2f2f5df388 |
Triggered auto assignment to Contributor-plus team member for initial proposal review - @mollfpr ( |
This PR #28793 specifically makes it scrolled to the bottom, seems like NAB |
I'm a bit confused by the bug report @MonilBhavsar, so asking about it here. I thought this was something we'd implement via comment linking. |
HOLD for comment linking: #30269 |
Current assignee @trjExpensify is eligible for the NewFeature assigner, not assigning anyone new. |
No change, still on hold Melv! |
Samesies, Melv! |
Thanks @rlinoz |
@janicduplessis can I assign you to this one? |
@rlinoz Yes! |
@janicduplessis just sent you a DM with how to access that |
We have draft PRs for backend and frontend |
PR still in WIP, @janicduplessis Any updates? |
The PR is mostly working already, but there is an edge case that will require some refactoring of ReportActionsView / ReportActionsList so we can reuse the logic to start the list at a specific reportActionID. I will work on this in a separate PR to avoid making the current one giant. |
Have a new PR up to refactor how we handle opening the list at a specific index. Before it was mixed with the comment linking code and now it is extracted out to BaseInvertedFlatList so it will make it easy to use for opening the report at last unread message too. #52149, currently in draft, will test more and complete checklist later today. |
@janicduplessis is the PR ready for a re-review from @ishpaul777? |
Yes, I have fixed the issue he found |
I'll rereview in couple hours |
What's the latest here? |
@janicduplessis is finding time to fix a bug @ishpaul777 found in the first PR |
#52149 is ready. After that it will make implementing the functionality simple |
Looks like we have conflicts to resolve, @janicduplessis. Can you jump on those? Thanks! |
@janicduplessis how's this one going? |
First PR is in the last steps I think, just some lint fix missing and I will review it again |
If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!
Version Number: 1.4.28.0
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @MonilBhavsar
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1705558628672569
Action Performed:
Expected Result:
The chat report view opens from where the messages are unread and user can scroll down
Actual Result:
The chat report view is scrolled down to the last message and user needs to scroll up to find last read message
Workaround:
Unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
Screenshots/Videos
Add any screenshot/video evidence
Recording.5931.mp4
View all open jobs on GitHub
Upwork Automation - Do Not Edit
Issue Owner
Current Issue Owner: @roryabrahamThe text was updated successfully, but these errors were encountered: