Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HOLD for payment 2024-02-07] Update code to allow for redirect links from multiple sources #35088

Closed
caitlinwhite1 opened this issue Jan 24, 2024 · 4 comments
Assignees
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Improvement Item broken or needs improvement. Weekly KSv2

Comments

@caitlinwhite1
Copy link
Contributor

Problem:
Currently our code for redirecting links only expects links between community>HelpDot and we'll have to redirect from other sources.

Solution:
Update the code to also allow for redirects from HelpDot to UseDot. For example, we'd like https://help.expensify.com/articles/expensify-classic/expensify-card/Expensify-Card-Perks to redirect to https://use.expensify.com/company-credit-card. Ideally we can have a folder we can easily update at anytime similar to community redirects here.

@caitlinwhite1 caitlinwhite1 added Weekly KSv2 Improvement Item broken or needs improvement. labels Jan 24, 2024
@melvin-bot melvin-bot bot added Reviewing Has a PR in review Weekly KSv2 and removed Weekly KSv2 labels Jan 24, 2024
@caitlinwhite1
Copy link
Contributor Author

ohh also @coleaeason Is it possible to update the code to allow for redirects from help. > help? Or that's already doable?
We'll need this for deleted help. article.

@coleaeason
Copy link
Contributor

@caitlinwhite1 that's also supported with the updated code! The source can be from community or help and the destination can be help or use dot. So you can do any of the below combinations:

sourceURL destinationURL
community.expensify.com help.expensify.com
community.expensify.com use.expensify.com
help.expensify.com help.expensify.com
help.expensify.com use.expensify.com

Also this is done and merged, so feel free to make your new redirects in the redirects.csv file!

@melvin-bot melvin-bot bot added Weekly KSv2 Awaiting Payment Auto-added when associated PR is deployed to production and removed Weekly KSv2 labels Jan 31, 2024
@melvin-bot melvin-bot bot changed the title Update code to allow for redirect links from multiple sources [HOLD for payment 2024-02-07] Update code to allow for redirect links from multiple sources Jan 31, 2024
@melvin-bot melvin-bot bot removed the Reviewing Has a PR in review label Jan 31, 2024
Copy link

melvin-bot bot commented Jan 31, 2024

Reviewing label has been removed, please complete the "BugZero Checklist".

Copy link

melvin-bot bot commented Jan 31, 2024

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.33-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2024-02-07. 🎊

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Improvement Item broken or needs improvement. Weekly KSv2
Projects
None yet
Development

No branches or pull requests

2 participants