[HOLD for payment 2024-02-07] Bank account - Wrong account number error is still shown after restarting the add BA process

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: 1.4.31-2
Reproducible in staging?: Y
Reproducible in production?: no, unable to check prod
If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/4234233
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:

Action Performed:

Pre-requisite: user must be logged in and have created a Workspace

1. Go to Settings > Workspaces > Select Workspace > Bank account
2. Try to add BA with Plaid, selecting Chase bank and the account ending in "1111"
3. When entering the account number, enter "1111222233334444", an error should appear when trying to submit the form
4. Restart the process selecting the same bank and the account ending in "1111"

Expected Result:

No error should appear as the process was restarted

Actual Result:

Wrong account number error is shown after the process is restarted

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6353608_1706123110216.bandicam_2024-01-24_14-12-26-902.mp4

View all open jobs on GitHub

[melvin-bot]

Triggered auto assignment to @NikkiWines (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[NikkiWines]

Hmm, yeah we should probably be clearing the errors once you press Connect online with Plaid

Side note also that the styling for the dropdown for the accounts is a bit wonky

[NikkiWines]

dropdown looks fine on dev MacOS-Chrome though, probably a platform-specific thing.

I'm able to reproduce the issue on dev, looking into a fix now.

[NikkiWines]

@thienlnam since you're App deployer this week, if the above PR isn't merged / CP'd by tomorrow I wouldn't hold the deploy on this since the behavior is pretty niche and it's not a significant error or breaking anything really.

[thienlnam]

Sounds good, thanks!

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.33-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Don't persist error after reconnecting with plaid #35117

If no regressions arise, payment will be issued on 2024-02-07. 🎊

[melvin-bot]

Skipping the payment summary for this issue since all the assignees are employees or vendors. If this is incorrect, please manually add the payment summary SO.

[NikkiWines]

@rushatgabhane do we owe you payment for reviewing #35117?

[melvin-bot]

@NikkiWines Whoops! This issue is 2 days overdue. Let's get this updated quick!

[NikkiWines]

Seems we are all set here, closing!

[rushatgabhane]

Hi @NikkiWines, i missed this because i wasn't assigned.
Anyway, could you please attach payment summary for review of

• Don't persist error after reconnecting with plaid #35117

[melvin-bot]

Triggered auto assignment to @twisterdotcom (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[NikkiWines]

@twisterdotcom can we issue payment to @rushatgabhane for reviewing #35117 please 🙇

[twisterdotcom]

@rushatgabhane is paid via newDot: https://github.com/Expensify/Web-Expensify/blob/058e9134d8e6b038b9a31364f496406e2b2415a7/_devportal/lib/KernelScheduling/Data.php#L261C10-L261C23

[twisterdotcom]

Payment Summary:

• @rushatgabhane paid $500 via NewDot Requests (C+)

[JmillsExpensify]

$500 approved for @rushatgabhane based on summary above.