Offline indicator is missing on Welcome to Expensify page

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: 1.4.31-1
Reproducible in staging?: y
Reproducible in production?: n
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:

Action Performed:

1. Navigate to staging.new.expensify.com
2. Create new account
3. Welcome to Expensify page will appear
4. Go offline

Expected Result:

Offline indicator should appear on Welcome to Expensify page when user goes offline

Actual Result:

Offline indicator is missing on Welcome to Expensify page

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6353797_1706129997337.az_recorder_20240124_182201.mp4

View all open jobs on GitHub

[melvin-bot]

Triggered auto assignment to @rlinoz (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[situchan]

This is new feature from #32154
cc: @stitesExpensify

[stitesExpensify]

Yeah, I don't think that this needs to be a blocker. If the user goes offline and chooses an option then everything will work just fine, and then they will see the offline indicator on the main page.

[melvin-bot]

Triggered auto assignment to @dannymcclain (Design), see these Stack Overflow questions for more details.

[rlinoz]

Hey @dannymcclain!

I want to understand if we really want to add the offline indicator here, since in phone screens this is actually a modal

Just like our actions modal, which doesn't show an offline indicator

[dannymcclain]

I want to understand if we really want to add the offline indicator here

I would say no. I agree with you that since this is a modal and not an actual screen/view, it probably should not include the offline indicator. cc @Expensify/design in case anyone disagrees.

[shawnborton]

Agree with you!

On a separate note.. is it just me or does the illustration here feel massive? cc @stitesExpensify

[dannymcclain]

It does feel quite large.

[rlinoz]

I am going to close this one then, but should we do something about the image?

[shawnborton]

@stitesExpensify thoughts on following up and cleaning up the image styles?

[stitesExpensify]

Sure, we can do that. Feel free to make an issue and assign me! Some details on how big it should be would be much appreciated too :)

[dubielzyk-expensify]

This was the original mock:

We changed the illustration to the animation, but to avoid cutoff it needs to be scaled up. Perhaps we can match it closer to the height of the original mock?

[shawnborton]

Yeah, I'm thinking we should ask Augenblick to get us a version of that animation where the hands are way longer so we can make a more wide illustration as opposed to something more square in proportion.

[shawnborton]

Though @dubielzyk-expensify before we get too crazy with this one... what's the relationship between this particular page and the Wave 9 work you are doing here? Basically, will we get rid of this particular page once the Wave 9 stuff is in place?

[stitesExpensify]

AFAIK this will be replaced when wave9 comes out

[shawnborton]

Got if, if that's the case I am inclined to just do nothing for now...