[LOW] [P2P] [$500] Expense - Mentioning payment sender in IOU thread says user isn't a member of this room

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: 1.4.31.1
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @shawnborton
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1706185536516179

Action Performed:

1. User A sends a payment to User B. Then User B @mentions user A in that same IOU thread.

Expected Result:

Whisper saying user is not a member of this room should not be shown.

Actual Result:

Whisper saying user is not a member of this room is shown.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~016219e2ce558b977a
• Upwork Job ID: 1750564810849771520
• Last Price Increase: 2024-02-01

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~016219e2ce558b977a

[melvin-bot]

Triggered auto assignment to @jliexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @sobitneupane (External)

[kbecciv]

We think that this bug might be related to #vip-vsb
CC @quinthar

[FitseTLT]

I think this should be fixed on BE because it is nice to have the mention although it is not a room but it shouldn't try to join the user to the report if it is not a room that the comment is being made.

[jliexpensify]

Posted here - https://expensify.slack.com/archives/C066HJM2CAZ/p1706488633882819

[jliexpensify]

@sobitneupane could you confirm this comment? If so, we can assign this as Internal, thanks!

[jliexpensify]

@sobitneupane bump on my question!

[sobitneupane]

I couldn't find the frontend logic responsible for triggering user invitations when mentioned. It's likely handled on the backend, so we can label this as an internal task.

[melvin-bot]

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

[melvin-bot]

Current assignee @sobitneupane is eligible for the Internal assigner, not assigning anyone new.

[melvin-bot]

Current assignee @jliexpensify is eligible for the Bug assigner, not assigning anyone new.

[jliexpensify]

Added Hot Pick label

[melvin-bot]

@sobitneupane, @jliexpensify Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[jliexpensify]

Changed to Weekly as we wait for an Internal Engineer to pick this up

[melvin-bot]

@sobitneupane @jliexpensify this issue is now 4 weeks old and preventing us from maintaining WAQ. This should now be your highest priority. Please post below what your plan is to get a PR in review ASAP. Thanks!

[jliexpensify]

Still waiting on an Internal Engineer

[jliexpensify]

Still waiting on engineer

[mvtglobally]

Issue not reproducible during KI retests. (First week)

[jliexpensify]

Cool, going to close this!