[HOLD for payment 2024-04-04] [$500] Chat - The app crashes when opening a high resolution image

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: 1.4.31.1
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:

Action Performed:

1. Upload the provided high resolution image to any chat
2. Tap on it once it finished loading

Expected Result:

It shouldn't crash.

Actual Result:

The app crashes when opening a high resolution image. On iOS mWeb it crashed as soon as I select the image with a blank preview

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6354861_1706199122408.ERTA4321.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01788ec8d9af6ffdc5
• Upwork Job ID: 1750587875060334592
• Last Price Increase: 2024-04-15

Issue Owner

Current Issue Owner: @sakluger

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01788ec8d9af6ffdc5

[melvin-bot]

Triggered auto assignment to @sakluger (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @aimane-chnaif (External)

[FitseTLT]

Proposal

Please re-state the problem that we are trying to solve in this issue.

The app crashes when opening a high resolution image

What is the root cause of that problem?

We are not limiting the resolution as we do for Avatar

App/src/components/AvatarWithImagePicker.js

Lines 207 to 211 in e9f27ab

	const isValidResolution = (image) =>
	getImageResolution(image).then(
	({height, width}) => height >= CONST.AVATAR_MIN_HEIGHT_PX && width >= CONST.AVATAR_MIN_WIDTH_PX && height <= CONST.AVATAR_MAX_HEIGHT_PX && width <= CONST.AVATAR_MAX_WIDTH_PX,
	);

What changes do you think we should make in order to solve the problem?

We should implement a resolution limit for attachements too as we did for avatar
Check if the resolution of the uploaded image has greater than the max resolution and set/display error message (same as what we did for avatar).

What alternative solutions did you explore? (Optional)

[ZhenjaHorbach]

@kbecciv
Can you provide an image example?

[kbecciv]

@ZhenjaHorbach I have original file, but unable to attach to GH

[aimane-chnaif]

@FitseTLT can you share reproducible image?

[aimane-chnaif]

@ZhenjaHorbach I have original file, but unable to attach to GH

@kbecciv Can you please upload to cloud somewhere (i.e. google drive) and share link?

[kbecciv]

Sent DM for file https://expensify.slack.com/archives/D05CP2F12RE/p1706729679968449

[aimane-chnaif]

Here's image:

https://drive.google.com/file/d/1EkOCX20cD_JAHVa-HhKiu5d-B3b5Qucb/view?usp=sharing

[melvin-bot]

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

[aimane-chnaif]

Awaiting proposals

[sakluger]

Adding to #vip-vsb. Hopefully we'll get some more proposals soon!

[melvin-bot]

@sakluger @aimane-chnaif this issue was created 2 weeks ago. Are we close to approving a proposal? If not, what's blocking us from getting this issue assigned? Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

[mountiny]

@sakluger should be able to help with the payment

[sakluger]

Summarizing payment on this issue:

Contributor: @jsdev2547 $500, sent Upwork offer: https://www.upwork.com/nx/wm/offer/101896672
Contributor+: @aimane-chnaif $500, sent Upwork offer: https://www.upwork.com/nx/wm/offer/101896675

[sakluger]

Paid @jsdev2547, now just waiting for @aimane-chnaif to accept the offer.

[sakluger]

Hey @aimane-chnaif could you please accept the Upwork offer?

[sakluger]

Bumped Aimane in Slack.

[sakluger]

Aimane is OOO, we'll wait a few more days before checking back in.

[sakluger]

Moving this to weekly since I'm not sure when Aimane will be back online. @aimane-chnaif feel free to DM me in Slack once you're back.

[sakluger]

Still OOO.

[melvin-bot]

Triggered auto assignment to @muttmuure (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[sakluger]

Hey @muttmuure, assigning to you while I'm OOO for the next two weeks.

We still owe Aimane payment for this issue via Upwork, but he's been OOO for the past month or so and so he never accepted the Upwork offer. Can you keep an eye on this every once in a while, and if Aimane gets back before I return, please pay out the Upwork offer (or send a new one if the old one has expired)?

[aimane-chnaif]

Apologies for the delay. Accepted offer

[sakluger]

Welcome back! I just got back from OOO as well.

The contact is all paid out, we can close out this issue.