[HOLD for payment 2024-02-20] [$500] Task - The assignee ">" arrow is not grayed out when creating tasks offline

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: 1.4.32-2
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:

Action Performed:

1. Open a chat
2. Navigate to offline mode
3. Go to the assign task, enter the title, and complete the flow
4. Click on the task and hover over the assignee

Expected Result:

The Assignee and arrow should be grayed out when creating tasks offline

Actual Result:

The assignee ">" arrow is not grayed out when creating tasks offline

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6355164_1706218851535.2024-01-26_01-22-50.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01c0e46b804f5e69b6
• Upwork Job ID: 1750639313882955776
• Last Price Increase: 2024-01-25
• Automatic offers:
• fedirjh | Reviewer | 28124121
• neonbhai | Contributor | 28124123

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01c0e46b804f5e69b6

[melvin-bot]

Triggered auto assignment to @kevinksullivan (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @fedirjh (External)

[lanitochka17]

We think that this bug might be related to #vip-vsp
CC @quinthar

[neonbhai]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Task - The assignee ">" arrow is not grayed out when creating tasks offline

What is the root cause of that problem?

The assignee MenuItem here is not wrapped in OfflineWithFeedback

What changes do you think we should make in order to solve the problem?


We should wrap the MenuItem here with the outer OfflineWithFeedback defined here:

App/src/components/ReportActionItem/TaskView.js

Line 163 in 8cc80e6

<OfflineWithFeedback pendingAction={lodashGet(props, 'report.pendingFields.managerID')}>


<OfflineWithFeedback pendingAction={lodashGet(props, 'report.pendingFields.managerID')}>

   {props.report.managerID ? (

     <MenuItem

         ...

     /> 
   ) : (

     <MenuItemWithTopDescription

         ...

     /> 

</OfflineWithFeedback>

[fedirjh]

@neonbhai we have report.pendingFields.managerID , managerID is the assignee

[neonbhai]

ah right, thanks!

[fedirjh]

Looks good, let's wrap both menu items with the same OfflineWithFeedback.

[fedirjh]

@Krishna2323 It's repo with empty assignee.

[Krishna2323]

@fedirjh, got it, I was creating with an assignee that's why.

[neonbhai]

Proposal Updated

[fedirjh]

@neonbhai Proposal looks good to me.

🎀 👀 🎀 C+ reviewed

[melvin-bot]

Triggered auto assignment to @tylerkaraszewski, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[melvin-bot]

📣 @fedirjh 🎉 An offer has been automatically sent to your Upwork account for the Reviewer role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job

[melvin-bot]

📣 @neonbhai 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[fedirjh]

@neonbhai when can we expect PR?

[fedirjh]

cc @neonbhai friendly bump.

[neonbhai]

Raising PR by EOD!

[neonbhai]

Sorry for the delay, PR ready for review!

[melvin-bot]

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.40-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• [Task] Fix Assignee MenuItem when Offline #36048

If no regressions arise, payment will be issued on 2024-02-20. 🎊

For reference, here are some details about the assignees on this issue:

• @fedirjh requires payment automatic offer (Reviewer)
• @neonbhai requires payment automatic offer (Contributor)

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@fedirjh] The PR that introduced the bug has been identified. Link to the PR:
• [@fedirjh] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@fedirjh] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@fedirjh] Determine if we should create a regression test for this bug.
• [@fedirjh] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@kevinksullivan] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[kevinksullivan]

@fedirjh can you please complete the checklist above?

[kevinksullivan]

Payments made, just waiting on checklist.

[fedirjh]

BugZero Checklist:

• Link to the PR: feat: task view with offline with feedback #23705
• Link to comment: feat: task view with offline with feedback #23705 (comment)
• Link to discussion: N/A Nothing to add to the checklist. This bug should have been caught during testing.
• Determine if we should create a regression test for this bug: N/A this is a minor bug, no need for a regression test