Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[LOW] [Splits] [$500] [MEDIUM] Web - IOU - Receipt from manual request remains on Admins account when Employee delete it #35208

Closed
1 of 6 tasks
lanitochka17 opened this issue Jan 25, 2024 · 52 comments
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. Engineering Hot Pick Ready for an engineer to pick up and run with Internal Requires API changes or must be handled by Expensify staff Weekly KSv2

Comments

@lanitochka17
Copy link

lanitochka17 commented Jan 25, 2024

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!


Version Number: 1.4.32-2
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:

Action Performed:

  1. Employee creates manual request on collect workspace chat
  2. Employee add a receipt to IOU
  3. Employee delete the receipt
  4. Admin open the IOU request

Expected Result:

Receipt should be not presented on Admin's side

Actual Result:

After deletion receipt is still present until refresh the page

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6355227_1706222212610.Recording__1932.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~014fe31ab963ba8b49
  • Upwork Job ID: 1750654064488505344
  • Last Price Increase: 2024-02-15
@lanitochka17 lanitochka17 added External Added to denote the issue can be worked on by a contributor Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. labels Jan 25, 2024
Copy link

melvin-bot bot commented Jan 25, 2024

Job added to Upwork: https://www.upwork.com/jobs/~014fe31ab963ba8b49

@melvin-bot melvin-bot bot changed the title Web - IOU - Receipt from manual request remains on Admins account when Employee delete it [$500] Web - IOU - Receipt from manual request remains on Admins account when Employee delete it Jan 25, 2024
Copy link

melvin-bot bot commented Jan 25, 2024

Triggered auto assignment to @MitchExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

@melvin-bot melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Jan 25, 2024
Copy link

melvin-bot bot commented Jan 25, 2024

Triggered auto assignment to Contributor-plus team member for initial proposal review - @allroundexperts (External)

@lanitochka17
Copy link
Author

We think that this bug might be related to #wave5.
CC @dylanexpensify

@bernhardoj
Copy link
Contributor

Looks like the pusher doesn't send an update to remove the receipt

@MitchExpensify
Copy link
Contributor

Wave 5 worthy @dylanexpensify ?

@melvin-bot melvin-bot bot added the Overdue label Jan 30, 2024
@MitchExpensify
Copy link
Contributor

Friendly bump @dylanexpensify

@melvin-bot melvin-bot bot removed the Overdue label Jan 31, 2024
Copy link

melvin-bot bot commented Feb 1, 2024

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

@melvin-bot melvin-bot bot added the Overdue label Feb 2, 2024
Copy link

melvin-bot bot commented Feb 5, 2024

@allroundexperts, @MitchExpensify Huh... This is 4 days overdue. Who can take care of this?

@MitchExpensify
Copy link
Contributor

Checking in with @dylanexpensify 👀

@melvin-bot melvin-bot bot removed the Overdue label Feb 6, 2024
@dylanexpensify
Copy link
Contributor

DMing back!

@rezkiy37
Copy link
Contributor

rezkiy37 commented Feb 8, 2024

Hi, I’m Michael (Mykhailo) from Callstack and I would like to work on this issue.

Copy link

melvin-bot bot commented Feb 8, 2024

@allroundexperts @MitchExpensify this issue was created 2 weeks ago. Are we close to approving a proposal? If not, what's blocking us from getting this issue assigned? Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

Copy link

melvin-bot bot commented Feb 8, 2024

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

@rezkiy37
Copy link
Contributor

rezkiy37 commented Feb 8, 2024

I've investigated the bug. I can confirm that it is still replicable. I see that we actively use the Pusher for this logic. So, the Pusher does not send an update for an admin, when a member removed a receipt. Also, even after a re-fetching data, it is does not overwrite a receipt property of a transaction. It resets a filename property, but it is not enough.
So, after this, I can say that someone should handle this from the backend side.

Receipt.Bug.mp4

@rezkiy37
Copy link
Contributor

As Vit said before #35208 (comment). Looks like that's an internal issue for the internal devs.

@MitchExpensify
Copy link
Contributor

We either do not push the updates correctly (internal) or we do not re-render the UI based on the updated data correctly (and you need to refresh)

@mountiny do you have any bandwidth to check this out?

@melvin-bot melvin-bot bot removed the Overdue label Mar 25, 2024
@mountiny
Copy link
Contributor

Not at the moment, still focusing on Wave collect release 1

@rezkiy37
Copy link
Contributor

Should we mark this issue as "On Hold"?

@mountiny mountiny added the Hot Pick Ready for an engineer to pick up and run with label Mar 27, 2024
@mountiny
Copy link
Contributor

Why on hold? Its ready to be investigated, I have added the Hot Pick label

@rezkiy37
Copy link
Contributor

Ah, good. I misunderstood this comment.

@melvin-bot melvin-bot bot added the Overdue label Apr 1, 2024
@MitchExpensify
Copy link
Contributor

Waiting on Internal volunteer, Melvin

@melvin-bot melvin-bot bot removed the Overdue label Apr 1, 2024
@MitchExpensify MitchExpensify added Overdue Weekly KSv2 and removed Daily KSv2 labels Apr 1, 2024
@melvin-bot melvin-bot bot removed the Overdue label Apr 1, 2024
@melvin-bot melvin-bot bot added the Overdue label Apr 11, 2024
@mvtglobally
Copy link

Issue not reproducible during KI retests. (First week)

@MitchExpensify
Copy link
Contributor

MitchExpensify commented Apr 15, 2024

I was unable to reproduce this on v1.4.62-8

@melvin-bot melvin-bot bot removed the Overdue label Apr 15, 2024
@melvin-bot melvin-bot bot added the Overdue label Apr 23, 2024
@rezkiy37
Copy link
Contributor

Hey!
I just wanted to let you know about my vacation for next week. I will be back on 06.05.2024. Meanwhile, I asked @waterim to take over this issue.
See you soon!

@MitchExpensify
Copy link
Contributor

@waterim Are you able to reproduce this> I am not currently able to

@mvtglobally
Copy link

Issue not reproducible during KI retests. (Second week)

@mvtglobally
Copy link

Issue not reproducible during KI retests. (Third week)

@melvin-bot melvin-bot bot added the Overdue label May 7, 2024
@melvin-bot melvin-bot bot removed the Overdue label May 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. Engineering Hot Pick Ready for an engineer to pick up and run with Internal Requires API changes or must be handled by Expensify staff Weekly KSv2
Projects
No open projects
Development

No branches or pull requests

8 participants