[HOLD for payment 2024-02-07] [$500] IOU - Options missing from context menu when long tap IOU report

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: 1.4.32-2
Reproducible in staging?: y
Reproducible in production?: n
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:

Action Performed:

1. Open the app and log in
2. Open any chat
3. Tap the "+" button > Request money
4. Enter the amount and send the request
5. Tap the IOU preview
6. Long tap the IOU report

Expected Result:

All menu options are displayed

Actual Result:

"Reply in thread", "Edit request", "Join thread" and "Delete request" are missing from the context menu. All menu options are shown if I tap the space next to the IOU report

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6355735_1706271564870.video_2024-01-26_07-18-43.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~0162812b157c77d0a5
• Upwork Job ID: 1751344574990077952
• Last Price Increase: 2024-01-27
• Automatic offers:
• bernhardoj | Contributor | 28125971
• hoangzinh | Contributor | 28127215

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot]

Triggered auto assignment to @srikarparsi (Engineering), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[kbecciv]

We think that this bug might be related to #vip-bills
CC @davidcardoza

[kbecciv]

Issue is not reproducible in production

Bug6355735_1706271564839.prod.mp4

[bernhardoj]

Proposal

Please re-state the problem that we are trying to solve in this issue.

There are some missing menus when long pressing an IOU preview.

What is the root cause of that problem?

This happens after #34011. In #34011, we start passing the correct chatReportID to MoneyRequestAction.

App/src/pages/home/report/ReportActionItem.js

Lines 348 to 350 in 675b2c3

	<MoneyRequestAction
	// If originalMessage.iouReportID is set, this is a 1:1 money request in a DM chat whose reportID is props.report.chatReportID
	chatReportID={originalMessage.IOUReportID ? props.report.chatReportID : props.report.reportID}

However, we have an old code that relies on the wrong code.

App/src/components/ReportActionItem/MoneyRequestPreview.js

Lines 190 to 192 in 675b2c3

	const showContextMenu = (event) => {
	showContextMenuForReport(event, props.contextMenuAnchor, props.chatReportID, props.action, props.checkIfContextMenuActive);
	};

chatReportID is the report ID of the chat that the IOU belongs to. Previously, chatReportID was the IOU report id itself (wrong).

showContextMenuForReport expects the report ID that we pass is the current report ID.

App/src/components/ShowContextMenuContext.ts

Lines 37 to 40 in 675b2c3

	function showContextMenuForReport(
	event: GestureResponderEvent | MouseEvent,
	anchor: RNText | null,
	reportID: string,

But because chatReportID is not the current report ID, some menus are missing and it's because it can't find the report action from the report actions collection.

App/src/pages/home/report/ContextMenu/BaseReportActionContextMenu.tsx

Lines 120 to 125 in 675b2c3

	const reportAction: OnyxEntry<ReportAction> = useMemo(() => {
	if (isEmptyObject(reportActions) || reportActionID === '0') {
	return null;
	}
	return reportActions[reportActionID] ?? null;
	}, [reportActions, reportActionID]);

What changes do you think we should make in order to solve the problem?

Update the old code to use the correct report ID.

props.iouReportID || props.chatReportID

But iouReportID has a default value of '0', so we need to make it an empty string.

App/src/pages/home/report/ReportActionItem.js

Line 346 in 675b2c3

const iouReportID = originalMessage.IOUReportID ? originalMessage.IOUReportID.toString() : '0';

What alternative solutions did you explore? (Optional)

Or we can pass a new props called reportID alongside chatReportID and iouReportID that the value will always be the current report reportID and pass it to showContextMenuForReport.

[srikarparsi]

This proposal looks good to me, are you able to work on a PR @bernhardoj?

[bernhardoj]

@srikarparsi I'm available now

[srikarparsi]

Cool, assigning you to the issue

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~0162812b157c77d0a5

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @parasharrajat (External)

[melvin-bot]

📣 @bernhardoj 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[bernhardoj]

@srikarparsi PR is ready

[srikarparsi]

PR in review by @hoangzinh

[melvin-bot]

📣 @hoangzinh 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.32-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• [CP Staging] Fix missing context menu options on money request preview #35285

If no regressions arise, payment will be issued on 2024-02-05. 🎊

For reference, here are some details about the assignees on this issue:

• @hoangzinh requires payment automatic offer (Contributor)
• @bernhardoj requires payment automatic offer (Contributor)

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.33-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• [CP Staging] Fix missing context menu options on money request preview #35285

If no regressions arise, payment will be issued on 2024-02-07. 🎊

For reference, here are some details about the assignees on this issue:

• @hoangzinh requires payment automatic offer (Contributor)
• @bernhardoj requires payment automatic offer (Contributor)

[melvin-bot]

Issue is ready for payment but no BZ is assigned. @lschurr you are the lucky winner! Please verify the payment summary looks correct and complete the checklist. Thanks!

[lschurr]

Not overdue. This is will be reviewed and paid today.

[lschurr]

Payment summary:

• Contributor: @bernhardoj $500 paid in Upwork
• Contributor+: @hoangzinh $500 pain in Upwork

[lschurr]

This is complete.